From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A598BA0524 for ; Fri, 5 Feb 2021 12:20:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9319C4067B; Fri, 5 Feb 2021 12:20:36 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id A9ECD4067B for ; Fri, 5 Feb 2021 12:20:35 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id d16so7214899wro.11 for ; Fri, 05 Feb 2021 03:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dnSqqLnl+z9f0uQxxrDobm45we01utbRz1P72dL4/mk=; b=qWRsTWHUvp1N8Gbyf3u/uo85TQSdpdhO7IhcFmEPHji1mLIjVOgFMELuWAJfjMluCI FxyM+eezBogKvhq3lOZe6SMNvcs6c59lCnE/tla7cWftYZBNMhqJEoIrQLCIdwuYCjP3 jhH+aHfuQvXbaN7t+7ZNmvjjtzL/mFkuUQzqTiq4EoByJ09vTtmMixwamgBt/BLZVyNJ blSaFfPUo4X2N00muwK1Wj8/6DZdIdJZwHtdQQTaLq0MDSofRIJ/ls5qbTyRQD48vdeO BfgTXdxYfgZb1EQTcPvaJKVWQozLMURmDZtKKSyJtiM7lQV6F425F72dF4wrMwwtT9ie 3ypQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dnSqqLnl+z9f0uQxxrDobm45we01utbRz1P72dL4/mk=; b=IV3piYo/P0CrFN85uaW2Nvu5DBEstA53ccPHKiFgTp0KADJC64bfBW24ut31Tn0nsZ EzCYnYxHvFFove17/3u0GA5FQq6f1Gp2GJiq6ll3pBu2NcJ67Iqp95A/5wlhY4pmx91+ IsvVfjZesJiwdNKSXEEbwy8ZxTTTs2yDeiskjrPo80FwawYPVo9DMVG0eZ9QUDx7p7OI dQu3J1l0vQz0StUIEW3DE5nPJlSEfNCqjdDsQo1jAC3SQ1nepUUdaRbgkXGNmNg6foln AwO0mrCYhYIG1ecBMSUUQ72BrLTnswoRPYlrSNYUDL80pKcGijyESHcqV2aSUf/reupv DICg== X-Gm-Message-State: AOAM531gS5OkcAYtaOALngI14dwjJJCGIVG2ciZ+t41K+DlK/7BOuybz uam/nsGWszaXhcHTOLMGrHA= X-Google-Smtp-Source: ABdhPJx68CliLNc2zWtdL8qpvH8gjCVmXBgNrso0Ec4NpCondKFz7GbDqfA9vK5Lj50lm6G8yF0J9Q== X-Received: by 2002:adf:fc86:: with SMTP id g6mr4477781wrr.20.1612524035471; Fri, 05 Feb 2021 03:20:35 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b18sm12104801wrm.57.2021.02.05.03.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:20:34 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Steven Webster , dpdk stable Date: Fri, 5 Feb 2021 11:15:07 +0000 Message-Id: <20210205111920.1272063-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/avp: remove always true condition' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/450415e2733360f8e74e4a46ad4ff0511ce2508d Thanks. Luca Boccassi --- >From 450415e2733360f8e74e4a46ad4ff0511ce2508d Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 19 Nov 2020 11:59:00 +0000 Subject: [PATCH] net/avp: remove always true condition [ upstream commit e6b87501657e681f15b48837fdfcffabc0ed6bef ] There is already a break above for the case "count >= 1", so at this stage 'count' should be always '0'. Fixes: 1a85922369c4 ("net/avp: add device configuration") Signed-off-by: Ferruh Yigit Acked-by: Steven Webster --- drivers/net/avp/avp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 5f8187b905..f531e03c02 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -267,7 +267,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) break; } - if ((count < 1) && (retry == 0)) { + if (retry == 0) { PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n", request->req_id); ret = -ETIME; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:30.259922424 +0000 +++ 0021-net-avp-remove-always-true-condition.patch 2021-02-05 11:18:28.602687228 +0000 @@ -1 +1 @@ -From e6b87501657e681f15b48837fdfcffabc0ed6bef Mon Sep 17 00:00:00 2001 +From 450415e2733360f8e74e4a46ad4ff0511ce2508d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e6b87501657e681f15b48837fdfcffabc0ed6bef ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org