From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81D1AA0524 for ; Fri, 5 Feb 2021 12:36:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B49C188A3B; Fri, 5 Feb 2021 12:36:38 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 98F751889F7 for ; Fri, 5 Feb 2021 12:36:36 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id l12so5765471wmq.2 for ; Fri, 05 Feb 2021 03:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KNuj5auuuCEDQ3JSaU2vjoK8HlC2FuXXaCRa9RuH9wo=; b=SrzU7nooZz4hEvT/0bWUcE9Pq7/Zla6fGCByX1T9uody6C4NWO2ZgbZbg0Zpe4kgTd G5Uy6Sbv1g3FxcshBsHOdPcVDZVifeghnt9uuMhnNI9gDF1FDj9RWYmGWlhboPvbm1xA +r76BRs2oD0pTc356rF08HeDh2SCQNObjNGpwWZpCbRyx1U3iHxLwnGHl94YNarS7EwA fks3kwz7sEi4dw4mmC6z9x4/qBzAPZADpBmWAmViX9np+gN46/q38dyhGnl5U1eLblZU c73+nYzNzU5h4T5tX9nF0EwNX7b8UApwhS35iX+gB2gxs+lXyiS2iVrkeBN1pGYVKqnb Mc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KNuj5auuuCEDQ3JSaU2vjoK8HlC2FuXXaCRa9RuH9wo=; b=Kb3SshwRyUlssRfD214G8qP8sPckAZc1NFLF8iAtWypjdNEmkDw5+yTLgox+qARaJc ydL+RkXSM5d1cgXe+ddCfSaS9SZt80uqI7rkjT6xTnGXlFX1XoyOQL09isDnIU68moNe nnrzRk4Z1vqntYRMnV+n8VOSAmRdZtYcYG8UUNGYoL6StJbpSC5V1K6BOaaE/7gn7EVl yJbqdWi6dR1REskzV4RMoc3ZJWFJhPxUc+T9tLh8g8+spcv4Z0F1EeWZ2Lr8C73rhXHR L0RyLx9fQl02kyJa4h0DHYEnhKsM99ZH4YHx7MJh43Ryif9ya25dVwlpw1r3zzQuUTfL l6Ow== X-Gm-Message-State: AOAM533hpFaP29Dyr7ai4BvgvLoBLoSaqmOdIaEC5eb4FOI42uK9zdnV jR2ef/jX059M5wCGSuCuItA= X-Google-Smtp-Source: ABdhPJwuag+Wy18rn3MLsw9nEALso5e6nbTTx2sRnFaKrLMg9bzpW6hIBT03jgmIQiZPm55+q0+CZg== X-Received: by 2002:a1c:e90d:: with SMTP id q13mr3207653wmc.136.1612524996394; Fri, 05 Feb 2021 03:36:36 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a17sm12541365wrx.63.2021.02.05.03.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:36:35 -0800 (PST) From: luca.boccassi@gmail.com To: Ciara Power Cc: Declan Doherty , Adam Dybkowski , dpdk stable Date: Fri, 5 Feb 2021 11:18:21 +0000 Message-Id: <20210205111920.1272063-215-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/crypto-perf: fix CSV output format' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a756bf42a9043a08985a1644afbdd2179a84d986 Thanks. Luca Boccassi --- >From a756bf42a9043a08985a1644afbdd2179a84d986 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Wed, 20 Jan 2021 17:29:29 +0000 Subject: [PATCH] app/crypto-perf: fix CSV output format [ upstream commit c6ddab873dbf066c40cd268a0216a913b1802b85 ] The csv output for each ptest type used ";" instead of ",". This has now been fixed to use the comma format that is used in the csv headers. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Fixes: da40ebd6d383 ("app/crypto-perf: display results in test runner") Signed-off-by: Ciara Power Acked-by: Declan Doherty Acked-by: Adam Dybkowski --- app/test-crypto-perf/cperf_test_latency.c | 2 +- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +- app/test-crypto-perf/cperf_test_throughput.c | 4 ++-- app/test-crypto-perf/cperf_test_verify.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index c2590a4dcf..159fe8492b 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -314,7 +314,7 @@ cperf_latency_test_runner(void *arg) for (i = 0; i < ctx->options->total_ops; i++) { - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f", + printf("\n%u,%u,%u,%"PRIu64",%"PRIu64",%.3f", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, i + 1, ctx->res[i].tsc_end - ctx->res[i].tsc_start, diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 4e67d3aebd..844659aeca 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -16,7 +16,7 @@ #define PRETTY_HDR_FMT "%12s%12s%12s%12s%12s%12s%12s%12s%12s%12s\n\n" #define PRETTY_LINE_FMT "%12u%12u%12u%12u%12u%12u%12u%12.0f%12.0f%12.0f\n" #define CSV_HDR_FMT "%s,%s,%s,%s,%s,%s,%s,%s,%s,%s\n" -#define CSV_LINE_FMT "%10u;%10u;%u;%u;%u;%u;%u;%.3f;%.3f;%.3f\n" +#define CSV_LINE_FMT "%10u,%10u,%u,%u,%u,%u,%u,%.3f,%.3f,%.3f\n" struct cperf_pmd_cyclecount_ctx { uint8_t dev_id; diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index f30f7d5c2c..f6eb8cf259 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -299,8 +299,8 @@ cperf_throughput_test_runner(void *test_ctx) "Failed Deq,Ops(Millions),Throughput(Gbps)," "Cycles/Buf\n\n"); - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" - "%.3f;%.3f;%.3f\n", + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," + "%.3f,%.3f,%.3f\n", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 833bc9a552..2939aeaa93 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -406,7 +406,7 @@ cperf_verify_test_runner(void *test_ctx) "Burst Size,Enqueued,Dequeued,Failed Enq," "Failed Deq,Failed Ops\n"); - printf("%10u;%10u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" + printf("%10u,%10u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," "%"PRIu64"\n", ctx->lcore_id, ctx->options->max_buffer_size, -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:38.691378325 +0000 +++ 0215-app-crypto-perf-fix-CSV-output-format.patch 2021-02-05 11:18:29.170698042 +0000 @@ -1 +1 @@ -From c6ddab873dbf066c40cd268a0216a913b1802b85 Mon Sep 17 00:00:00 2001 +From a756bf42a9043a08985a1644afbdd2179a84d986 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c6ddab873dbf066c40cd268a0216a913b1802b85 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org