From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0E9FA0524 for ; Fri, 5 Feb 2021 12:38:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B4F44067B; Fri, 5 Feb 2021 12:38:28 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id B67824067B for ; Fri, 5 Feb 2021 12:38:26 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id f16so5742953wmq.5 for ; Fri, 05 Feb 2021 03:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7HmzdZXORoPkeHarXwKo2YF80mCrNWTyPfS0GhV9Ahc=; b=rAk8H+KVtY6iyKKLHhgyBPY/fvJ4BKBS6mli/rlXUz2BCpujClt32O4wzVu8rFswCN MKh99R4slbg6rUd5in9iKv9SKvoCiviz9qdegoq4iIRaSY/jIKEX4rMJoMjS5LobYIt+ vbm1W610ZdQz5llSmIY2laV+b4goEnD8+/HFPq2t5Hs73B4kTOBwfOa/ntZv/lK+cmUN UMst7zpe2nJxw7QMDidepdjqlEtuX+28U7rrAdtSoFp81kBy4bkQGTHopmPP70hvKuAz kT5KJzbEvkdrTw9SO0QjEYfbzZv0+sRJBYgBO8pEHCI40kxTKKRAVzGTWDJ6dl06i9Rc Enjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7HmzdZXORoPkeHarXwKo2YF80mCrNWTyPfS0GhV9Ahc=; b=YtXboEGLZdb+aaejb1mi/+hIGdsAua02+mTn7g/cmArei8WiOMJb0NE7W4WyiuM5qz HsSkTQkMxFwGYiBNJbp/54McBNf7VqyHhvq2fzh4pZcFqVqWpdRUJk4PodDM1w452AvQ FPSE9TpyRSmMU5hnsXiQtavB6KVGpley78bzXC0fowy46UvOVxx3FBAWHW5SVeEqsQz3 FrNfRzxflHSmiacMMsQnFP03mcezw1ACcC4mz54AUIpzxKVAq7PN0yytyBFa/P7fBp0J Z9oQoE0KdQTZYe/BOPyCc+ueglRKsJfy6bGkORaJ8/E9xP0pabdcpt/U68KpjxPZn1Za JPKg== X-Gm-Message-State: AOAM5325FGNP58Z6/rCZzFZl4yoxZsJLG2ore4erCGjNzddPNvi3bbwH SIM2H7dnzSK09k1OkzTGY80= X-Google-Smtp-Source: ABdhPJyUqjyUg5511vGt9AjuFLC49YwdfdXPJPzSq+2qrjpjrJGwH0xivX+/5si4xVLLtFOWX8dYkw== X-Received: by 2002:a1c:c904:: with SMTP id f4mr3327482wmb.14.1612525106463; Fri, 05 Feb 2021 03:38:26 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id k15sm8523518wmj.6.2021.02.05.03.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:38:25 -0800 (PST) From: luca.boccassi@gmail.com To: Dapeng Yu Cc: Jeff Guo , dpdk stable Date: Fri, 5 Feb 2021 11:18:52 +0000 Message-Id: <20210205111920.1272063-246-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: disable NFS filtering' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3c7c83869ddb3d9d2d8df8de194dad339ed7eeaf Thanks. Luca Boccassi --- >From 3c7c83869ddb3d9d2d8df8de194dad339ed7eeaf Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Tue, 26 Jan 2021 11:03:08 +0800 Subject: [PATCH] net/ixgbe: disable NFS filtering [ upstream commit 68643843e79d2df54e8a6c148a29fd314a5e7897 ] Disable NFS header filtering whether NFS packets coalescing are required or not, in order to make RSS can work on NFS packets. The code without the patch does follow datasheet, but not consistent with the ixgbe kernel driver. It causes NFS packets to be filtered and make them flow into queue 0, before RSS can work on them. Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is disabled") Fixes: 8eecb3295aed ("ixgbe: add LRO support") Signed-off-by: Dapeng Yu Acked-by: Jeff Guo --- drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 7bb8460359..f1fc307ffd 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -4898,15 +4898,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) /* RFCTL configuration */ rfctl = IXGBE_READ_REG(hw, IXGBE_RFCTL); if ((rsc_capable) && (rx_conf->offloads & DEV_RX_OFFLOAD_TCP_LRO)) - /* - * Since NFS packets coalescing is not supported - clear - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is - * enabled. - */ - rfctl &= ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS | - IXGBE_RFCTL_NFSR_DIS); + rfctl &= ~IXGBE_RFCTL_RSC_DIS; else rfctl |= IXGBE_RFCTL_RSC_DIS; + /* disable NFS filtering */ + rfctl |= IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS; IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl); /* If LRO hasn't been requested - we are done here. */ -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:40.014628787 +0000 +++ 0246-net-ixgbe-disable-NFS-filtering.patch 2021-02-05 11:18:29.258699718 +0000 @@ -1 +1 @@ -From 68643843e79d2df54e8a6c148a29fd314a5e7897 Mon Sep 17 00:00:00 2001 +From 3c7c83869ddb3d9d2d8df8de194dad339ed7eeaf Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68643843e79d2df54e8a6c148a29fd314a5e7897 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 36e6ca9010..72d27f35ca 100644 +index 7bb8460359..f1fc307ffd 100644 @@ -27 +28 @@ -@@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) +@@ -4898,15 +4898,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)