From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62920A0524 for ; Fri, 5 Feb 2021 12:21:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A7831606C7; Fri, 5 Feb 2021 12:21:45 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id A3B474067B for ; Fri, 5 Feb 2021 12:21:44 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id f16so5704236wmq.5 for ; Fri, 05 Feb 2021 03:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hzPdLxlSY9ZZgWtjHNJhQOxYvbYMn58tCzZkPyQxu70=; b=XhXYeCnZN0/bWmSZkoC96f0hWOyHhtInZBEJ+06S3330wMwY+K939EP1uE0BEDZ56w 8ObG0k10b2hIeoBD4BNeMWiBevDKyK9TQJHnegb2e384Sgczah9uGPZhO/TUUrsmj5Wu +8q5mqqDz/xHmjTa2KJjdTRKpMotSwqskQmO3qhHfzBDN9OUtj8JomrFtDftKOeYyn2L ruSQLfj42FdztS2GWTPTi0Psj7AoI7HTv38/Tcsr4E+htID9OOwD0rKnRnUrMifbIaLG 4y89KuYYdoVf5SSepBHqw7if/HryfG9DlsR87GGkDGAfUW3JPVfDLM+cDMvPc67wWN0g AoxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hzPdLxlSY9ZZgWtjHNJhQOxYvbYMn58tCzZkPyQxu70=; b=EXmFz2JebmlBcDBMrQ9Qwp0OEfxCzAZaUH1M3dNLtLo388zcZgjtakw1+/RBWy4S25 RCqkUZXJ5ete5SKecXCm5tUZBu3hBx9yuamy7FVwfkVI/ErZPgQnZQ6BenLOwOyomEIa Ps4mR45RkTKIeVEMY3hi1H1EywERcwywm8HGYvzE+Cv73fBtptx5CzvTCp11jnetltSk 63EzdYpeGhk+wqx54PwrwhdYLO8/dQTSjef727bzP19OoOpGfnH9EmWQhiQm8TjyWhi1 U5EmFrHIwEqlOhiwhg5F6LVnJHBoZSYKr7kyFZJdNI08MJNsT/LGX9ZRyIu1OFPYVOVk 4UwA== X-Gm-Message-State: AOAM531gNx5rH39+A155lhrlvo0puRJVUuEzHVfgcsQADZJVyba41izK hS62SLdSWZMMvzlC0zn26g0= X-Google-Smtp-Source: ABdhPJxiv7a8UzBovMwxlAlGxgj30O4+UNbm773WeBQGWpdnr2l4+/CGxY25Y5p5YNOY3kjv7T1ALg== X-Received: by 2002:a1c:7e0c:: with SMTP id z12mr3240188wmc.85.1612524104401; Fri, 05 Feb 2021 03:21:44 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 62sm8831359wmd.34.2021.02.05.03.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:21:43 -0800 (PST) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Fri, 5 Feb 2021 11:15:28 +0000 Message-Id: <20210205111920.1272063-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: propagate FW command failure to application' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b2a1b765ac391e90dbcf2bdbb6173032708572de Thanks. Luca Boccassi --- >From b2a1b765ac391e90dbcf2bdbb6173032708572de Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 12 Nov 2020 16:17:54 +0530 Subject: [PATCH] net/bnxt: propagate FW command failure to application [ upstream commit 4297cadef3a6eb42c32c12a1b3926316ee0e0f9a ] In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index c363c8427a..c62320a4b1 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, } } - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev, @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len); rss_config: - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev, -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:31.174941146 +0000 +++ 0042-net-bnxt-propagate-FW-command-failure-to-application.patch 2021-02-05 11:18:28.710689284 +0000 @@ -1 +1 @@ -From 4297cadef3a6eb42c32c12a1b3926316ee0e0f9a Mon Sep 17 00:00:00 2001 +From b2a1b765ac391e90dbcf2bdbb6173032708572de Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4297cadef3a6eb42c32c12a1b3926316ee0e0f9a ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 8047b0b5d7..33358779bb 100644 +index c363c8427a..c62320a4b1 100644