* [dpdk-stable] [PATCH] net/mlx5: fix metadata item validation for ingress flows
@ 2021-02-10 9:30 Viacheslav Ovsiienko
2021-02-21 15:36 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2021-02-10 9:30 UTC (permalink / raw)
To: dev; +Cc: rasland, matan, stable
In legacy metadata mode the metadata register B is engaged to
handle the metadata item. In the ingress domain the hardware
supports the register setting only, the match on register B
is not supported.
Due to this limitation only the SET_META action can be supported
for the ingress flows, the META item should be rejected on
flow validation.
Fixes: 5f3541724e0 ("net/mlx5: fix flow META item validation")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 76696b7b62..131d5de586 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1960,13 +1960,20 @@ flow_dv_validate_item_meta(struct rte_eth_dev *dev __rte_unused,
"isn't supported");
if (reg != REG_A)
nic_mask.data = priv->sh->dv_meta_mask;
- } else if (attr->transfer) {
- return rte_flow_error_set(error, ENOTSUP,
+ } else {
+ if (attr->transfer)
+ return rte_flow_error_set(error, ENOTSUP,
RTE_FLOW_ERROR_TYPE_ITEM, item,
"extended metadata feature "
"should be enabled when "
"meta item is requested "
"with e-switch mode ");
+ if (attr->ingress)
+ return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM, item,
+ "match on metadata for ingress "
+ "is not supported in legacy "
+ "metadata mode");
}
if (!mask)
mask = &rte_flow_item_meta_mask;
--
2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix metadata item validation for ingress flows
2021-02-10 9:30 [dpdk-stable] [PATCH] net/mlx5: fix metadata item validation for ingress flows Viacheslav Ovsiienko
@ 2021-02-21 15:36 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2021-02-21 15:36 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Matan Azrad, stable
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, February 10, 2021 11:31 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix metadata item validation for ingress flows
>
> In legacy metadata mode the metadata register B is engaged to
> handle the metadata item. In the ingress domain the hardware
> supports the register setting only, the match on register B
> is not supported.
>
> Due to this limitation only the SET_META action can be supported
> for the ingress flows, the META item should be rejected on
> flow validation.
>
> Fixes: 5f3541724e0 ("net/mlx5: fix flow META item validation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-21 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 9:30 [dpdk-stable] [PATCH] net/mlx5: fix metadata item validation for ingress flows Viacheslav Ovsiienko
2021-02-21 15:36 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).