From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4160A054A for ; Fri, 19 Feb 2021 11:01:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 887701608BB; Fri, 19 Feb 2021 11:01:31 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D2B4740042; Fri, 19 Feb 2021 11:01:28 +0100 (CET) IronPort-SDR: uUHcNNtE2T7i7FjWOqrS+yzJhxy3jeZrMEKeXtfZD0Y7ThZeg9YqaqiwisSg6VrimQvN+38jwX eVF7uc5/7QbA== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="245244249" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="245244249" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 02:01:27 -0800 IronPort-SDR: FeWwHsW8eFL0jQMBjGzhHkEuW1jhHnuwuJgKGx5JQpfC9AgqP49wkdgb+Sfa+4anjldAt3lGji rXzuo1j1AM7A== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="400945572" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 02:01:24 -0800 From: dapengx.yu@intel.com To: jia.guo@intel.com, haiyue.wang@intel.com Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Fri, 19 Feb 2021 18:01:07 +0800 Message-Id: <20210219100107.101938-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <220210219085407.97265-1-dapengx.yu@intel.com> References: <220210219085407.97265-1-dapengx.yu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH v2] net/igc: remove MTU setting limitation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Dapeng Yu Currently, if requested MTU is bigger than mbuf size and scattered receive is not enabled, setting MTU to that value fails. This patch allows setting this special MTU when device is stopped, because scattered_rx will be re-configured during next port start and driver may enable scattered receive according new MTU value. After this patch, driver may select different receive function automatically after MTU set, according MTU values selected. Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/igc/igc_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index dbaa7a83e..0ea6e2a04 100644 --- a/drivers/net/igc/igc_ethdev.c +++ b/drivers/net/igc/igc_ethdev.c @@ -1590,12 +1590,14 @@ eth_igc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) return -EINVAL; /* - * refuse mtu that requires the support of scattered packets when - * this feature has not been enabled before. + * If device is started, refuse mtu that requires the support of + * scattered packets when this feature has not been enabled before. */ - if (!dev->data->scattered_rx && - frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) + if (dev->data->dev_started && !dev->data->scattered_rx && + frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) { + PMD_INIT_LOG(ERR, "Stop port first."); return -EINVAL; + } rctl = IGC_READ_REG(hw, IGC_RCTL); -- 2.27.0