From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8C410A0562
for <public@inbox.dpdk.org>; Fri, 19 Mar 2021 15:57:53 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6A24C140EB3;
Fri, 19 Mar 2021 15:57:50 +0100 (CET)
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
[66.111.4.224])
by mails.dpdk.org (Postfix) with ESMTP id 38BC3140EEE;
Fri, 19 Mar 2021 15:57:47 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailnew.nyi.internal (Postfix) with ESMTP id 93D77580AE9;
Fri, 19 Mar 2021 10:57:46 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Fri, 19 Mar 2021 10:57:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=fm3; bh=aXpO3KZ8l6wjQ
Kb5qRd292XIdaYkzE94txF2iB+0xu0=; b=bY3sbgXqxn0BaXi3JK5Rt+0HrEyyJ
A1wg4mUi4NivbPZHDJkNdEMMPNytnfErbD5TbOiR6Ff+0ijcE3H+FYB3+c1hZ+St
VMHlY/OK7WsM+Hzz8YPEPHd0FmeviFPEjPljFtvNwcomwW3mFbnupcq/1xyS+O2Z
FVUc7tj8iqsafoQDOUQ9q2Zro7FeCGoRwJ565wqjqBcvHYxPmlcMZBV33F7KW2P9
r7FwQuA/QFHlgzh915EFLzKsE7nDC5Z/ZisKT9vPY1bWDv/hugvJfJsJ0HSM0c30
JGzcDycftNNPitBrt2XnKefkWz4ZAbBkTh7y+pf+r44Zv6pcExgJV9Jvw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm2; bh=aXpO3KZ8l6wjQKb5qRd292XIdaYkzE94txF2iB+0xu0=; b=PBzK5oHw
+XwreEnTyfYi/Lgo2DVH+jSWWKmfXIxCsdKxxBU9RD8RU8yfM3h8bpNOK1aVBzfv
FQlL4zIKREYe2YzSVUo02OzF6cNVCuZecodZKnYB9wiC2R8N7Zi+l+LCBxkTUp9J
hBXRViZ5pCNr75XAxYtyKBQHnmaJObe6DmTfGyCILYsOdUZJLFZTOJHusnAh64LN
9BRce2PjL1uLzctU+8cCLC6teIq5aAREJRiHk3kwh/BiOCohPP8woqDl8FOwgjkh
BH/mX2n2XPmbKwJ8nSlL3flvTd8Dmr0ck/Y2XeS/PnxHek5yu1mmQ55fGcZAEk9m
jyIjuDVS2Tuzbg==
X-ME-Sender: <xms:6btUYIvBWZPwu-YeIpL9w2CwScGmB7dh2ikn0DYLn0m8xeHssQpCzg>
<xme:6btUYFdmNJ-ejte5ZvnpTeVw33oQBRUT9yX6gWJprKtfACs00O_A6p3wLM-dvZzuR
kIQ96JV-pNAlQ-3Yw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefkedgjeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg
uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:6rtUYDwV1p6JRVousjrcTPLVV-jhbzk22RLO-Y7j6djmcu2lEUZA8Q>
<xmx:6rtUYLNebtg2L8e7xY0qGfrFn1KK6h4mFKgjoR3wZ9zpjK_TwXSQeg>
<xmx:6rtUYI_oWhPVqJOrGtakpKgnDrwP-4Z36lbOYSCxaurfxxsgA9r_NQ>
<xmx:6rtUYCd1nUJcjuIc2J8DHQ2j6af0ianB5cJ-xyy7I4N6A2BlDlr1Vg>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 65CDE24005A;
Fri, 19 Mar 2021 10:57:44 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: ncopa@alpinelinux.org, stable@dpdk.org,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
David Marchand <david.marchand@redhat.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Marcin Smoczynski <marcinx.smoczynski@intel.com>,
Xiaoyu Min <jackmin@mellanox.com>, Xueming Li <xuemingl@mellanox.com>
Date: Fri, 19 Mar 2021 15:57:17 +0100
Message-Id: <20210319145730.3555384-5-thomas@monjalon.net>
X-Mailer: git-send-email 2.30.1
In-Reply-To: <20210319145730.3555384-1-thomas@monjalon.net>
References: <20190313170657.16688-1-ncopa@alpinelinux.org>
<20210319145730.3555384-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH v7 04/17] build: remove redundant _GNU_SOURCE
definitions
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
The feature macro _GNU_SOURCE is defined globally,
but there was some remaining useless settings.
The internal definition in config/meson.build is kept,
all other internal definitions of _GNU_SOURCE are removed,
except in examples, which can be built as external applications.
Note: external applications do not inherit of _GNU_SOURCE.
Fixes: 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default")
Fixes: 28188cee2aa0 ("build: enable BSD features visibility for FreeBSD")
Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: David Marchand <david.marchand@redhat.com>
---
app/test/meson.build | 2 --
drivers/bus/fslmc/qbman/include/compat.h | 3 ---
drivers/common/dpaax/compat.h | 4 ----
drivers/common/dpaax/meson.build | 1 -
drivers/net/memif/rte_eth_memif.h | 4 ----
drivers/net/mlx5/linux/mlx5_socket.c | 4 ----
6 files changed, 18 deletions(-)
diff --git a/app/test/meson.build b/app/test/meson.build
index 099895fc87..76eaaea457 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -398,8 +398,6 @@ if cc.has_argument('-Wno-format-truncation')
cflags += '-Wno-format-truncation'
endif
-# specify -D_GNU_SOURCE unconditionally
-cflags += '-D_GNU_SOURCE'
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
cflags += '-fno-strict-aliasing'
diff --git a/drivers/bus/fslmc/qbman/include/compat.h b/drivers/bus/fslmc/qbman/include/compat.h
index 1ddd69e127..a4471a80af 100644
--- a/drivers/bus/fslmc/qbman/include/compat.h
+++ b/drivers/bus/fslmc/qbman/include/compat.h
@@ -8,9 +8,6 @@
#ifndef HEADER_COMPAT_H
#define HEADER_COMPAT_H
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h
index 1a5f36e99e..c69e76ab96 100644
--- a/drivers/common/dpaax/compat.h
+++ b/drivers/common/dpaax/compat.h
@@ -10,10 +10,6 @@
#define __COMPAT_H
#include <sched.h>
-
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
#include <stdint.h>
#include <stdlib.h>
#include <stddef.h>
diff --git a/drivers/common/dpaax/meson.build b/drivers/common/dpaax/meson.build
index 4535482701..b7f177a62e 100644
--- a/drivers/common/dpaax/meson.build
+++ b/drivers/common/dpaax/meson.build
@@ -10,7 +10,6 @@ sources = files('dpaax_iova_table.c', 'dpaa_of.c', 'caamflib.c')
includes += include_directories('caamflib')
-cflags += ['-D_GNU_SOURCE']
if cc.has_argument('-Wno-cast-qual')
cflags += '-Wno-cast-qual'
endif
diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h
index 24321d3a39..2038bda742 100644
--- a/drivers/net/memif/rte_eth_memif.h
+++ b/drivers/net/memif/rte_eth_memif.h
@@ -5,10 +5,6 @@
#ifndef _RTE_ETH_MEMIF_H_
#define _RTE_ETH_MEMIF_H_
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif /* GNU_SOURCE */
-
#include <sys/queue.h>
#include <ethdev_driver.h>
diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c
index 1938453980..b1f41bc102 100644
--- a/drivers/net/mlx5/linux/mlx5_socket.c
+++ b/drivers/net/mlx5/linux/mlx5_socket.c
@@ -2,10 +2,6 @@
* Copyright 2019 Mellanox Technologies, Ltd
*/
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>
--
2.30.1