From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0573A0A0A for ; Tue, 6 Apr 2021 04:55:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB60F140EEA; Tue, 6 Apr 2021 04:55:59 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by mails.dpdk.org (Postfix) with ESMTP id 102F34068B; Tue, 6 Apr 2021 04:55:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IxkBXzCwGDj2/dLxlnlC34nIriP0a1G+UXYfRdwG8vE=; b=06v7XCG5TivdpsTRbZpsid/gE3Wn7tR+aLlGyqGggg4BfYipIBnFSJEHQmrqmF2+cyU13BYmruZX8g1k/U5QkresdeqMteaXk+MrPst26Dnq5uHN5we7LKzem3FBv4gKL6eIr3ffWci+rj7anP+w033303YLgWwKPrp0g1wiEB0= Received: from DB3PR06CA0015.eurprd06.prod.outlook.com (2603:10a6:8:1::28) by DB7PR08MB3196.eurprd08.prod.outlook.com (2603:10a6:5:26::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Tue, 6 Apr 2021 02:55:54 +0000 Received: from DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::83) by DB3PR06CA0015.outlook.office365.com (2603:10a6:8:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27 via Frontend Transport; Tue, 6 Apr 2021 02:55:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT017.mail.protection.outlook.com (10.152.20.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29 via Frontend Transport; Tue, 6 Apr 2021 02:55:54 +0000 Received: ("Tessian outbound 34291f7cb530:v90"); Tue, 06 Apr 2021 02:55:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 32840d6e07daaf1d X-CR-MTA-TID: 64aa7808 Received: from e12fc952ace0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B477826-6E4B-4B4D-BD1B-451DA5E3FD6C.1; Tue, 06 Apr 2021 02:55:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e12fc952ace0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Apr 2021 02:55:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzA5D1M75hKVAobJFGomlRiUIqj8+1grYVb37abVv6ct2xbIorTdr/HXPJ9a3Fnv/uDrrQces7BTKSEKla7Ap+xWVfc+lIepz7CyM8k+tptyQ5wCQSuf3HVpEaWAqlv1tJiq4Nu7SNvQgRCkmVl20QLf2sReDMwqM4CSOIM8sVuRmnJnTsPBZQL1CoLWb8vxUpgUMGgXv5+rjaMDDYZeUHYjzaBtvxqBGFG0w4Zki0p96hykx0dYaCi2LUQm2UDcV6l8ydtCpvt3T4L3ybeLuqzJys4LhRaVyNks+wfA6BgrNgEI8Auq53t+x694nQgvobuWJE5dzQHWL1uzeH6D6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IxkBXzCwGDj2/dLxlnlC34nIriP0a1G+UXYfRdwG8vE=; b=fK9yhl2bGi7R8HAE5xxWVsH2qFijyA9kpAMiQjR1o6ayzk0hV99aQ+tKLl4ZSp6lEH61FmLPyU2TTPl3whSxPiBJzemevRwyoCEkqxIuPWMkYTktvvINMbEJwFeRChSoKUgN1Wb1eUbBZTOgReT11LGw22VkB+sjQ4W9nDN2+8RCa8VRAwEfauuCjBff97zJYXaCEiztX2I+EebXzDfRWhC1eIb8RDEFmtYwmyWXqSsGyP1kN/cvxPT0d3Dxx81Ts3hlPjyZ5Q79LJTidCMtESiPr54f80Lu1b3hbP/uGswlcJg9Z7v8McXWaEsbF0EFwCZI6Fc4SjfY3lt6+2xnGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IxkBXzCwGDj2/dLxlnlC34nIriP0a1G+UXYfRdwG8vE=; b=06v7XCG5TivdpsTRbZpsid/gE3Wn7tR+aLlGyqGggg4BfYipIBnFSJEHQmrqmF2+cyU13BYmruZX8g1k/U5QkresdeqMteaXk+MrPst26Dnq5uHN5we7LKzem3FBv4gKL6eIr3ffWci+rj7anP+w033303YLgWwKPrp0g1wiEB0= Received: from AM6P194CA0077.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::18) by HE1PR08MB2924.eurprd08.prod.outlook.com (2603:10a6:7:33::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Tue, 6 Apr 2021 02:55:45 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::48) by AM6P194CA0077.outlook.office365.com (2603:10a6:209:8f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.26 via Frontend Transport; Tue, 6 Apr 2021 02:55:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3999.29 via Frontend Transport; Tue, 6 Apr 2021 02:55:44 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 6 Apr 2021 02:55:43 +0000 Received: from wls-arm-cavium06.shanghai.arm.com (10.169.206.120) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 6 Apr 2021 02:55:41 +0000 From: Richael Zhuang To: CC: , , David Hunt , Pablo de Lara Date: Tue, 6 Apr 2021 10:55:31 +0800 Message-ID: <20210406025532.34868-1-richael.zhuang@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7bea43c8-396d-4aa5-5251-08d8f8a77eb2 X-MS-TrafficTypeDiagnostic: HE1PR08MB2924:|DB7PR08MB3196: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OGxsTzhJ7Bq54FzSBlMmuErDPatO4rpuokpQ+pG3ZrVJ9dRDdLBod4XScWCEppOJ+Dnu8VhwlgVvGyMeTEa5bCjTZoKOYOZ02Tco8zGTDzxeHoFUfkFarbkTOSdSJiS+k9YJqRSXIqQVV5vG4MDHwTzQXpJgg/uW7ryMgHCdzqOblGLbMQGhby6oj8Xg6Bphh4HKxZHaJtyBKkmmgR3m/iJgPl5P/ylpaHT6703MdCTEngWfjZ6PAM9iU8KGttEqrZPJf7QPHJW34hyOPCFtpgrQvu0NRpz1IDHJtQzKr4MW9fdENXiK3+dipPWSt/YM+7ewTvhPqfJRbjcKTFXvxjLuTFEw/ZOcW7E/tSOF1nuqYSvMChbUAKJUvOI/PhbZGrzUpY2sDzWi6BMho15hG+LAbN+iyK9f3wXpGcbiweELMcShHmjuHS1/REHGEQ/7mRC+70BYapgWw6ZY+lznzlbijpmnvNuJP3/vDAefj5RMVQt2TNPn8dvdeGPQZfIGe4D7vQPno/6LzSbaavUoiGxkIfCZFpRJlUrkyQpqWve6Od3EG+FAhdOONlrQiBLeUPQCKKqera8C5yGOeqjhCJCD5q7w1c8FTWAY2QJWJGmhmJLfuxjmXChiQvktWUKS/UhQksVNNJiqDAoW9/gvpnZghqPdV8n6QyNRPcNWGxH8SODfngg5vo3VWdpf5g5s X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(376002)(136003)(39850400004)(396003)(346002)(46966006)(36840700001)(70586007)(4326008)(83380400001)(2906002)(356005)(82740400003)(81166007)(82310400003)(86362001)(6666004)(36860700001)(478600001)(47076005)(8676002)(8936002)(7696005)(70206006)(2616005)(44832011)(6916009)(1076003)(426003)(186003)(336012)(5660300002)(316002)(26005)(36756003)(54906003)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2924 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d6fc32f2-de3b-4820-4a7e-08d8f8a77925 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YaBD8fKfoXGq3x6eh9sARo0+r7p9Cm7wU9E/HTbdzowX8x7SEeb8YKJvcBqqiPXZ5XmiFMY0oxulcb/Y1AbMSj+btZlUwmK+Zu4nPWpsEIeNx1+liruiIXmKmnqsmFGM1ayeEwn+gjnk/nP73cHsiUDJ4+cfrYw/nyl94E5WtxwdarFPHBHZsHw7I3bpLUKcAEzLO5Nt3QV3k8DZbFOOiYIGrRwD5A1IYnEqEyvHFLi3L4dWect2/j3SzAN8ip7ZtprbFU0D2CzXURV6BYv9tMXlXLLA9dM7x7gV2DRHpl+7aKL/ib0jJ4VFRvcT3U8Ul8K4f7Yb9fpJ7HwKV56pjHQKNd0X5KpU3NuwbkehcrQ6O2OOttI9hxKVkIGaFeHh29iwMMzn+gvkSWWtZcBo7OT49wBAIZGxs/nIPWOsXeKxQ0t5xqOPS/4D49LlfV+dLpSII31azq73cwkD7gvYacfWI58bo+yOtM6vVHFbP256R+K+2bhYo5F3jkDPAkXohnSu0OBE6AMujcTlkrER47XjESTqBFCUB1JI6hlCmlQddvnDV79HHBYToKfIjN2r5JhE9j92wnAXc70UCVnFM30xA0F05MjRJ9YYMC1xwwLUEKz9RCNILijMo+fDUHFmbp7UoEQHUHXQeY0+tRCKSg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(39850400004)(136003)(376002)(36840700001)(46966006)(82740400003)(86362001)(450100002)(426003)(6666004)(4326008)(36756003)(336012)(2616005)(186003)(5660300002)(44832011)(478600001)(36860700001)(47076005)(26005)(83380400001)(2906002)(316002)(107886003)(7696005)(8936002)(54906003)(6916009)(1076003)(82310400003)(8676002)(70206006)(81166007)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 02:55:54.1677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7bea43c8-396d-4aa5-5251-08d8f8a77eb2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3196 Subject: [dpdk-stable] [PATCH] test/power: fix several bugs in cpufreq autotest X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "2400000" to "/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to round the value. Fixes: ed7c51a6a680 ("app/test: vm power management") Cc: alan.carew@intel.com Cc: stable@dpdk.org Change-Id: I3b0266415a2b655d58294a3f51a6051bc1e5fc7f CustomizedGitHooks: yes Jira: ENTWLS-2032 Signed-off-by: Richael Zhuang --- app/test/test_power_cpufreq.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index 731c6b4dc..c4f4541ac 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -34,6 +34,10 @@ test_power_caps(void) #define TEST_POWER_LCORE_INVALID ((unsigned)RTE_MAX_LCORE) #define TEST_POWER_FREQS_NUM_MAX ((unsigned)RTE_MAX_LCORE_FREQS) +/* macros used for rounding frequency to nearest 100000 */ +#define TEST_FREQ_ROUNDING_DELTA 50000 +#define TEST_ROUND_FREQ_TO_N_100000 100000 + #define TEST_POWER_SYSFILE_CUR_FREQ \ "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq" @@ -43,6 +47,9 @@ static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX]; static int check_cur_freq(unsigned lcore_id, uint32_t idx) { + /* wait for the value to be updated */ + sleep(1); + #define TEST_POWER_CONVERT_TO_DECIMAL 10 FILE *f; char fullpath[PATH_MAX]; @@ -62,7 +69,17 @@ check_cur_freq(unsigned lcore_id, uint32_t idx) goto fail_get_cur_freq; } cur_freq =3D strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL); - ret =3D (freqs[idx] =3D=3D cur_freq ? 0 : -1); + + /* convert the frequency to nearest 100000 value + * Ex: if cur_freq=3D1396789 then freq_conv=3D1400000 + * Ex: if cur_freq=3D800030 then freq_conv=3D800000 + */ + unsigned int freq_conv =3D 0; + freq_conv =3D (cur_freq + TEST_FREQ_ROUNDING_DELTA) + / TEST_ROUND_FREQ_TO_N_100000; + freq_conv =3D freq_conv * TEST_ROUND_FREQ_TO_N_100000; + + ret =3D (freqs[idx] =3D=3D freq_conv ? 0 : -1); fail_get_cur_freq: fclose(f); -- 2.20.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.