From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] eal: fix memory mapping for 32-bit targets
Date: Fri, 7 May 2021 23:51:46 +0300 [thread overview]
Message-ID: <20210507235146.133c3706@sovereign> (raw)
In-Reply-To: <20210507190657.84927-1-lance.richardson@broadcom.com>
2021-05-07 15:06 (UTC-0400), Lance Richardson:
[...]
> diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> index ec7156df96..41a94a7511 100644
> --- a/lib/eal/unix/eal_unix_memory.c
> +++ b/lib/eal/unix/eal_unix_memory.c
> @@ -24,14 +24,14 @@
>
> static void *
> mem_map(void *requested_addr, size_t size, int prot, int flags,
> - int fd, size_t offset)
> + int fd, uint64_t offset)
> {
> void *virt = mmap(requested_addr, size, prot, flags, fd, offset);
> if (virt == MAP_FAILED) {
> RTE_LOG(DEBUG, EAL,
> - "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%zx): %s\n",
> - requested_addr, size, prot, flags, fd, offset,
> - strerror(errno));
> + "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%llx): %s\n",
> + requested_addr, size, prot, flags, fd,
> + (unsigned long long)offset, strerror(errno));
Why not PRIx64?
next prev parent reply other threads:[~2021-05-07 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:10 [dpdk-stable] [PATCH] " Lance Richardson
2021-05-07 18:50 ` Lance Richardson
2021-05-07 18:55 ` Lance Richardson
2021-05-07 19:06 ` [dpdk-stable] [PATCH v2] " Lance Richardson
2021-05-07 20:51 ` Dmitry Kozlyuk [this message]
2021-05-07 21:35 ` Lance Richardson
2021-05-08 14:12 ` [dpdk-stable] [PATCH] " Lance Richardson
2021-05-08 14:27 ` [dpdk-stable] [PATCH v3] " Lance Richardson
2021-05-10 12:42 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-05-10 15:31 ` Burakov, Anatoly
2021-05-10 15:55 ` Thomas Monjalon
2021-05-10 16:04 ` Lance Richardson
2021-05-11 7:55 ` Thomas Monjalon
2021-05-11 20:45 ` Thomas Monjalon
2021-05-11 8:17 ` Thomas Monjalon
2021-05-11 13:33 ` Lance Richardson
2021-05-11 14:45 ` [dpdk-stable] [PATCH v4] " Lance Richardson
2021-05-11 15:56 ` Lance Richardson
2021-05-11 16:08 ` Dmitry Kozlyuk
2021-05-11 20:45 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507235146.133c3706@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=lance.richardson@broadcom.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).