From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98A50A0A0E for ; Mon, 10 May 2021 18:19:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B29740140; Mon, 10 May 2021 18:19:03 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2062.outbound.protection.outlook.com [40.107.101.62]) by mails.dpdk.org (Postfix) with ESMTP id 3EEA740140 for ; Mon, 10 May 2021 18:19:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/5AzsbMmoYy0tHZHe77kWOzFx+SmoFeYFGKCfZ+RcZmxuN4ifjW8wTT7j+nSk6kYtY3nEbOfvH1bCA8ty716Q8dgPXXNQwL/i1JhpsT9+qm9s3T6F+XNU858e2JvD9rImUnbr6Bvydn6Dgt0ciyaKjohTY0qm/zsyWJIFroOtFybTsr7zBX+I+Be0A6AzpgHb+x6ZeE907FY/I9uo5bAHJrKIPvITqTK9N+g3aVa0+eLpYrxVav6Wp3HtXnU9Z4kGXAe3PnBU8gErolApvUiDVbTcvD6AUU03GcayrPPorUAzz3Kvc70BTkiHakaVyb/s1zBZedHleF9o/Qjy+VwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wub7YqBluTAzk6H6/L4GenyxwPu3nFBt9rhkai1xEU=; b=iB1HYhTlKj46+leF2a/6JBq6w4GbsfPfXFPv//Bx8geG75mpLpF8SpA6zo1Lxs2yhjQw5CKa9iJIKDZh0ZgDHV+Q2eWz6tlUCN5lkwh+nsR2ICvVwh6YtWKreIgklayNyS7TMDjxEKGtSRXcjlbtpRSc7ugGXnBxtcJiF3r184TyWtz4b1Ms9vXSr8Dhq1CFhzNH10XTfIionsi84h8AhvU2EcwmvBqcyhcaztFDrWc3maNcd29CS/YVY/C9QCzHmbYA6Fv3OxQV142CXuiYdQnsPQJlY4wMOpLjw+KEOW8dBTjEdowrDjgFiNXHH/6AIIFzgTiIA/Fk9wQWqjsDTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wub7YqBluTAzk6H6/L4GenyxwPu3nFBt9rhkai1xEU=; b=YiWz+tWPwbyYktsolRh42ONrth+kA3SPj3kBYGVkfGu1V1Ed4+BUTvWEmxhyUmmldGFt4oQVT1lua4vW5llqhKem74+F95wwsn/20QkhJbKSmtKuk1gZyQtaoXYPcIIOCeFK6oEvVU9UOLoCYrUsoUzA+h8IPgTsGQhOjBk6xiNLf/PHPYdSdIFQEHTeSnX03JvKB3Tpqr4JNj2G7FpoPD92MgVmbB4SrlDEzvqGBZ3P7elgVhS6BqEVyd+/66si0MjD5cFMAcbWOvnkpghuG1gq+EQ5n6Xaw6qDbTOLewxRsDZ0CqfrBQxxM7JO6oZtaOTzT1oLXC3crfQkntNUdg== Received: from DM6PR08CA0002.namprd08.prod.outlook.com (2603:10b6:5:80::15) by DM6PR12MB3769.namprd12.prod.outlook.com (2603:10b6:5:14a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 16:19:00 +0000 Received: from DM6NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:5:80:cafe::9b) by DM6PR08CA0002.outlook.office365.com (2603:10b6:5:80::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Mon, 10 May 2021 16:19:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT067.mail.protection.outlook.com (10.13.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:18:58 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:18:56 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Min Hu , dpdk stable Date: Tue, 11 May 2021 00:01:48 +0800 Message-ID: <20210510160258.30982-159-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68d1d7a0-1ba5-4fd1-91c5-08d913cf512a X-MS-TrafficTypeDiagnostic: DM6PR12MB3769: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lAb1RuEr4Ez5L06OGwE6sT9vdN6wGGLlD9sO4e5hFJ7pqOw/1xeC/5x77Yzgqa1QBJ5rR8uAhXvqFywYBFJ3nUrHeiEWPBoapoCwc4/Xg0K1RcVFU6VJ5BKjFVUA6/tNAZ9j1mpbMG67ElD+Ed351wwXgqd7aC7NBuQmxtpxQV2EtuQIo9DuyBL9X2Lbm/o4lF+nrElvctWhD+Y2oOAB60sctpyhuxAVQhnEQe1wdL5Cyd9bHwMow5Bq/upfJqCGebYm5EssCcqgzfJyRKrMTRF6VMvWSc5KornaEAGrhuhJzV1s7d50rk4kFK6n/EGZHZUU5ufa8xeSK12+yQxH+c9RGElY0ncQjXFSVxbgJ0NwsR0AcTlZjHE5O6lYV0SELk/mlmq6/2RQn35igNnQezdRch7NGsc/t4ocQdYK1IqwFJIDUzKzlspEVrPK1pih4SonFVeREOtN8r+Gw8C06i6C4IFk8bN8lW9QIFiMSFBtA9+SrjzAN3zUdsintwDPwHcb8+uhZASoMl4mqlW5a87ZDaYKzTlNeo3ibQ9P9JDme9ZGUGOb6sY1mehbtB/lLOuEyEaGiD7uYg57O6aF42blsLIdMGUPZYJhd6+k+KyISksGe3l6quUldr5VeaAjbJFwQpgCNcazhl/9NPp7Tr3K7LOADREClJhz+Yh2LNElk/vAWlsKvVFzX7pTUCUq4mCci6ve6F1WitLR7awlqAqB7WR9nQng3WbCMbzFAYDRouX5etBF78J3i1Zxfuaf2tG/duuKao9XguJiX8L7xg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8936002)(4326008)(426003)(186003)(1076003)(16526019)(54906003)(6916009)(36906005)(2616005)(8676002)(966005)(2906002)(53546011)(5660300002)(336012)(6666004)(7696005)(70586007)(55016002)(356005)(47076005)(36860700001)(86362001)(83380400001)(26005)(15650500001)(36756003)(7636003)(498600001)(70206006)(6286002)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:18:58.9478 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68d1d7a0-1ba5-4fd1-91c5-08d913cf512a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3769 Subject: [dpdk-stable] patch 'net/hns3: fix VF mailbox head field' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/d0897ad2fbdc3e81fb3b2392dc8322dcb8567072 Thanks. Xueming Li --- >From d0897ad2fbdc3e81fb3b2392dc8322dcb8567072 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Wed, 31 Mar 2021 18:01:41 +0800 Subject: [PATCH] net/hns3: fix VF mailbox head field Cc: Luca Boccassi [ upstream commit 38d5b71c27d6fd9324cbaeed972df382c2c7a34b ] Currently, the VF mailbox synchronization communication is based on three fields: head/tail/lost, when head equals tail plus lost, it means the response is received successfully. The head field indicates the number of requests that are successfully sent. If the request sending fails, it should not be updated. This patch fix the above bug by roll back updates when the sending fails. Fixes: 463e748964f5 ("net/hns3: support mailbox") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_mbx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c index 82b634c365..0327bc1526 100644 --- a/drivers/net/hns3/hns3_mbx.c +++ b/drivers/net/hns3/hns3_mbx.c @@ -171,6 +171,7 @@ hns3_send_mbx_msg(struct hns3_hw *hw, uint16_t code, uint16_t subcode, hw->mbx_resp.head++; ret = hns3_cmd_send(hw, &desc, 1); if (ret) { + hw->mbx_resp.head--; rte_spinlock_unlock(&hw->mbx_resp.lock); hns3_err(hw, "VF failed(=%d) to send mbx message to PF", ret); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:30.739303500 +0800 +++ 0160-net-hns3-fix-VF-mailbox-head-field.patch 2021-05-10 23:59:26.610000000 +0800 @@ -1 +1 @@ -From 38d5b71c27d6fd9324cbaeed972df382c2c7a34b Mon Sep 17 00:00:00 2001 +From d0897ad2fbdc3e81fb3b2392dc8322dcb8567072 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 38d5b71c27d6fd9324cbaeed972df382c2c7a34b ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 499285d7c2..8ea8998ac7 100644 +index 82b634c365..0327bc1526 100644 @@ -29 +31 @@ -@@ -142,6 +142,7 @@ hns3_send_mbx_msg(struct hns3_hw *hw, uint16_t code, uint16_t subcode, +@@ -171,6 +171,7 @@ hns3_send_mbx_msg(struct hns3_hw *hw, uint16_t code, uint16_t subcode,