From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ABBEA0A0E for ; Mon, 10 May 2021 18:06:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94707406A3; Mon, 10 May 2021 18:06:33 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45]) by mails.dpdk.org (Postfix) with ESMTP id 866144003E for ; Mon, 10 May 2021 18:06:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfnLP/XQiRI5Fl7Rb6uKgV3o7S8PUogJn85VDjJj9Fj8h4RqZHBj7OZJvRrLo7T3f1Wmm/BZtliStV7Jnn/J7qBt+ozDQE9AGB7rsTWCSuGwmkcP71vnnkYsEFC2x25PP02ORGAenlyQwxQU9g/pFFPmNLRCWJY67zUDglBwEtMhP9rbvJR3PXedfrSs6mWK3XLI5+PXDZlZrCf6zzdm8XSZX1gHsfM5Kvjcr+9DKv3m3WMJZ+Su2q1+c10t1oarDnhfTEzhC+pdHZz+NKnR12Q7htKs7Y9kH3Nu3Xr3jY+jJo+f45ItqT/feYkZ5Ftm96COcLC+bG2ncKNnOTBjnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5o6xZ9dyzHuSoe3AzkYyWsy8lPymMHK5CMiNU2LPqXc=; b=TKrd8LVYarsLYdnl8ZCgcS1enGU9r8sPGu1DFSkJZPhrwEC64cYIN2hOP7KvAAwzhPJ6UA4svwtC608l+Fllrm9iQgAOb8SSGd0nUQN5GJEORqt0yUW1ttQBDfqQZdB/ODPU++Jg8X+Gy78F8OXHcIhIBJVWG97YQ1pRRCcGxvibjJCPVcKfd/N6brIriwuGnCIKABfS1QOvBRuUngSodpLX5QzOm08qTJmbYogq65pAJpnhQOMT6E3cecvLiQFWPG9CTSJH3nvkjPw4MzSMsc0j/fbWtNmrTop48YpMI9SZYCsob1jiJytUBhZho0wTrTRQ+Lw35nKdQm8uopD6EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5o6xZ9dyzHuSoe3AzkYyWsy8lPymMHK5CMiNU2LPqXc=; b=bZpGyEcqvy4c3PzCgw398W+6IH4rrZxWioZ3xtUy917v3eWUk0Pmij/VjWGCtKbYxhOw1eIgDIMk1+IoYt31zCu2065QmoEfPJf+NeMX0Fbmm3ALGFnsLLhpRNtS0SuqdeW08FI5qpht5bUfEr41rhG7LxtLj1FD0LbrIUwU7Ap07AU9scBRcwNE34CcbjtfYVWlIR6CcSKLspAd96agHiKV4exrYVu4wrzT5CdKdmepq5DCUsIpLofXMzxi/vzkiSDbBB67sl9pn3yQISeQdEymEQyZUPmaxq33ibmezI9Zhmw+orFGQSOgPZLIevZfQsF2UNwN8uGBQ+LNuFP7Dg== Received: from BN9PR03CA0882.namprd03.prod.outlook.com (2603:10b6:408:13c::17) by CO6PR12MB5474.namprd12.prod.outlook.com (2603:10b6:303:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:06:30 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13c:cafe::5d) by BN9PR03CA0882.outlook.office365.com (2603:10b6:408:13c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:06:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:06:29 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:06:25 +0000 From: Xueming Li To: Dapeng Yu CC: Luca Boccassi , Jeff Guo , dpdk stable Date: Mon, 10 May 2021 23:59:43 +0800 Message-ID: <20210510160258.30982-34-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae0bb80c-0510-4da8-97d1-08d913cd929a X-MS-TrafficTypeDiagnostic: CO6PR12MB5474: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JSYfj0z8cJY8faagh6UvtDrCh7oM9JNM2al2BRyPvG35+TN9M0ifS4TsI2pOai7UUbJXIsktNZAFYf9AzygiISP5OmS1v/7SRw3ssULG6WCro29j9wh1U65GF8kiRlZWltfDPR7y25xM1XlKaK4PzkXlhc2KSzMIsP9vSfHzoa0PMBfsaDp5KLUOrd9A8+A9/IzNWjutDOzACrdDbcXdE+r/DMku8M40Q77nAv+BcwPFLQdBSdUvZgMRHwAYDjDohCA0q5XZYrqW+ryM44tI9XwDZH5FhDD/TImHOGaeGaNL6qj9m47Vvnn6RYVNoVJCn0gTbVmr3D6QpnpLplgqTfq/BcePOmyMrR5GBreWimtv3c/3o9Gi2DpZ7Tpn+ddNhZZBgNYg3shdoHsFw99xlcFAlBSfMI6mfzwFcVyrHArjndMbxGlzRxVXn+oVAx3kRn8CCE+uzudSzEZvUAuExJ9GlTFEhonS1RTKblZrPW+oxxUXkvKSZvaMDFPj8gspyVJvDsa9K6D88wyVvgjX2KQ7wgQ8tUcTC6eYn0MenLNr6vbb6ePEN13x4LIM3V/nvExH2F0zGNXxhTpddY9+G7rXvJ2VjSZbA8zUBMC3b+jYHleSUaO6pu1PKZ4JdQIQZjAot7UZd4EXTpaCY58sRpaG70Xiph+z13VurbCNsIfiCBEi8ul7Iw3GqQRqPMuqGmDmvDRH0emsMMZbicsLsEzIEPaIOvt5+YlYxk9EOHXwdz648di7L4c1nqQ4CBNuTE03tQeUMx0iPR7Eh14veg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(39860400002)(136003)(36840700001)(46966006)(1076003)(4326008)(47076005)(7636003)(6666004)(8676002)(16526019)(8936002)(426003)(83380400001)(36756003)(36906005)(82310400003)(186003)(5660300002)(82740400003)(2906002)(55016002)(53546011)(36860700001)(26005)(2616005)(356005)(6286002)(70206006)(966005)(70586007)(478600001)(6916009)(54906003)(336012)(7696005)(316002)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:06:29.6205 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae0bb80c-0510-4da8-97d1-08d913cd929a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5474 Subject: [dpdk-stable] patch 'net/igc: remove MTU setting limitation' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/f9b6f0ca8b382686cf390db90e0bd95036e3ed6c Thanks. Xueming Li --- >From f9b6f0ca8b382686cf390db90e0bd95036e3ed6c Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Fri, 19 Feb 2021 18:01:07 +0800 Subject: [PATCH] net/igc: remove MTU setting limitation Cc: Luca Boccassi [ upstream commit 5db232fa5aed20f7b1b2eeed19c17a97259c1261 ] Currently, if requested MTU is bigger than mbuf size and scattered receive is not enabled, setting MTU to that value fails. This patch allows setting this special MTU when device is stopped, because scattered_rx will be re-configured during next port start and driver may enable scattered receive according new MTU value. After this patch, driver may select different receive function automatically after MTU set, according MTU values selected. Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") Signed-off-by: Dapeng Yu Acked-by: Jeff Guo --- drivers/net/igc/igc_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index 802212fc57..75e114b9ca 100644 --- a/drivers/net/igc/igc_ethdev.c +++ b/drivers/net/igc/igc_ethdev.c @@ -1590,12 +1590,14 @@ eth_igc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) return -EINVAL; /* - * refuse mtu that requires the support of scattered packets when - * this feature has not been enabled before. + * If device is started, refuse mtu that requires the support of + * scattered packets when this feature has not been enabled before. */ - if (!dev->data->scattered_rx && - frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) + if (dev->data->dev_started && !dev->data->scattered_rx && + frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) { + PMD_INIT_LOG(ERR, "Stop port first."); return -EINVAL; + } rctl = IGC_READ_REG(hw, IGC_RCTL); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:27.577615200 +0800 +++ 0035-net-igc-remove-MTU-setting-limitation.patch 2021-05-10 23:59:26.360000000 +0800 @@ -1 +1 @@ -From 5db232fa5aed20f7b1b2eeed19c17a97259c1261 Mon Sep 17 00:00:00 2001 +From f9b6f0ca8b382686cf390db90e0bd95036e3ed6c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 5db232fa5aed20f7b1b2eeed19c17a97259c1261 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index dbaa7a83e5..0ea6e2a045 100644 +index 802212fc57..75e114b9ca 100644