From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0088A0C3F for ; Mon, 10 May 2021 18:12:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AC5D40F35; Mon, 10 May 2021 18:12:02 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id E812F40140 for ; Mon, 10 May 2021 18:12:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVQEXfSh+25aAPW9mQ55g54Ilp9YZfPMllP3/pRUPib9fGN9bOaJy1TAJEwPi17AjuVhi/dONJAMgtzzH1VAVI21h5rcc/bO3lgA4i5cWrc/ZeI/iH5rVj2mfbHXxr+sUQPrVMCsfhElYdcXAPSMOMrAQMk29Yi/Gl637o0EsNdxVLmKbFmOyaBSL4OYI1x3dAs6CGNotKpaPnKfa0psP3TBe8nDUmjTV1tT2c7rH1+5sxy/crwauZXToJDHx/9R7qSIQOmAy78zdlREk18MVJcRcU5iYqLR8t9HJCmJdzAOdEjvRUlUJ0aPhtfd5othP3cn5pTcgwGp2nqENUmUcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3HY9Q7zsGmTH6Hiskn96UrImsMzgMH4DmXUHcAQCes=; b=B9sQhnu5MP8VK8cbaxaArPz4xTHppSXMyOtYKmAvs/O8InaaKBfUOMALzds/Bvttnfb4o7fg6DnumDPN66sSFslfgk5k/4vCeCSHqZdV85w8zMo9iiGlaKmljWCxA0fozRKuIeZ/Y4Xg8oySEkraFpkTF1662pUs+2bRGV6IfmPwG8EayTDFL/s1nrEhiv82Oy2pILIYL0MDahWNrem+W/Pe/uCAqwt/58wyI1CFYyJYRyIr9HSxhQbqtWqX6CxqBu83o2BVXQYttHeYTupCTl9mHcRt8UQ21JP+vtXLAN+XWCSbpmL8QVOs1bZa5HHtYq5S2TA8Z+p/7uG3p0xC6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3HY9Q7zsGmTH6Hiskn96UrImsMzgMH4DmXUHcAQCes=; b=e12P36XwBGm2XMr+xXFlOUpO4b8lZZixnOFbSq/nmxkGpAbs2tt5o3tlJT5nahCz6FSVfxxG27HDYr1h+ECgA+GZ368rkRBC6WMbz1EbGDL3uBLNtOJMg/XitkGLBJkwtk4BEFOrhURuJVhHGs2QfaBEV59NlsNko/94sJxfjKulnRAgeM7441XHdAdyVJ3vwWPuWRDZ6UsIhxUxg7xw6yGb5/P+JkGa0gx49taYMYjeSe1du4XGZZOCOGHaYCuZ+XJHXL5kzdxareqy/ey1CK1LWULNcxXK3jYdfL9RXr0ucViv39WASf4WGy4TxiFnXgRiQNLLL8oLx8TShD9Y/w== Received: from MWHPR17CA0059.namprd17.prod.outlook.com (2603:10b6:300:93::21) by MW2PR12MB2489.namprd12.prod.outlook.com (2603:10b6:907:d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:11:59 +0000 Received: from CO1NAM11FT046.eop-nam11.prod.protection.outlook.com (2603:10b6:300:93:cafe::36) by MWHPR17CA0059.outlook.office365.com (2603:10b6:300:93::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT046.mail.protection.outlook.com (10.13.174.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:59 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:11:55 +0000 From: Xueming Li To: Ajit Khaparde CC: Luca Boccassi , dpdk stable Date: Tue, 11 May 2021 00:00:38 +0800 Message-ID: <20210510160258.30982-89-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9803370-7523-4fe6-1cb9-08d913ce56ed X-MS-TrafficTypeDiagnostic: MW2PR12MB2489: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qrS7rmS63Ngvsdp43xd3TaOEF5iRnQHCfQNPoAvoPUjGtNRRyM6Ul3gbqWjDX9SKGhxMB2h3zIR2Iqd+LMlSF8yevfa/DsBdKAc5dye/F6px5wwnvgu9vT315O5L93HYjfm/pMe33R3UxMZjETP+UwySK5bXceSBLWGl66g+v0CV30Hnb4V8BUEJCjgJwmjkFTmX0XX4zZPzAhJoOYYPUpAnN3rUss1mGXYfZLN/eteroNASW0bJJYWTBpApPPpJbAhI7Yso2LvDj3kWVm6JlWtP2WF8UFe9zz9kouc+7P8ILfB7KVq7g3RnEiNEPYNwLwR9igoGdQd8gpusdDwWEjORYnrixgIprNzVYT2QsX4XH3ow/GAvb7Km3SE5hqYKDFrfxdV+jrT+d2Ois/Xn7MzETMYFDPu7Itq2o18BSgpmYDbkwuzXLlI9RUEWTGfRcSva0a8a+slT6fX1kXwdkWsm6CczEw03p/fNakHZoZNSUmGDE8CnfITjYePE/I2UIPQ27ZYnLUucMPyA4KCsQRYiDHagH8k1vp3Nhu1Kv3tBbWHXQiuxQ1umYpareE2la2/8Ro1MXqL+IaYpq7Uc+oC/Un2qO4mEg71gVe+hFxxHPTDdp48VqAJX9ap0PqnmNBjReJvtuSpfAn10wTY/tw18NRYsQ3wU9zXln8RCGdAzBn2bmeM2eqGQWH/HMp3RewfCLopkDlgtHOOjG0O+QzEP1arH9ne/O+c+a6/SLpY= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(376002)(39860400002)(46966006)(36840700001)(6286002)(36756003)(1076003)(36860700001)(16526019)(186003)(7696005)(47076005)(8676002)(356005)(53546011)(7636003)(2906002)(26005)(2616005)(316002)(82740400003)(336012)(426003)(55016002)(36906005)(6916009)(70206006)(70586007)(478600001)(54906003)(966005)(4326008)(8936002)(86362001)(5660300002)(6666004)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:11:59.1147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9803370-7523-4fe6-1cb9-08d913ce56ed X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2489 Subject: [dpdk-stable] patch 'net/bnxt: fix RSS context cleanup' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/88f2faa23cb3c3fd054f9b283eae65b6e2f98ee0 Thanks. Xueming Li --- >From 88f2faa23cb3c3fd054f9b283eae65b6e2f98ee0 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 15 Mar 2021 22:42:40 -0700 Subject: [PATCH] net/bnxt: fix RSS context cleanup Cc: Luca Boccassi [ upstream commit 670ab553841b2f2bbf59667465855b0869eea86b ] The PMD is allocating an extra RSS context with each port start. But it is freeing only one RSS context during port stop. So at some point we run out of RSS contexts when we do multiple port stop/start sequences. bnxt_hwrm_vnic_ctx_alloc() is called by bnxt_setup_one_vnic(), but bnxt_hwrm_vnic_ctx_free() is not called in the corresponding bnxt_free_one_vnic(). Fix this by calling bnxt_hwrm_vnic_ctx_free() in bnxt_free_one_vnic(). Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f0de380271..86c36e46d9 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2425,6 +2425,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) } bnxt_del_dflt_mac_filter(bp, vnic); + rc = bnxt_hwrm_vnic_ctx_free(bp, vnic); + if (rc) + return rc; + rc = bnxt_hwrm_vnic_free(bp, vnic); if (rc) return rc; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.927055800 +0800 +++ 0090-net-bnxt-fix-RSS-context-cleanup.patch 2021-05-10 23:59:26.450000000 +0800 @@ -1 +1 @@ -From 670ab553841b2f2bbf59667465855b0869eea86b Mon Sep 17 00:00:00 2001 +From 88f2faa23cb3c3fd054f9b283eae65b6e2f98ee0 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 670ab553841b2f2bbf59667465855b0869eea86b ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 1997783a7d..ff92f999db 100644 +index f0de380271..86c36e46d9 100644 @@ -27 +29 @@ -@@ -2531,6 +2531,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) +@@ -2425,6 +2425,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id)