From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7EB3A0A02 for ; Mon, 17 May 2021 18:15:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0D67410E2; Mon, 17 May 2021 18:15:29 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 8D453410E0 for ; Mon, 17 May 2021 18:15:27 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1liftt-0008Ct-I8; Mon, 17 May 2021 16:15:25 +0000 From: Christian Ehrhardt To: Chengwen Feng Cc: Min Hu , Reshma Pattan , dpdk stable Date: Mon, 17 May 2021 18:09:13 +0200 Message-Id: <20210517161039.3132619-124-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test: check thread creation' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0 Thanks. Christian Ehrhardt --- >From 8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 16 Apr 2021 16:18:26 +0800 Subject: [PATCH] test: check thread creation [ upstream commit a20cb9d0275eb7f0618b4ef2448544056e1035df ] There was a call for thread create function without result check. Add result check and message print out after failure. Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Acked-by: Reshma Pattan --- app/test/process.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/test/process.h b/app/test/process.h index c3b3780337..20e8eedda8 100644 --- a/app/test/process.h +++ b/app/test/process.h @@ -48,6 +48,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value) #ifdef RTE_LIBRTE_PDUMP #ifdef RTE_LIBRTE_RING_PMD pthread_t thread; + int rc; #endif #endif @@ -126,8 +127,13 @@ process_dup(const char *const argv[], int numargs, const char *env_value) /* parent process does a wait */ #ifdef RTE_LIBRTE_PDUMP #ifdef RTE_LIBRTE_RING_PMD - if ((strcmp(env_value, "run_pdump_server_tests") == 0)) - pthread_create(&thread, NULL, &send_pkts, NULL); + if ((strcmp(env_value, "run_pdump_server_tests") == 0)) { + rc = pthread_create(&thread, NULL, &send_pkts, NULL); + if (rc != 0) { + rte_panic("Cannot start send pkts thread: %s\n", + strerror(rc)); + } + } #endif #endif -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:34.273204377 +0200 +++ 0124-test-check-thread-creation.patch 2021-05-17 17:40:29.351810894 +0200 @@ -1 +1 @@ -From a20cb9d0275eb7f0618b4ef2448544056e1035df Mon Sep 17 00:00:00 2001 +From 8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a20cb9d0275eb7f0618b4ef2448544056e1035df ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 27f1b1c0e6..a09a088477 100644 +index c3b3780337..20e8eedda8 100644 @@ -24,2 +25,2 @@ - #ifdef RTE_LIB_PDUMP - #ifdef RTE_NET_RING + #ifdef RTE_LIBRTE_PDUMP + #ifdef RTE_LIBRTE_RING_PMD @@ -33,2 +34,2 @@ - #ifdef RTE_LIB_PDUMP - #ifdef RTE_NET_RING + #ifdef RTE_LIBRTE_PDUMP + #ifdef RTE_LIBRTE_RING_PMD