From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04D5CA0A02 for ; Mon, 17 May 2021 18:15:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1053410E2; Mon, 17 May 2021 18:15:38 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id A43A140041 for ; Mon, 17 May 2021 18:15:37 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifu5-0008Ec-Ew; Mon, 17 May 2021 16:15:37 +0000 From: Christian Ehrhardt To: Chengwen Feng Cc: Min Hu , dpdk stable Date: Mon, 17 May 2021 18:09:19 +0200 Message-Id: <20210517161039.3132619-130-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ethtool: remove unused parsing' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/ff92a2f5adb46f6c86cbf3f2a4a26b1fab2b1e88 Thanks. Christian Ehrhardt --- >From ff92a2f5adb46f6c86cbf3f2a4a26b1fab2b1e88 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Wed, 21 Apr 2021 10:39:43 +0800 Subject: [PATCH] examples/ethtool: remove unused parsing [ upstream commit 5be3505717269d6634a844bff3fc9339402b2690 ] The new_mtu was assigned twice, the first assignment could be removed. Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/ethtool/ethtool-app/ethapp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c index b6b967118e..62e400bba9 100644 --- a/examples/ethtool/ethtool-app/ethapp.c +++ b/examples/ethtool/ethtool-app/ethapp.c @@ -527,7 +527,6 @@ pcmd_mtu_callback(void *ptr_params, printf("Error: Invalid port number %i\n", params->port); return; } - new_mtu = atoi(params->opt); new_mtu = strtoul(params->opt, &ptr_parse_end, 10); if (*ptr_parse_end != '\0' || new_mtu < RTE_ETHER_MIN_MTU || -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:34.524335538 +0200 +++ 0130-examples-ethtool-remove-unused-parsing.patch 2021-05-17 17:40:29.387811178 +0200 @@ -1 +1 @@ -From 5be3505717269d6634a844bff3fc9339402b2690 Mon Sep 17 00:00:00 2001 +From ff92a2f5adb46f6c86cbf3f2a4a26b1fab2b1e88 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5be3505717269d6634a844bff3fc9339402b2690 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index e6c93e13a7..36a1c374f4 100644 +index b6b967118e..62e400bba9 100644 @@ -21 +22 @@ -@@ -528,7 +528,6 @@ pcmd_mtu_callback(void *ptr_params, +@@ -527,7 +527,6 @@ pcmd_mtu_callback(void *ptr_params,