From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A174BA0A02 for ; Mon, 17 May 2021 18:16:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95C5340041; Mon, 17 May 2021 18:16:51 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id A131340F35 for ; Mon, 17 May 2021 18:16:48 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifvC-0008P4-Nq; Mon, 17 May 2021 16:16:46 +0000 From: Christian Ehrhardt To: "Min Hu (Connor)" Cc: Ferruh Yigit , dpdk stable Date: Mon, 17 May 2021 18:09:48 +0200 Message-Id: <20210517161039.3132619-159-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/kni: check init result' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/41cbaf783bac0f3adede2cc53912914c5d5d0ea5 Thanks. Christian Ehrhardt --- >From 41cbaf783bac0f3adede2cc53912914c5d5d0ea5 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 11:56:29 +0800 Subject: [PATCH] test/kni: check init result [ upstream commit 381dfcf04717f92cfea68e53aac1979c098d35a4 ] Return value 'rte_kni_init' of a function is not checked. If it fails, error handling (logging and return) should be done. This patch fixed it. Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- app/test/test_kni.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test/test_kni.c b/app/test/test_kni.c index e621a17989..b338c916bb 100644 --- a/app/test/test_kni.c +++ b/app/test/test_kni.c @@ -563,7 +563,11 @@ test_kni(void) closedir(dir); /* Initialize KNI subsystem */ - rte_kni_init(KNI_TEST_MAX_PORTS); + ret = rte_kni_init(KNI_TEST_MAX_PORTS); + if (ret < 0) { + printf("fail to initialize KNI subsystem\n"); + return -1; + } if (test_kni_allocate_lcores() < 0) { printf("No enough lcores for kni processing\n"); -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:35.626242594 +0200 +++ 0159-test-kni-check-init-result.patch 2021-05-17 17:40:29.435811555 +0200 @@ -1 +1 @@ -From 381dfcf04717f92cfea68e53aac1979c098d35a4 Mon Sep 17 00:00:00 2001 +From 41cbaf783bac0f3adede2cc53912914c5d5d0ea5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 381dfcf04717f92cfea68e53aac1979c098d35a4 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3470005790..96733554b6 100644 +index e621a17989..b338c916bb 100644