From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2FD9A0A02 for ; Mon, 17 May 2021 18:11:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DFEA40041; Mon, 17 May 2021 18:11:46 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 3EE0440041 for ; Mon, 17 May 2021 18:11:45 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifqK-0007cy-PL; Mon, 17 May 2021 16:11:44 +0000 From: Christian Ehrhardt To: Ferruh Yigit Cc: Alexandre Ferrieux , dpdk stable Date: Mon, 17 May 2021 18:07:36 +0200 Message-Id: <20210517161039.3132619-27-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'log/linux: make default output stderr' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/7fa4f46043890a9c7709d6b38684709f0e498788 Thanks. Christian Ehrhardt --- >From 7fa4f46043890a9c7709d6b38684709f0e498788 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 9 Feb 2021 15:06:20 +0000 Subject: [PATCH] log/linux: make default output stderr [ upstream commit 5988725d0efeb7021670986aafeb3ff3d87839e1 ] In Linux by default DPDK log goes to stdout, as well as syslog. It is possible for an application to change the library output stream via 'rte_openlog_stream()' API, to set it to stderr, it can be used as: rte_openlog_stream(stderr); But still updating the default log output to 'stderr'. Bugzilla ID: 8 Fixes: af75078fece3 ("first public release") Reported-by: Alexandre Ferrieux Signed-off-by: Ferruh Yigit --- lib/librte_eal/linux/eal/eal_log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_log.c b/lib/librte_eal/linux/eal/eal_log.c index 9d02dddbed..bd5358ca24 100644 --- a/lib/librte_eal/linux/eal/eal_log.c +++ b/lib/librte_eal/linux/eal/eal_log.c @@ -27,9 +27,9 @@ console_log_write(__attribute__((unused)) void *c, const char *buf, size_t size) { ssize_t ret; - /* write on stdout */ - ret = fwrite(buf, 1, size, stdout); - fflush(stdout); + /* write on stderr */ + ret = fwrite(buf, 1, size, stderr); + fflush(stderr); /* Syslog error levels are from 0 to 7, so subtract 1 to convert */ syslog(rte_log_cur_msg_loglevel() - 1, "%.*s", (int)size, buf); -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:30.622961530 +0200 +++ 0027-log-linux-make-default-output-stderr.patch 2021-05-17 17:40:29.147809287 +0200 @@ -1 +1 @@ -From 5988725d0efeb7021670986aafeb3ff3d87839e1 Mon Sep 17 00:00:00 2001 +From 7fa4f46043890a9c7709d6b38684709f0e498788 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5988725d0efeb7021670986aafeb3ff3d87839e1 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ - lib/librte_eal/linux/eal_log.c | 6 +++--- + lib/librte_eal/linux/eal/eal_log.c | 6 +++--- @@ -24,5 +25,5 @@ -diff --git a/lib/librte_eal/linux/eal_log.c b/lib/librte_eal/linux/eal_log.c -index 43c8460bfb..2095df74c5 100644 ---- a/lib/librte_eal/linux/eal_log.c -+++ b/lib/librte_eal/linux/eal_log.c -@@ -27,9 +27,9 @@ console_log_write(__rte_unused void *c, const char *buf, size_t size) +diff --git a/lib/librte_eal/linux/eal/eal_log.c b/lib/librte_eal/linux/eal/eal_log.c +index 9d02dddbed..bd5358ca24 100644 +--- a/lib/librte_eal/linux/eal/eal_log.c ++++ b/lib/librte_eal/linux/eal/eal_log.c +@@ -27,9 +27,9 @@ console_log_write(__attribute__((unused)) void *c, const char *buf, size_t size)