From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C308FA0A02 for ; Mon, 17 May 2021 18:12:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8478641106; Mon, 17 May 2021 18:12:34 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 61C5C410F1 for ; Mon, 17 May 2021 18:12:33 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifr5-0007lX-Dk; Mon, 17 May 2021 16:12:31 +0000 From: Christian Ehrhardt To: Dapeng Yu Cc: Reshma Pattan , dpdk stable Date: Mon, 17 May 2021 18:07:56 +0200 Message-Id: <20210517161039.3132619-47-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/packet_ordering: fix port configuration' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/616e4fe2911bc51ac628c66b3fdac7845939d994 Thanks. Christian Ehrhardt --- >From 616e4fe2911bc51ac628c66b3fdac7845939d994 Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Fri, 19 Mar 2021 15:11:18 +0800 Subject: [PATCH] examples/packet_ordering: fix port configuration [ upstream commit c99f115bbd9d56630fc5a8d404443e0761684832 ] A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be enabled on port. This patch use this local variable as input of rte_eth_dev_configure(). Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API") Signed-off-by: Dapeng Yu Acked-by: Reshma Pattan --- examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index edaf810d94..4eea8a3318 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -293,7 +293,7 @@ configure_eth_port(uint16_t port_id) if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; - ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default); + ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf); if (ret != 0) return ret; -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:31.401647969 +0200 +++ 0047-examples-packet_ordering-fix-port-configuration.patch 2021-05-17 17:40:29.179809538 +0200 @@ -1 +1 @@ -From c99f115bbd9d56630fc5a8d404443e0761684832 Mon Sep 17 00:00:00 2001 +From 616e4fe2911bc51ac628c66b3fdac7845939d994 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c99f115bbd9d56630fc5a8d404443e0761684832 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index ff670747fd..bcbda05f5e 100644 +index edaf810d94..4eea8a3318 100644 @@ -27 +28 @@ -@@ -297,7 +297,7 @@ configure_eth_port(uint16_t port_id) +@@ -293,7 +293,7 @@ configure_eth_port(uint16_t port_id)