From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BC1BA0A02 for ; Mon, 17 May 2021 18:12:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AFC641102; Mon, 17 May 2021 18:12:45 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 920D740041 for ; Mon, 17 May 2021 18:12:43 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifrH-0007ms-Ci; Mon, 17 May 2021 16:12:43 +0000 From: Christian Ehrhardt To: Ajit Khaparde Cc: dpdk stable Date: Mon, 17 May 2021 18:08:03 +0200 Message-Id: <20210517161039.3132619-54-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix RSS context cleanup' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/a9a6ca9809d08400c8de693f7574ce7ccf62565a Thanks. Christian Ehrhardt --- >From a9a6ca9809d08400c8de693f7574ce7ccf62565a Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 15 Mar 2021 22:42:40 -0700 Subject: [PATCH] net/bnxt: fix RSS context cleanup [ upstream commit 670ab553841b2f2bbf59667465855b0869eea86b ] The PMD is allocating an extra RSS context with each port start. But it is freeing only one RSS context during port stop. So at some point we run out of RSS contexts when we do multiple port stop/start sequences. bnxt_hwrm_vnic_ctx_alloc() is called by bnxt_setup_one_vnic(), but bnxt_hwrm_vnic_ctx_free() is not called in the corresponding bnxt_free_one_vnic(). Fix this by calling bnxt_hwrm_vnic_ctx_free() in bnxt_free_one_vnic(). Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b1154df66e..59f66ce539 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1952,6 +1952,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) } bnxt_del_dflt_mac_filter(bp, vnic); + rc = bnxt_hwrm_vnic_ctx_free(bp, vnic); + if (rc) + return rc; + rc = bnxt_hwrm_vnic_free(bp, vnic); if (rc) return rc; -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:31.673663703 +0200 +++ 0054-net-bnxt-fix-RSS-context-cleanup.patch 2021-05-17 17:40:29.191809632 +0200 @@ -1 +1 @@ -From 670ab553841b2f2bbf59667465855b0869eea86b Mon Sep 17 00:00:00 2001 +From a9a6ca9809d08400c8de693f7574ce7ccf62565a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 670ab553841b2f2bbf59667465855b0869eea86b ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 1997783a7d..ff92f999db 100644 +index b1154df66e..59f66ce539 100644 @@ -27 +28 @@ -@@ -2531,6 +2531,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) +@@ -1952,6 +1952,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id)