From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D296FA0A02 for ; Mon, 17 May 2021 18:12:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC834410E2; Mon, 17 May 2021 18:12:58 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 5354F40041 for ; Mon, 17 May 2021 18:12:57 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifrT-0007o9-4s; Mon, 17 May 2021 16:12:55 +0000 From: Christian Ehrhardt To: Igor Russkikh Cc: Rasesh Mody , dpdk stable Date: Mon, 17 May 2021 18:08:09 +0200 Message-Id: <20210517161039.3132619-60-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: accept bigger RSS table' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/95c2cf40898ac03de1e35053726d7c3179d6ecf3 Thanks. Christian Ehrhardt --- >From 95c2cf40898ac03de1e35053726d7c3179d6ecf3 Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Fri, 19 Mar 2021 10:46:56 +0100 Subject: [PATCH] net/qede: accept bigger RSS table [ upstream commit 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 ] Some dpdk applications blindly pass fixed side RSS hash tables, and do not check driver/device capabilities. Moreover, many other drivers do not do such a strong check as well. Fix it by making qede accept any size rss_key. For larger key tables we just crop it with notice trace message. Signed-off-by: Igor Russkikh Acked-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 6f2f0051f6..0be9c5a211 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2049,8 +2049,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, /* RSS hash key */ if (key) { if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) { - DP_ERR(edev, "RSS key length exceeds limit\n"); - return -EINVAL; + len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t); + DP_NOTICE(edev, false, + "RSS key length too big, trimmed to %d\n", + len); } DP_INFO(edev, "Applying user supplied hash key\n"); rss_params.update_rss_key = 1; -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:31.877820417 +0200 +++ 0060-net-qede-accept-bigger-RSS-table.patch 2021-05-17 17:40:29.199809697 +0200 @@ -1 +1 @@ -From 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 Mon Sep 17 00:00:00 2001 +From 95c2cf40898ac03de1e35053726d7c3179d6ecf3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 ] + @@ -14,2 +15,0 @@ -Cc: stable@dpdk.org - @@ -23 +23 @@ -index ab5f5b1065..bfd38a9772 100644 +index 6f2f0051f6..0be9c5a211 100644 @@ -26 +26 @@ -@@ -2139,8 +2139,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, +@@ -2049,8 +2049,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,