From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 925EAA0A02 for ; Mon, 17 May 2021 18:14:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BAA7410EA; Mon, 17 May 2021 18:14:05 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 3620C40041 for ; Mon, 17 May 2021 18:14:04 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifsa-00081d-0O; Mon, 17 May 2021 16:14:04 +0000 From: Christian Ehrhardt To: Kalesh AP Cc: Somnath Kotur , dpdk stable Date: Mon, 17 May 2021 18:08:36 +0200 Message-Id: <20210517161039.3132619-87-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix configuring LRO' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/687314688414f260cd3b99cccf95fceb2f97ed83 Thanks. Christian Ehrhardt --- >From 687314688414f260cd3b99cccf95fceb2f97ed83 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Fri, 2 Apr 2021 08:55:51 +0530 Subject: [PATCH] net/bnxt: fix configuring LRO [ upstream commit e73fb98b69dffacb2c74e45807096ec597b88cae ] While configuring LRO, driver should check the return value of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error when the FW command fails. Fixes: 0958d8b6435d ("net/bnxt: support LRO") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 1ab07ed826..a6c902535a 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -320,10 +320,11 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) bnxt_hwrm_vnic_plcmode_cfg(bp, vnic); - if (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) - bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 1); - else - bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 0); + rc = bnxt_hwrm_vnic_tpa_cfg(bp, vnic, + (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) ? + true : false); + if (rc) + goto err_out; return 0; err_out: -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:32.903048577 +0200 +++ 0087-net-bnxt-fix-configuring-LRO.patch 2021-05-17 17:40:29.267810232 +0200 @@ -1 +1 @@ -From e73fb98b69dffacb2c74e45807096ec597b88cae Mon Sep 17 00:00:00 2001 +From 687314688414f260cd3b99cccf95fceb2f97ed83 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e73fb98b69dffacb2c74e45807096ec597b88cae ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 02fe00036b..20ca57eae5 100644 +index 1ab07ed826..a6c902535a 100644 @@ -23 +24 @@ -@@ -479,10 +479,11 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) +@@ -320,10 +320,11 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id)