From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03B3EA0C45 for ; Thu, 10 Jun 2021 14:06:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8BF34069B; Thu, 10 Jun 2021 14:06:49 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id B7B984069B for ; Thu, 10 Jun 2021 14:06:48 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lrJSR-0008O2-9H; Thu, 10 Jun 2021 12:06:47 +0000 From: Christian Ehrhardt To: "Min Hu (Connor)" Cc: dpdk stable Date: Thu, 10 Jun 2021 14:05:52 +0200 Message-Id: <20210610120641.885862-4-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210610120641.885862-1-christian.ehrhardt@canonical.com> References: <20210610120641.885862-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'raw/skeleton: add missing check after setting attribute' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/6285f76a753f831f2e1853766def7ca4f54bb4eb Thanks. Christian Ehrhardt --- >From 6285f76a753f831f2e1853766def7ca4f54bb4eb Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 14:21:46 +0800 Subject: [PATCH] raw/skeleton: add missing check after setting attribute [ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ] This patch adds return value check for setting an attribute. Fixes: 88a81bcecb7b ("raw/skeleton: remove compile-time constant for device id") Signed-off-by: Min Hu (Connor) --- drivers/raw/skeleton/skeleton_rawdev_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index 1190e28bb7..fa7f4fab5e 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -291,6 +291,7 @@ test_rawdev_attr_set_get(void) dummy_value = &set_value; *dummy_value = 200; ret = rte_rawdev_set_attr(test_dev_id, "Test2", (uintptr_t)dummy_value); + RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test2)"); /* Check if attributes have been set */ ret = rte_rawdev_get_attr(test_dev_id, "Test1", &ret_value); -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-10 14:04:58.287275179 +0200 +++ 0004-raw-skeleton-add-missing-check-after-setting-attribu.patch 2021-06-10 14:04:57.994024108 +0200 @@ -1 +1 @@ -From b97012825dfad7d30bbd1fa99ec6115eba6135ce Mon Sep 17 00:00:00 2001 +From 6285f76a753f831f2e1853766def7ca4f54bb4eb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index 1405df080d..484468eeb4 100644 +index 1190e28bb7..fa7f4fab5e 100644 @@ -20 +21 @@ -@@ -295,6 +295,7 @@ test_rawdev_attr_set_get(void) +@@ -291,6 +291,7 @@ test_rawdev_attr_set_get(void)