From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EC31A0C3F for ; Sat, 12 Jun 2021 01:05:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 596D04003F; Sat, 12 Jun 2021 01:05:41 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2041.outbound.protection.outlook.com [40.107.101.41]) by mails.dpdk.org (Postfix) with ESMTP id 8A57E410F7 for ; Sat, 12 Jun 2021 01:05:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S92HLvwkAvSwcHVf+93g+cEInmMaKgXPYhVQq7D6ej5gJ8ZG03TtK4dzzGbxtD9ZRn/hyWGGHRKUQvmytws4Hq1oYKTULBK+K9j7NmNTaKqsp0F0T9qUr8V5Sl/977okVtlFi/v/Ztb/Gx/+Mbkfyjpc7suoQJkXpDOaG+qmgEnXS+fSo7VHZJjTJ0U5G/VptFMHuAKwXTRDEYnE9QbJtdNurLF6ogfV3cIS43LucvkCBcLjbs74QY4NoG7iUtc5isoREP+ckQdfwAQ5QM+cyAH/aXwpAa9S+ys5VLw9QGpY9DmqbohQIrke5zvviSFeDuDXY5oqfCuaMcLaj8V0nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KR+ViN6ehuRuTLb3U7xUV3TP6pDOkHlGjijrpWRwcGo=; b=H97CmkJZrhvIw8REUMbFBJ9Oe7lFvAc1oWs4aCzhBBHm/wj0HPu42fUYkgh/QAVDWQb/FfbQifI5HJgsK8sX+LtW2teJT38Dd9MpIGrghQu4t0DjScp1aiIbkxtmzGHRExTyXCJ97OdiFkoTQ4381Lc/t2bFgkeaF63vPmK+/tDbk2Wl4pi+M89yBqhWIZ3AiDlXoK50a3zzmENCpViN3zv37i4qWst3K5av3L2dPDVEyX8WnvRnKsx3WjtlsXYMK+Gh0Yd7bxpwgHytdFS6E6+idt6Fn/fvi3xSYF7NJtFDn/QVk7ISyxsrN4GbdAAlUDwTSxeEvbEI84RfK9vGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KR+ViN6ehuRuTLb3U7xUV3TP6pDOkHlGjijrpWRwcGo=; b=kvFuwdz8ScqNUgphCWvo5dZqZSVkw7cMZKZCzCBhU/kBdKGOBZBzgxOGPZmFmOdH277dGFFKLlV3Azc2/ytrWlXaZwqTZ7mtAkxy+RP1y8m9WauVyOYx4OKjgStoR0ubUQMf8fqUPpqxxzqn8Q02WWbX4GN288BNdCVGHt4fy/0X/IwOglHOhy+UkC2AENTetWplHFadmG3ZC1FaHlbDvWEdtyWPlHKN9tnV+bVEcOIwH5tnL5TctYnsoROoogAOpq2a/5AFisCGUjy5bffCVVDZjYdH1wvAiSsPTCUG+2KhqCOW8lhEryZENrYqwhA3I/Oz/wwglRvGUOE1VrKXyA== Received: from MWHPR07CA0022.namprd07.prod.outlook.com (2603:10b6:300:116::32) by BN6PR12MB1441.namprd12.prod.outlook.com (2603:10b6:405:11::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Fri, 11 Jun 2021 23:05:38 +0000 Received: from CO1NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:300:116:cafe::bf) by MWHPR07CA0022.outlook.office365.com (2603:10b6:300:116::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:05:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT027.mail.protection.outlook.com (10.13.174.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:38 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:05:36 +0000 From: Xueming Li To: Konstantin Ananyev CC: Luca Boccassi , Ali Alnubani , "dpdk stable" Date: Sat, 12 Jun 2021 07:01:44 +0800 Message-ID: <20210611230433.8208-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b340260-8a02-45e1-a816-08d92d2d6da5 X-MS-TrafficTypeDiagnostic: BN6PR12MB1441: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GHDMND6pwQgy72wCgURKqIbhAlwo1eIILvEVkjh4PgmT+PG0hq+v+hMw8EetpAdIllvWkYFtIXdWGErTdnBNWEVKUoN4RnXfvdvEL5oacpOWUhEX5oFVsXNUgWfEdLzKxV5sGt9x9Vc+q831lDCG0y95c1oaifEB38wacsYWCzrXfeZ567jYpqpy749oqEEFQGjY+PnnI3/TAtwpC9P7H0LFQa+BTJuEsrueFoCmByWAdJSoPlFCgf8ccwx+v8KEm1YQeDMVpvfRcELwdPRxEPhbcClnQV231/HJHxXK1+W4zm3vTWaoOA+ozZ1T1NA4grYnjhLI6QqczvHi89pJ6AF8l5FNNrJOg/H31QF1QWWCIU6Ye3A9UDu2hb1yJpoQpX7c27udAzsO7bm96cuUpyLpulep6LyryZYtig9XVz3KH1UlA7Cm9uO+IRGmGTsqPMHDkUt74l9PfQcRAUHs+Hu8k+cx4xxgmWfYn2ADSDwGAHdp8tNt30BHE6Ckz1Xg+i/O023RQDLrx8KfX1fUHjvVzbXmuLV1NcZC8yVEbTjNuAoEqHk++cOUIlP9Iu4w4kv9nNs9xfHi5ODvlZPyDnFnv5qEx2qWjM+j+H5OtnI8KldJQm7cFB+AuxbXC2/AsLpFV2FhQ8MF6pu6Xb6dsz8CJxvtZF25ScgLPD6SJpLmbXypCvE/ig0vGksb6XDapuVgeCpjo/ypmgBPqdYVpK2ZsD7Z6dpvBrqlNTzvFTnZbQomMzpgjewZ5BFmOeMN+2eAuK6lBz3rMsjU4C5QRxAlgdxbBYFvfzyf+PRSeyu0PXOGy6gaGp7YRZJNdlu1 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(46966006)(16526019)(47076005)(7636003)(36906005)(6916009)(70586007)(70206006)(478600001)(1076003)(83380400001)(86362001)(6286002)(6666004)(36860700001)(82740400003)(54906003)(186003)(8676002)(8936002)(4326008)(53546011)(966005)(356005)(5660300002)(426003)(7696005)(82310400003)(2616005)(2906002)(55016002)(36756003)(316002)(26005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:05:38.5377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b340260-8a02-45e1-a816-08d92d2d6da5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1441 Subject: [dpdk-stable] patch 'acl: fix build with GCC 11' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/a5fd2098d6e839c2266f3f80279e1e6f3164a6a1 Thanks. Xueming Li --- >From a5fd2098d6e839c2266f3f80279e1e6f3164a6a1 Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Mon, 26 Apr 2021 14:35:19 +0100 Subject: [PATCH] acl: fix build with GCC 11 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Luca Boccassi [ upstream commit 8e2dd74f0afd3ef3358f1cca05afb20bda670207 ] gcc 11 with '-O2' complains about some variables being used without being initialized: In function ‘start_flow_avx512x8’, inlined from ‘search_trie_avx512x8.constprop’ at acl_run_avx512_common.h:317: lib/librte_acl/acl_run_avx512_common.h:210:13: warning: ‘pdata’ is used uninitialized [-Wuninitialized] In function ‘search_trie_avx512x8.constprop’: lib/librte_acl/acl_run_avx512_common.h:314:32: note: ‘pdata’ declared here ... Indeed, these variables are not explicitly initialized, but this is done intentionally. We rely on constant mask value that we pass to start_flow*() functions as a parameter to mask out uninitialized values. Note that '-O3' doesn't produce this warning. Anyway, to support clean build with gcc-11 this patch adds explicit initialization for these variables. I checked the output binary: with '-O3' both clang and gcc 10/11 generate no extra code for it. Also performance test didn't reveal any regressions. Bugzilla ID: 673 Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method") Fixes: 45da22e42ec3 ("acl: add 512-bit AVX512 classify method") Reported-by: Ali Alnubani Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_run_avx512_common.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/lib/librte_acl/acl_run_avx512_common.h b/lib/librte_acl/acl_run_avx512_common.h index fafaf591e8..fbad74d459 100644 --- a/lib/librte_acl/acl_run_avx512_common.h +++ b/lib/librte_acl/acl_run_avx512_common.h @@ -303,6 +303,28 @@ _F_(match_check_process)(struct acl_flow_avx512 *flow, uint32_t fm[2], } } +static inline void +_F_(reset_flow_vars)(_T_simd di[2], _T_simd idx[2], _T_simd pdata[4], + _T_simd tr_lo[2], _T_simd tr_hi[2]) +{ + di[0] = _M_SI_(setzero)(); + di[1] = _M_SI_(setzero)(); + + idx[0] = _M_SI_(setzero)(); + idx[1] = _M_SI_(setzero)(); + + pdata[0] = _M_SI_(setzero)(); + pdata[1] = _M_SI_(setzero)(); + pdata[2] = _M_SI_(setzero)(); + pdata[3] = _M_SI_(setzero)(); + + tr_lo[0] = _M_SI_(setzero)(); + tr_lo[1] = _M_SI_(setzero)(); + + tr_hi[0] = _M_SI_(setzero)(); + tr_hi[1] = _M_SI_(setzero)(); +} + /* * Perform search for up to (2 * _N_) flows in parallel. * Use two sets of metadata, each serves _N_ flows max. @@ -313,6 +335,8 @@ _F_(search_trie)(struct acl_flow_avx512 *flow) uint32_t fm[2]; _T_simd di[2], idx[2], in[2], pdata[4], tr_lo[2], tr_hi[2]; + _F_(reset_flow_vars)(di, idx, pdata, tr_lo, tr_hi); + /* first 1B load */ _F_(start_flow)(flow, _SIMD_MASK_BIT_, _SIMD_MASK_MAX_, &pdata[0], &idx[0], &di[0]); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:56.955338300 +0800 +++ 0010-acl-fix-build-with-GCC-11.patch 2021-06-12 06:53:56.010000000 +0800 @@ -1 +1 @@ -From 8e2dd74f0afd3ef3358f1cca05afb20bda670207 Mon Sep 17 00:00:00 2001 +From a5fd2098d6e839c2266f3f80279e1e6f3164a6a1 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Luca Boccassi + +[ upstream commit 8e2dd74f0afd3ef3358f1cca05afb20bda670207 ] @@ -34 +36,0 @@ -Cc: stable@dpdk.org @@ -39 +41 @@ - lib/acl/acl_run_avx512_common.h | 24 ++++++++++++++++++++++++ + lib/librte_acl/acl_run_avx512_common.h | 24 ++++++++++++++++++++++++ @@ -42 +44 @@ -diff --git a/lib/acl/acl_run_avx512_common.h b/lib/acl/acl_run_avx512_common.h +diff --git a/lib/librte_acl/acl_run_avx512_common.h b/lib/librte_acl/acl_run_avx512_common.h @@ -44,2 +46,2 @@ ---- a/lib/acl/acl_run_avx512_common.h -+++ b/lib/acl/acl_run_avx512_common.h +--- a/lib/librte_acl/acl_run_avx512_common.h ++++ b/lib/librte_acl/acl_run_avx512_common.h