From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A8F6A0C3F for ; Sat, 12 Jun 2021 01:18:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23B704003F; Sat, 12 Jun 2021 01:18:25 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id 767B64003F for ; Sat, 12 Jun 2021 01:18:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GW1M9UmCzSo62mm65bVDz4aJwOvFrIdsv/PM9RBeU7qJHDOqnF3agAoyvYS/zJHdMSK8fWwahhgky9rvQGAwWS5xmioWb3ACy1ePgNrmAwdHTRzmHIw+6VrX5yzIfDEjTjtx1yh2Ql3NK6XWwyN+XFVJLEn8hFHX/hNipqzdMYjuUW/tzTBLzlioLwrReN9aDePTonmxfExbJSne9yEv8iOJEtz9Oo1SD5ge43+fpY0kEUOXxQJCL7RewyPPJuvGl7c1IKAGigADZVjbhoaufOw2NnZSEmIzA4ZxsVfw/hvKYVBDbqyIJZFCUzj/0z2XDJV9+pZRpniY070X9dF6Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwqe1cHsK57QMi13h4BjEzVDtG4HBG1hg5nBfS2nl0M=; b=hkEEvRBvt+AicLNo2vDV2gFS/1auH/UiU7VKhbAHBnk0hmH3QGthF0IDupU8s1q686c+jvnh7LnvAtzpVVcN0lcYUSxk52oSOPLbVVf3QEWcWcAwtFq4+rld9k8tgLRLxqvfc+eyCtvU5laEudhCG9Kc/WaeUBBuf6LpJid9RfKvPFU5vT4j1SL9JWQjKP/YnoF5xU7jJAzoCXYfGUoRW30ZJQZ3eE5+PnalyohLXnJ1GbNRelFeWCVbb+AUqIl3z+9qJw+A2dr99+6nrJo2D8585JZH9fOIPIrnbidL+5UFVkPEHEO8LIIpxKXsw5rLOVxl0nhMX108NRQfksIrJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwqe1cHsK57QMi13h4BjEzVDtG4HBG1hg5nBfS2nl0M=; b=n6xDIikXtETQjzzu4IGYqXTsCD77k8mt3jTFccPYHE0uasnk6a+l8ziI9SiinypTZ2Hf8aTaovwxROYrvzfBPQVbk5EohEeaSIPLlD0nhtRYxcswkFzv9xeI0ZqTBe4795kts5ea7tfPnmgluNOMwQHt5O3JPnW0giN/zFqkiuyIQzFAE9ysmAFxUgvkYfulnT9s6wC0+AmOMEx00iCwBtMgQEbVRJUv9Mx6GYHcdzcWrqXvx9oo39SRl196fzFXaDBXLadN0tbbaNO7+QzvWnXvPnj7knlO0PIM+xShsONn4whViTbdwwft92vK3cnu3Uq3iVD1VfoFnY0dp3Y45Q== Received: from BN0PR03CA0028.namprd03.prod.outlook.com (2603:10b6:408:e6::33) by BN6PR1201MB0147.namprd12.prod.outlook.com (2603:10b6:405:56::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Fri, 11 Jun 2021 23:18:20 +0000 Received: from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e6:cafe::96) by BN0PR03CA0028.outlook.office365.com (2603:10b6:408:e6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:20 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:18 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Viacheslav Ovsiienko , dpdk stable Date: Sat, 12 Jun 2021 07:03:55 +0800 Message-ID: <20210611230433.8208-141-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a8b8aa7-9ef7-44e5-d1f1-08d92d2f33da X-MS-TrafficTypeDiagnostic: BN6PR1201MB0147: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fg9TVr/he5ZjM88/E0J6qxoe46hK28UsabuIfLQszaI4jyjiCPu8LHqba7oitG8/UYxnMPB0XQLvcZ5+AmJBSeG9Yvo6fouRtHpWLih/HCGNKNkNoRkZbPQTYeEk6OCJnBsYTaCT3PF2WMITnJH2yOXRPpZEDzYIE3V5+kCQyC2EepVAObXIniNxh32QpKCigLWEQ5QdroarfDvFjYbASz/kXSf0aHFhlCYvLTmvDBwOvt/WPUQ4MKc2QpQ3SOALGaK/BFPNIlxlhe5qWyHMNV51eeJh6bfuNimck4M1Lt6QvDIOEf8ARhA1FXSWE+b6Ne73bxURKQVvczu2s7sSlDDUIhW5q9H67DXiZuFSOUjU/yu4gNM8faIQZbsAtIlPtvan0Rpum+nZmFyLDpTVh82NrrsIePLZCDP6cNjNR3LEJ88kBOj/No8TO41UuEuxfvEdjNV7MhnWzyY/GbaTcNZShyQ5jj+kImuJuP7T9oWkrPV2kW0iiRz56GqyfAK/NGQpeKI08Z5uhwJkHHs4MBFl+LvnlY786ifdIpBqtwuiYPdJKqsEIDnLqXYn36Jifqdrxnyqw/BMSal2Jb1bLpTI69BjXggTv40W6FsW/8RKRJYMgby5U437WZ0qhyx//Fkm02yqom0p20nhprTFNkBvpH4Ll1QCt7m5psccLSj7UcQC1956q8xOiEOzdlohnrbK/XxSECsFiZ6i+3OMTrMM+3jQ03iKdEjTGIV/5oL2k3gtIDNeKkCXscU4mtu4vEVqff2D2+04WAwRCOvWDsW3ePDLYzs6w7kLOFM7aGiJsOiUlJSbgfS7FE6Ftdw8 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(36840700001)(46966006)(426003)(86362001)(6916009)(36906005)(316002)(70586007)(2616005)(70206006)(336012)(186003)(478600001)(2906002)(1076003)(82310400003)(6666004)(26005)(36860700001)(966005)(7696005)(6286002)(54906003)(4326008)(16526019)(8936002)(7636003)(47076005)(36756003)(356005)(55016002)(8676002)(83380400001)(53546011)(82740400003)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:20.3918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a8b8aa7-9ef7-44e5-d1f1-08d92d2f33da X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0147 Subject: [dpdk-stable] patch 'net/mlx4: fix secondary process initialization ordering' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/14b6df2399e05851c44075f457088ce63b6480d7 Thanks. Xueming Li --- >From 14b6df2399e05851c44075f457088ce63b6480d7 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Mon, 10 May 2021 20:06:02 +0800 Subject: [PATCH] net/mlx4: fix secondary process initialization ordering Cc: Luca Boccassi [ upstream commit e5d94cf94e9d7c240e73b390c8c292fc9595f971 ] The memory barrier is used to ensure that the response is returned only after the Tx/Rx function is set, it should place after the Rx/Tx function is set. Fixes: 0203d33a1059 ("net/mlx4: support secondary process") Signed-off-by: Chengwen Feng Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx4/mlx4_mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c index 3622d61075..dd72755252 100644 --- a/drivers/net/mlx4/mlx4_mp.c +++ b/drivers/net/mlx4/mlx4_mp.c @@ -126,7 +126,6 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer) switch (param->type) { case MLX4_MP_REQ_START_RXTX: INFO("port %u starting datapath", dev->data->port_id); - rte_mb(); dev->tx_pkt_burst = mlx4_tx_burst; dev->rx_pkt_burst = mlx4_rx_burst; #ifdef HAVE_IBV_MLX4_UAR_MMAP_OFFSET @@ -144,6 +143,7 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer) } } #endif + rte_mb(); mp_init_msg(dev, &mp_res, param->type); res->result = 0; ret = rte_mp_reply(&mp_res, peer); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.181281300 +0800 +++ 0141-net-mlx4-fix-secondary-process-initialization-orderi.patch 2021-06-12 06:53:56.590000000 +0800 @@ -1 +1 @@ -From e5d94cf94e9d7c240e73b390c8c292fc9595f971 Mon Sep 17 00:00:00 2001 +From 14b6df2399e05851c44075f457088ce63b6480d7 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit e5d94cf94e9d7c240e73b390c8c292fc9595f971 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index ddf7bdb9ef..8fcfb5490e 100644 +index 3622d61075..dd72755252 100644