From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 586C5A0C3F for ; Sat, 12 Jun 2021 01:19:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 511474003F; Sat, 12 Jun 2021 01:19:00 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by mails.dpdk.org (Postfix) with ESMTP id 16F184003F for ; Sat, 12 Jun 2021 01:18:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJxwDQVlpYcV3OTXwxP6nquL2IapTZCXvvoWVpzUdpJp1IUCZI6lF5yjnbdjxcbIoOdGfzIOgD+hpFlzExRyzXcOXBA+1sSJvSUD9qzIpGvUaxe+RgllB8oyEWkPM4WD0RXpgg2ky997cspBOVYl82HrVnM/ywgTUtTj7Uxshnzl1HhnhScDZXvRu8fz509PQ/XxDIwtYfGbHom6Fc/KPOGsd1RPCleCnk00+mN2UF+Jv9Xsz8PyYMsZHQXIOMVMkI2X0jtk7dI0Dvx1K2/jWTw9x4ItwebGYQlW/J09rOV8zwaEYFKe8sSOZxwJF2cD9tUjLRv7FpfTdxICe6CzUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHTyb712BTkyE7HVbWJ61+fEPE5VJpii4Gx8h9X8Cew=; b=WbN0QU5Kx0zxZnas9d7wy1Sbun32Dy78jzo6fe+AN/qoN/aIGtoH+W2ZDvYQm6dKk01pKoZXENCZGGEstmUuTm9jHz0d9GV8n11zuCUoEzqHCex5+N4XA3Mfp1UMCWn32E9bJjv+f1Lh1DdCsuemnnGQ78/LBaK+rlXCZ1McV8EWNL6rep0GVek48uYn5Iaud9usF54MHKHLN8buF6Z7cQnE25OG5Cpxcgj43Utdns2nv3HxQDCrHcbf4s5sIosBoV2yBABxPJoAavYmFnpdgnLZlq1AOIQ/xCAAvQtAeJB4kr1Tb+uPFd3e95hZKb2IfCXI0f+604wWkWpK9mrEsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHTyb712BTkyE7HVbWJ61+fEPE5VJpii4Gx8h9X8Cew=; b=WDQh4sLnIrIvuTj3BCqBLI/7pAsRVsm6E3bCuQLR2buQTvFlwK0SbzO0kyAJtbj0uWN65G2VPOLsR8sRih8CBWFmjnQjCmyD2fGz7PQKrTSeVMHBGMDTzVuufQiSMBSHgQaAUCANJDfLrAUL2vWTvrzKcW3QGbi016MKvWg/YmMnjpflqHMo8vA+PtFh96m+Bq8yp0U+FduZfXpKcZynNnmXqEq7xOC4g+XUKna1tju5Lc9R1FONuCefktG2MNES0ebJjB7gmEX3o2NmOApMwW3rnJVgcEF5RFAam+7Bwaa6xBc8zFbrhblTxGO5/iF4BMkByXMM5yz9oqydPpyt8Q== Received: from DM3PR14CA0131.namprd14.prod.outlook.com (2603:10b6:0:53::15) by DM6PR12MB3609.namprd12.prod.outlook.com (2603:10b6:5:118::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:18:57 +0000 Received: from DM6NAM11FT046.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::bd) by DM3PR14CA0131.outlook.office365.com (2603:10b6:0:53::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT046.mail.protection.outlook.com (10.13.172.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:56 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:55 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:04:03 +0800 Message-ID: <20210611230433.8208-149-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5c31fee-19aa-4fbf-d0dc-08d92d2f4992 X-MS-TrafficTypeDiagnostic: DM6PR12MB3609: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d+5efT2/4tLvf2bC+9lqQ7vGAy4y1c3Lzf19sfJx8kXl4yZo5k7MWBflE9kXLYjTmipvlX0Mjw8gZd86i59KlF2FfQg3GCWyGSJun1SHqdwzeUtwt/kyUOBvXyH1TNFh5WvbE/nilk2EkMZRe+Aply+cztOftWRmWJEYdsuBtqR+rnRofBTD5fYghs7Kz2EjwVLsRGOGwsnJ4qf+wgPaWoKEGrutBrRbw9IOxKwxAHB8AYukEMYRnfOeyr8LyHvmsI9dNJVl9JUEQCahCiDkhAelPg1iUYAE3UuzaU/B65CgDSzUx8OIGq6igsitpfupiO9J+fo9xxnpAJRb5NhxqfveiuZoQ1gl13i/9aXHT7Ilz6OTCV9Tz+OTbhjwHyLGw6u3OHKFnOMGCY4oKLgfsI5ZHHfGqJOvFE0QjDJZBj3m6/NvlGqJR5N5zRVSthnOAq0cLtnA+J3qZjjbowhqfnGWl1VSYm6EkEfMEEjSrjPspEODtJgFsuBr8hjXON4L3bANhAje4Yf0RqgVawiGgJ4gInIu6kvPW5vHiQ54oLSTyHQYFQ81tlJShQx1TqhbfTefGuy3EkvyOZ61+wkbuQS/aCGqRlJhOrz40Q/RcwUKXv09+pIUCgvTOOGr4e0ky6yiKN3e7dgsSLmBX/Tzh5pMzb3U9hLMqu9eKHpGRkQikWQJaS3Ck0DNUr6A/DMbNB6hk3n1lX1IbnGQWWm0JfOZyDKVlGzxDxame/jKZIXi5BReZQCOns+ORWB5k37w17ZrDxXBvTCGqPUoO3HkY9+PkOb55GG1S+3OowCJGgblXE1IPqweIl2wD/oRHMhf X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(46966006)(36840700001)(36756003)(426003)(82310400003)(478600001)(83380400001)(8936002)(53546011)(36906005)(6666004)(55016002)(8676002)(70206006)(356005)(86362001)(966005)(7696005)(7636003)(336012)(70586007)(36860700001)(4326008)(5660300002)(16526019)(2906002)(6916009)(82740400003)(2616005)(26005)(1076003)(316002)(54906003)(186003)(47076005)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:56.9577 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5c31fee-19aa-4fbf-d0dc-08d92d2f4992 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3609 Subject: [dpdk-stable] patch 'examples/l2fwd-cat: fix NUMA check of port and core' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/12822e56a0974fd57d36496d0b60570374063c2a Thanks. Xueming Li --- >From 12822e56a0974fd57d36496d0b60570374063c2a Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 29 Apr 2021 08:50:47 +0800 Subject: [PATCH] examples/l2fwd-cat: fix NUMA check of port and core Cc: Luca Boccassi [ upstream commit 59a50c6a9ace0dc736d71e75267a1cc2127e7938 ] According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. This patch fixes the check for a device on the node 0. Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS CAT and CDP") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- examples/l2fwd-cat/l2fwd-cat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-cat/l2fwd-cat.c b/examples/l2fwd-cat/l2fwd-cat.c index 02288a3824..8e7eb32485 100644 --- a/examples/l2fwd-cat/l2fwd-cat.c +++ b/examples/l2fwd-cat/l2fwd-cat.c @@ -107,7 +107,7 @@ lcore_main(void) * for best performance. */ RTE_ETH_FOREACH_DEV(port) - if (rte_eth_dev_socket_id(port) > 0 && + if (rte_eth_dev_socket_id(port) >= 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) printf("WARNING, port %u is on remote NUMA node to " -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.361380400 +0800 +++ 0149-examples-l2fwd-cat-fix-NUMA-check-of-port-and-core.patch 2021-06-12 06:53:56.610000000 +0800 @@ -1 +1 @@ -From 59a50c6a9ace0dc736d71e75267a1cc2127e7938 Mon Sep 17 00:00:00 2001 +From 12822e56a0974fd57d36496d0b60570374063c2a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 59a50c6a9ace0dc736d71e75267a1cc2127e7938 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org