From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D10FA0C3F for ; Sat, 12 Jun 2021 01:19:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 777F940691; Sat, 12 Jun 2021 01:19:01 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by mails.dpdk.org (Postfix) with ESMTP id 5B0AC40DDB for ; Sat, 12 Jun 2021 01:19:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVIAQtKh3TWijdoiaxS5lYieqGtKuDAg9Tx4vnj+TskU0txJF1eLaHvHFnmIKStxXiqyTvB86XzfrsNEM4hbiwCSZr0T4g7vGPwKNk0zYfpqgfAOEMKr5SgEd+C3QnDVjTNcQUA0xchwQiAVZ7MTQxFXPQCi8F7gaX8dkCv5xY0INeGpA0gJ3F+NjOHPFBEaAFT8WoveTsW1uCVjnUHZpoVfoIlvvs09+h599ixqRANg0cKPzF/D5G+aZ/WTl6uq8+1pu47vAZoO9mQ/tLYVUIZgzfvSyrswI7JPlOwhjUw9mw0zjlHLnKPIWYskb9HBFcdM9eYP6c2ZQvikSQRekQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8fT3ous3MGxuSp++R+KA6x5y2ZGzMiZ6HNcompOtvXU=; b=FmMTGNPK+GmGYsgb/UdpOtUQJ36PaOU2Y/Z1czD/+tgv12ykTj5QWgwDb/2AiSDo5mn2fGUUV4fc10kwa2/ZvWex9rZ9MSiWdywgM34GuseQ6eR4RTEkqFFzA+Mm8xmlvhti3Lh7LfNAEENe0Vp7WG4tSi1Ox4cGNGCg1oaRjLrBgLrmmdPDOh1rN0pwGBRPREpeuab3XGSHYmfeENvSVCeLfCfQWB9LdyyrHAAzvm1xNE3NP1lTt1gBCmTgB99YjUQxANQkYBQF6qyy2cIZuYWCrweayC15Pzgr2pE2TsxnnQ1U0AEC1eDRuePU3shcuNc8qz7GwV9Pmkr5SnHD0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8fT3ous3MGxuSp++R+KA6x5y2ZGzMiZ6HNcompOtvXU=; b=SR5kaOSrODvGQdTbZwapngeWTGrdTnC38eMRJYZn65QZorukjX0sC8iPCQNkZJ9Gl3DDTIbH0Bc14QM1/q8IVxs+/mtkWMliSPQyESTtcDvjZOxhsZQ4tg/RfQiKj1TmHrtsTHnS6whaVFPpw8rmOR/Wjy/IBHEHKHL9tTUP/OLvZ3gvjx1arJAq1CR6TcBGsQRjpOLf0XgRbplfKKWGfmvSOSm9iKiw5efZLQiSc2OeCVFRWY13MatD+xtVYj4MyqnOB7FQG56bC1udyyWxc/QXrZ8OlIBFC28YFgy081WmRgKBtI9NO5QjjvJP+wcucIfwws7GpPFu+xMMVs7Dkg== Received: from DM5PR19CA0033.namprd19.prod.outlook.com (2603:10b6:3:9a::19) by CH2PR12MB4840.namprd12.prod.outlook.com (2603:10b6:610:c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:18:59 +0000 Received: from DM6NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:3:9a:cafe::7) by DM5PR19CA0033.outlook.office365.com (2603:10b6:3:9a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT063.mail.protection.outlook.com (10.13.172.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:58 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:56 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:04:04 +0800 Message-ID: <20210611230433.8208-150-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fdfb2f2-0096-439c-be4c-08d92d2f4ac4 X-MS-TrafficTypeDiagnostic: CH2PR12MB4840: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uVCAqfM/w6JJhtmLo/5QhBGIVg2dHfWTgxpTOUPDZMSLiFv8ej6cT0Gnf22Qp8cyYOebDzso3kqZOBmdGmMfXILo6JAOkhb5Yy/OI+CRNtRmWrofx6uCywnn6Nu/jvW2I/ECUafW0qC5E/Z0RoQeaqNTdVxqqtn/4nQDX1k8ug3jpsuRKunKlsYbFBzyu7LIgLfTZuApmGrW7cggwNCQmgjgr2YVBjETBao/MH31qFW1GJIY/B2it0eHRd1pUrRRBJ9r5NzTakA4upwZIRIpZomqZ1ySjpl1kzS01oRzbVVLPFzZAJ2yhgHoCR6LGt2GUCFnHKbk89oonVrwTMtTSaLTXDobRMMWbRfZIXds60HUO6Y0tcyjy2CvE/in3PxIXJCb8I0ybtuT8pxAtNNuU00RWqaP1gsnT7GR+ziO077+etebs/MQqAx3UPQ/m0srdD61RqhgXw4KdSfPsHPmixmFzTipoOM7p3HDokwdteS7MjZBDGMXIQ8IAmXPX2Xwc5O11AZj2mYCOouYAbF4tnVsB4ZTPm1EjcJx8VoFIBfALvO2cxJTsAaJM9By8zLhRf0/JQKfC5rpgUxzcWxn7Ia4SdM2hm6EVNuDm9VD/w6eeF/wFcdjBS0aB0GcMF3BYDfKY8iqWe52KuxU87cGlOjDxFfCtYNU0pYrKoAiLVQb6osNvbu5yFpWBn8binY/IPpf/yJHKlWfU312MiYsc3fT4m2dHC0x0caRLmgYUA31AYIf9BDIFL9p4n528qGVxtWtD7nZKDg0GJxUGNajVPynCo9Hyl3UcJgXuasiD/+WSob03hm+WgNHIs+pPnlD X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(6916009)(5660300002)(36756003)(16526019)(36860700001)(8936002)(478600001)(2616005)(47076005)(7636003)(186003)(82740400003)(316002)(6286002)(7696005)(54906003)(356005)(966005)(86362001)(26005)(36906005)(426003)(83380400001)(6666004)(70586007)(55016002)(336012)(8676002)(70206006)(53546011)(82310400003)(4326008)(2906002)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:58.9597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fdfb2f2-0096-439c-be4c-08d92d2f4ac4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4840 Subject: [dpdk-stable] patch 'examples/skeleton: fix NUMA check of port and core' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/acf64e968541c95f31185d09d537639b4e647ff9 Thanks. Xueming Li --- >From acf64e968541c95f31185d09d537639b4e647ff9 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 29 Apr 2021 08:50:48 +0800 Subject: [PATCH] examples/skeleton: fix NUMA check of port and core Cc: Luca Boccassi [ upstream commit 5ffa60cd77c76855690d06cb900d6670f29de9a6 ] According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. This patch fixes the check for a device on the node 0. Fixes: 7107e471a6c7 ("examples/skeleton: very simple code for packet forwarding") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- examples/skeleton/basicfwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c index a31b2882ae..43b9d17a3c 100644 --- a/examples/skeleton/basicfwd.c +++ b/examples/skeleton/basicfwd.c @@ -122,7 +122,7 @@ lcore_main(void) * for best performance. */ RTE_ETH_FOREACH_DEV(port) - if (rte_eth_dev_socket_id(port) > 0 && + if (rte_eth_dev_socket_id(port) >= 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) printf("WARNING, port %u is on remote NUMA node to " -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.381594200 +0800 +++ 0150-examples-skeleton-fix-NUMA-check-of-port-and-core.patch 2021-06-12 06:53:56.610000000 +0800 @@ -1 +1 @@ -From 5ffa60cd77c76855690d06cb900d6670f29de9a6 Mon Sep 17 00:00:00 2001 +From acf64e968541c95f31185d09d537639b4e647ff9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 5ffa60cd77c76855690d06cb900d6670f29de9a6 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org