From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34E6BA0C3F for ; Sat, 12 Jun 2021 01:20:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 279A64003F; Sat, 12 Jun 2021 01:20:45 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061.outbound.protection.outlook.com [40.107.244.61]) by mails.dpdk.org (Postfix) with ESMTP id 579BD4003F for ; Sat, 12 Jun 2021 01:20:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dn/dHkcXxvpu4Og40kqssdIdv1agBVEe5oMDhtg01l/HP2S8qDKKP4xVHSZIoq20vB2htfmy6G0Ws6AVZGQKJmxukfqhYisVbFtg9W5pCe+be4sMj8e0AD9aTN//CvbTltZmTcOWHqG74Ha67UtLkvSnUA69c/rhdrYaulcGjsDPtkByYupFkeo5eHECsR3ObBIWQuLNEGo1xkGxi9MuiMQsu2ZHxX5Y3X2yBTP9dd8kZO939vvnVPhizLYk6L1ONN7eY1pR9jvhG7FoYkBi+E0b/46SxkcU/EboS6bau/rnOaxo0eujFlmot4R9ivi+VGz7P8iPvMSXIwO+U3v+yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVu/1uZCmbKi3zf+ug1VPeadGRTnoQ+/OTP8rtKF8Lo=; b=mV5h4VBNqvRutycdMY03mvIig6OdwkL9QspZMjz9PKlorQ+A7mpsXw3BYl7AZ1mWqd64mR7rEOBf7KzCnMHOLTGBCtfmO93g3EEAxPNYdMSsxdcxjce1eA/0k04kMf6NsgMhGMiywcfhHQgFUUvLanE0LXCNGS5cZq0Z6U5NupzI5hrTQ1Rn4RfsBE8LCWAUFCRGHmrqvsqIT1KtuA4y/NA4sFhqvUZaeA3Fq0j5PNjq+k6jUNgCciFw0/aWIZo44kWhjuTJL6WZviCveoIjOGuqzv4iePcd3U8x8UlEojOhsXDj52ri6E+AKT2ZVmo01GM5xpa0g3eBY5F2/geySg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVu/1uZCmbKi3zf+ug1VPeadGRTnoQ+/OTP8rtKF8Lo=; b=pDfbfWoU/jFLmhYZQ6H6SARAswNoFp6VBq7VfgbGECLbS7HZKO5mX7blCFcRfKua84e9IENoK91S4SKu1Hi3XgDT+jFBouPvFp+NiaPEGt/jd8Cx0bMP93IHp8+T8WEx44EQwfgejxRtqm4t0GlTe/cIW1oB5LeIHqaUmYl91O51EQjcmRtwYYXo9QokCJnQxpFBcmg4IK0eRvp2qfk2ajcat+1gaM2UeO1FFDhuMkBxs4sc1L7iwDRYTX9xMvGSWubtVz/jfud6LKibe46pj701kPIwZnQJlOPvZA5qLtR25g5e063nG9bWuFk8NCstRZn10tBibAm0kIIkyo8eFA== Received: from DM6PR10CA0002.namprd10.prod.outlook.com (2603:10b6:5:60::15) by MWHPR12MB1245.namprd12.prod.outlook.com (2603:10b6:300:13::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Fri, 11 Jun 2021 23:20:41 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:5:60:cafe::8f) by DM6PR10CA0002.outlook.office365.com (2603:10b6:5:60::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:20:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:20:41 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:20:39 +0000 From: Xueming Li To: Matan Azrad CC: Luca Boccassi , Eli Britstein , "Chenbo Xia" , dpdk stable Date: Sat, 12 Jun 2021 07:04:20 +0800 Message-ID: <20210611230433.8208-166-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8f2b79e-c1c5-4131-d460-08d92d2f87cf X-MS-TrafficTypeDiagnostic: MWHPR12MB1245: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: umjKtTmiDC6+wXUmLDTEbCgKc6M2X8SFjjWMB2zTQBisnsipl64CUhk6kkN/WCdld0rKgXSRA8pl01yN1NyYvKTcmf/fU7Zkdbzq2PZBLaPkOHEkZ9LfnvV9mJM74c5k85MEHOiJtzSOob3sCY8BlLT3fspRcY+zZcd8b/CmceerJ7YhGSAv2ko1pm+YhIibAA1daAJrSBSx/rBBAkAcqYHlvr0+T/PjuH4VpwYJfxngHpYH6x4fP5dvTcvDQeMwTt1prWYWJIfQnM/z2MrcvQWu0v0is24WnLA/p822Pk1YLBsASd3yusoQh2gY24HRe+6YXThOFdqfWMVMcxx5IousAVJ6vZVtB1QfArJrWiEZEmysMT1xwOcdNKUwVDr2kWDFbT6DuXfYUEDBRqiS/neeU+e4uyYhXExaeYQ/3DEQ9RNNF7z/AKp6H118IBMNSyQmno4Z3+Nyq00fVcttcFKfizUnwDNUwNoz10APMbJgoLHWln7znLWPfXx9dyJUFpGwCEqpWQ5VJQpca2he8uFa9h0YWHVwzs4jOoxJnORlh6uzALn8xU8IE4VgneWnjinInr6SHRvaQRA3pGct4aq9OwV6pYWaaw7jhAFqnBDwfkFWYLLutjuAHqc5uRE50MAP2TwzpT4Xc8QENmzimpIpkYyxYy+XAKz+o4E7789QcFyf4lHhiCPgxO3mAYU1IX8+DG6Ud184gnpXgG6gFhLqWbxAe9sCVfilCt9vaAHzsZzAYWBGOuDQu/RrC5Qi4z8AKvEkpT4SHkIECR20mBEdvgn+gBYiz4NbXmYD31mAvyc3HOsRDYliZWl6BXmX X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(39860400002)(136003)(36840700001)(46966006)(7636003)(356005)(966005)(478600001)(83380400001)(36756003)(4326008)(82740400003)(5660300002)(47076005)(86362001)(82310400003)(186003)(16526019)(6286002)(6862004)(55016002)(37006003)(316002)(36906005)(54906003)(7696005)(26005)(53546011)(6666004)(1076003)(8676002)(70586007)(8936002)(70206006)(2616005)(336012)(2906002)(36860700001)(6636002)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:20:41.3763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8f2b79e-c1c5-4131-d460-08d92d2f87cf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1245 Subject: [dpdk-stable] patch 'vdpa/mlx5: fix device unplug' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/a6967ee4a8cb1be554f2ff9d3c9ba794eef16aee Thanks. Xueming Li --- >From a6967ee4a8cb1be554f2ff9d3c9ba794eef16aee Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 13 May 2021 21:40:20 +0300 Subject: [PATCH] vdpa/mlx5: fix device unplug Cc: Luca Boccassi [ upstream commit 2838aa76ba94e0dd7712e57fe6a32651f5690797 ] The vDPA PCI device unplug process should release all the private device resources and also to unregister the device. The device unregistration was missed what remained the device data invalid in the rte_vhost library. Unregister the device in unplug process via the remove operation. Fixes: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver") Reported-by: Eli Britstein Signed-off-by: Matan Azrad Tested-by: Eli Britstein Acked-by: Xueming Li Reviewed-by: Chenbo Xia --- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 228f5f59d2..6029cfc3a8 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -805,6 +805,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) mlx5_glue->dv_free_var(priv->var); priv->var = NULL; } + if (priv->vdev) + rte_vdpa_unregister_device(priv->vdev); mlx5_glue->close_device(priv->ctx); pthread_mutex_destroy(&priv->vq_config_lock); rte_free(priv); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.749240000 +0800 +++ 0166-vdpa-mlx5-fix-device-unplug.patch 2021-06-12 06:53:56.650000000 +0800 @@ -1 +1 @@ -From 2838aa76ba94e0dd7712e57fe6a32651f5690797 Mon Sep 17 00:00:00 2001 +From a6967ee4a8cb1be554f2ff9d3c9ba794eef16aee Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 2838aa76ba94e0dd7712e57fe6a32651f5690797 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -27 +29 @@ -index 40db28b6db..e5e03e6582 100644 +index 228f5f59d2..6029cfc3a8 100644 @@ -30 +32 @@ -@@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) +@@ -805,6 +805,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev)