From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A04A0C3F for ; Sat, 12 Jun 2021 01:06:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E295A4003F; Sat, 12 Jun 2021 01:06:58 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2063.outbound.protection.outlook.com [40.107.95.63]) by mails.dpdk.org (Postfix) with ESMTP id BDE294003F for ; Sat, 12 Jun 2021 01:06:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUGAw/XQvSkMLOs/vHLwC3Y1AsT/Kykv0/ThgrYF5K7kx9ME8g0eZtBQU+LKc0BAH6q4ZfPLhTWN5QFcwf0fEIiccy8Q7tZhbH9krdiU5vzWU+BZuzPOikR7UT+zypNK7+DtNEVMIBtwlON6S81WMYMLgwg0GIzHo0xP4N2GcG6DNCe5TXRhuu0ZBbLYndlXNyBbMqquD3A+DY6Cjl4Gr/4WRALmmHFFa7i07XdtmIGa5+M60R1ybzirweTkW9YMm8ujzrFzgQdz1y+RJKHZZJYCC0dp7DJghl0cecnWz27EcbddytDcgKS9922/jNiRpK0jv6CvoN6APeQ4OmdcnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJPTzyPbm2eM+/DF3U49eA+JM4ps+vJk3Lpj7h9KuF8=; b=jsubLLFX4RJin8AqUW7D6C7gsv7cVA3C+uTfSvkmLE234gq8PnFE1I/8/GbAU+jSkhNjd5NVwzDNPdiDDPtw+Uw8GOcFqLjy9PYxaOADiAKg6xFuiUw40pEKMNxUNgErVDDOOzm+mifUJ2TDoNvpOSKLUsGrj32UKsSMRfVkUSzDFQfYhb1pvjt+MFDNJos5rpkYAT8TX1i6oQ7eVpIXS7tG9vPhnxXEBMIHk5i8FKmNBMGTjjloyYftGb7t1UcFCDWftlq0vpz2TTtqs9sKGsX2T+/5bFEzx1wPNtLtTztoa2s2SzsUoDeByx2eLjmwqVZGkZW34akdCwblDrcASQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJPTzyPbm2eM+/DF3U49eA+JM4ps+vJk3Lpj7h9KuF8=; b=p54AQUF/0SFKESsOlJm77CrUkA38RZHdnpweTvGcxv0tBW2Q1qxUnfVBEDjHTa1dj/9pbLhoE0bm8RZwmGTav4aigXK7WuguRkjMMi30Rz01KiNlU3Gv+ECCPzL82zH/iic1V1BQXGLAE0DpkX9u60/68lU/ZjkDo3P04LxraLwH+Qgf10gPNwV95gbAlGcADyBWK9A/6H+Q63efKtYyr+u5MOAvJsAqoWV0OGIL5ZSVH6iCpNQS/CXWXZ0AUmxRFCCLm8p+1fcBA7CAfehOfOsA3CRBIY4mmpMQLQh8jwi1JK2sNCfdQpxdQ6Y6BHKaceJQAazyV0huA89TtARYFg== Received: from MW4PR04CA0077.namprd04.prod.outlook.com (2603:10b6:303:6b::22) by CY4PR12MB1942.namprd12.prod.outlook.com (2603:10b6:903:128::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Fri, 11 Jun 2021 23:06:56 +0000 Received: from CO1NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::b5) by MW4PR04CA0077.outlook.office365.com (2603:10b6:303:6b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24 via Frontend Transport; Fri, 11 Jun 2021 23:06:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT047.mail.protection.outlook.com (10.13.174.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:06:56 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:06:53 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:01:55 +0800 Message-ID: <20210611230433.8208-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1f58b32-1122-4c1a-11c8-08d92d2d9bf7 X-MS-TrafficTypeDiagnostic: CY4PR12MB1942: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mci3ylkob+a4h68GkJFXvFdfBOdVDhoKhV0T98y5ltVRJjUGGNeZ7mbt3rU1VNii9DqEW1GMV2AB88ESEDNttAHkCgPpeF/qHUuziYAeYeh9x1Gv8pwn0Zv8RbH9l0EHpVdjRk7/8x9XBhBiGZY41j2ir0W3oQBABDBFyEgJaIRJ6fAIkqVgS7WupGFShbldCW55x8a3HMHujDbPTpUqLM8xxn8UozN703auPkBC1zDMckeDN0A6qJCIEgQ7oubsDUzBqd8P0P+BzZlVCxJhV2SaMFuskmHDOBtpjJTlYy7KGGmRjlVoiT7knmpH9c3ZpVxWkFuPhAmCIVGbTIJrq6GU6LsVPQhpVaiCJbLgemfIVBePYrFS2Ki4ncR89SWels7zpDwzbZIImI6phBQPFu5v+aZOqpYmz9gjeDFFui6oMcEDpNwGDkGqHjSNRxhqTeA1zay2f48izkmywiEGCZvTNddiHyUpeUBBUuy0HGuGesK36xJWUSIagHCvnkxfdT2YHd88S7cfCSFiV+DmFZQeDr7y2OtLDdT9RK2emhzvcBpZziNJ8/v+BCh4plR4lFghROQMeBJVaQa9eYEJncWFIivVhxqaSRW/dcuRz74CZ2Obuujzn3/AI6tYCZd1EZxAMN5Zj3xtIktBQWvf972zYye/McGgrHzA4ELdLGROmoMnyDLJuKqWE4TZfT1YWKqsB580FEm6fIFm1GNDglEos2INPY57mY6Gn8hHXi+CeNZwI9tGnEq9/9sG5R0XfO92yMb95Q5IH0TD/qiYOs/vYPFfhm+D2a4iwqIEMT8lyiX1lBjXSG7SOEUUlNB5 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(46966006)(36840700001)(2616005)(4326008)(426003)(2906002)(54906003)(6916009)(966005)(356005)(82310400003)(478600001)(86362001)(47076005)(7696005)(82740400003)(6286002)(1076003)(16526019)(7636003)(83380400001)(53546011)(26005)(36906005)(8676002)(70586007)(5660300002)(316002)(70206006)(55016002)(186003)(8936002)(36756003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:06:56.1925 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1f58b32-1122-4c1a-11c8-08d92d2d9bf7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1942 Subject: [dpdk-stable] patch 'test/kni: check init result' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/eaee68d852780572cd74cfdc5e4707fc482a022f Thanks. Xueming Li --- >From eaee68d852780572cd74cfdc5e4707fc482a022f Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 11:56:29 +0800 Subject: [PATCH] test/kni: check init result Cc: Luca Boccassi [ upstream commit 381dfcf04717f92cfea68e53aac1979c098d35a4 ] Return value 'rte_kni_init' of a function is not checked. If it fails, error handling (logging and return) should be done. This patch fixed it. Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- app/test/test_kni.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test/test_kni.c b/app/test/test_kni.c index 3470005790..96733554b6 100644 --- a/app/test/test_kni.c +++ b/app/test/test_kni.c @@ -563,7 +563,11 @@ test_kni(void) closedir(dir); /* Initialize KNI subsystem */ - rte_kni_init(KNI_TEST_MAX_PORTS); + ret = rte_kni_init(KNI_TEST_MAX_PORTS); + if (ret < 0) { + printf("fail to initialize KNI subsystem\n"); + return -1; + } if (test_kni_allocate_lcores() < 0) { printf("No enough lcores for kni processing\n"); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.243165300 +0800 +++ 0021-test-kni-check-init-result.patch 2021-06-12 06:53:56.100000000 +0800 @@ -1 +1 @@ -From 381dfcf04717f92cfea68e53aac1979c098d35a4 Mon Sep 17 00:00:00 2001 +From eaee68d852780572cd74cfdc5e4707fc482a022f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 381dfcf04717f92cfea68e53aac1979c098d35a4 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org