From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 001A9A0C3F for ; Sat, 12 Jun 2021 01:09:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDEA240DDB; Sat, 12 Jun 2021 01:09:00 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2042.outbound.protection.outlook.com [40.107.237.42]) by mails.dpdk.org (Postfix) with ESMTP id A41E540DDB for ; Sat, 12 Jun 2021 01:08:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RerXPIqpwsICk8q76BacpprjP7XsVPUQpMwMdKaElX3++p27NZW7ZHDVHu35FGv2a+/KBYIStCm8zm4GJ5dTnJw2MrFFKNv68P+QjeplUIs89Svua6llKxj0m5sovsuuKO/zbYyNXV/eGwu3oNDlvI1oAht/gelcPXem2H91WKxqCYdNtTDBu+4T7zLU3Pzd1UPTjXA4hgcirSWd7sVEg+dsXfklH1YFy6aU8LVEfeQb1bTXe/usZ4gYLAY0QFuHw7+Hn4WlzbFrU9k0o8M2+OrpMZRoPZUIWgE9dSaNOr42kcihpHlK+P2L3v24OlTzW49nyGRGcSZASoR9ugAI+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FPdYWiSUls+ZJqCDGRtOdUxqegcV/C4j8eShx4MAZr8=; b=VexUazITcuIKULRUECs3yBtSNmf5KUm7XwrJgyxcteG7QuEL9e/ZNB795dl+mtBhSOwcW0Ntg5g7ueWSZ+fTyw0v0KQSKB4sNzkbGbgSx1XnReoWhqEWZckgluGDOBF67OkwLq0QpddtuQ6dB2kenH//pre0lnosG134rsyFQFRHJm5p5mwA1ajH8pkUITgwujEyosY5E25Mrk+HLZW4WKN+d3oE4iaKAk4HEKXF4bZgCOBTHffXGPyZe+az9UPl/fHw4WRlbVaF8cGVzXGYTJgW4dpLe3zZYTLRici8r9ke6UiSXXafxpWMurzjc5NSYENqMHs2Tgq49cBpe4V9Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FPdYWiSUls+ZJqCDGRtOdUxqegcV/C4j8eShx4MAZr8=; b=mo+FbWExOW1SgqapQZeZVGgOkwo8HwBLc77GunKzWf9CCo2hpH62xacrKwDBkEvsQ1/EssTpNPcwn8xwhP83Fa4KPiWd5dHL3QDXQ9xu1epO+vQ1IL5wCsv3y6O16UNG3eNCgYOgRCYsRLZbrehROm2wBXlNmXda/jUskSNSQjUgep1gEGPCLInM/hl2qRpvU7xIRpPmVZMxxkqJuWOJT8Yd854e3ZiRJ0nJEp3m4sEvHWkVmsd8w97OOJTTPfkBdDSQRNru/zftFxGWVGTHXLGBFOA8I5p+11P4QCobtMuD3jTkF1RPwOPt7FgILMUOEeqvvoI8Oy+fi0q3UohRXg== Received: from MWHPR03CA0007.namprd03.prod.outlook.com (2603:10b6:300:117::17) by CY4PR12MB1448.namprd12.prod.outlook.com (2603:10b6:910:f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.23; Fri, 11 Jun 2021 23:08:58 +0000 Received: from CO1NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:300:117:cafe::54) by MWHPR03CA0007.outlook.office365.com (2603:10b6:300:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:08:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT065.mail.protection.outlook.com (10.13.174.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:08:57 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:08:56 +0000 From: Xueming Li To: Huisong Li CC: Luca Boccassi , Min Hu , dpdk stable Date: Sat, 12 Jun 2021 07:02:19 +0800 Message-ID: <20210611230433.8208-45-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9322465-ea30-412e-9977-08d92d2de45b X-MS-TrafficTypeDiagnostic: CY4PR12MB1448: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XiIogXn9IxRr0zKxWIWrPB2af/3+P8aS2+TWZDM0lczJU5T8t52mCG9sGY5jM1h5RPdSRiXPKy2bHP8vrHsSxfBIS1RHhlA3mscD0tvSkh7ophh6T1hYxC4zKFknnsaYGdz7mG0Zd8b12G0+mub54Q1sBb8/YOUnFrQX/gx/DNB4u62xcYlwk66g0WDOFFfmTCjJKvEAc2XLgUCA/nB/WUYAOSQl5qXx+JxXcPXciwn6deJAi1hqUa8VkGvtCF8B4BVQAbMahwWwlc9S03iQ6Teq+7QMmSMO6gUTt3KvKgNr4fPeKZRFXq5+QWM4bJFhs0cCklgeP7yKj+1cEfTkxR4cMf4GVIfi/ic3kz6qmokBlzPjsTOd6NgyV4OTK//PhGkf29lAB3iRh1nJ6PHB0j0s00GSC30qGPwAVe0yoH3Gx6rnww6bjY10ldJmz879vb48I20QJJT0Uo4lAlec7q7I7RlHr5CSNeW68CDZAY21UiL7PmmcI+i6n+EV+54Sj2dzkueUDhI029RSnYklD8KMOQN/0KbnyXfZ0MTBH/H2ZDxz/7+1ae0kHegx2bBhmDvzHggBuh6hRN2sIvXsN7fGywgIFRl/MQrxpcGbW5SsaRA6gTKvW6XG0Fjta78Yrhel/WFGC7wpGcVi3tVkfMGlgKac6qdZp5vUg2FbeYAXainwLbuNnrAvOy7I7GiGGsLP8qiWZCRx1dqcQXqm35kdabKxNiMkl/fxgT2uDeRm3aKcCRzkbMPR4RgzbpPzQHFXnd2Mq/ux1bWWmYycAXWYrE4wluZsag8m5Bt58ggXXzdtI6hTrEBUId29zKuk X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(36840700001)(46966006)(478600001)(316002)(53546011)(82740400003)(356005)(2906002)(16526019)(86362001)(36906005)(7636003)(966005)(26005)(70206006)(54906003)(6666004)(2616005)(55016002)(70586007)(426003)(83380400001)(186003)(336012)(1076003)(8676002)(82310400003)(36756003)(47076005)(4326008)(6916009)(6286002)(8936002)(7696005)(36860700001)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:08:57.6602 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9322465-ea30-412e-9977-08d92d2de45b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1448 Subject: [dpdk-stable] patch 'net/hns3: fix link status when port is stopped' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/3502d412a050f848da6c946f605a5362fe48decc Thanks. Xueming Li --- >From 3502d412a050f848da6c946f605a5362fe48decc Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Sun, 25 Apr 2021 20:06:28 +0800 Subject: [PATCH] net/hns3: fix link status when port is stopped Cc: Luca Boccassi [ upstream commit 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 ] When port is stopped, link down should be reported to user. For HNS3 PF driver, link status comes from link status of hardware. If the port supports NCSI feature, hardware MAC will not be disabled. At this case, even if the port is stopped, the link status is still Up. So driver should set link down when the port is stopped. Fixes: 59fad0f32135 ("net/hns3: support link update operation") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 8e4692385d..01ff8de7f7 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -2709,6 +2709,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, struct rte_eth_link new_link; int ret; + /* When port is stopped, report link down. */ + if (eth_dev->data->dev_started == 0) { + new_link.link_autoneg = mac->link_autoneg; + new_link.link_duplex = mac->link_duplex; + new_link.link_speed = ETH_SPEED_NUM_NONE; + new_link.link_status = ETH_LINK_DOWN; + goto out; + } + ret = hns3_update_port_link_info(eth_dev); if (ret) { mac->link_status = ETH_LINK_DOWN; @@ -2718,6 +2727,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, memset(&new_link, 0, sizeof(new_link)); hns3_setup_linkstatus(eth_dev, &new_link); +out: return rte_eth_linkstatus_set(eth_dev, &new_link); } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.814085000 +0800 +++ 0045-net-hns3-fix-link-status-when-port-is-stopped.patch 2021-06-12 06:53:56.220000000 +0800 @@ -1 +1 @@ -From 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 Mon Sep 17 00:00:00 2001 +From 3502d412a050f848da6c946f605a5362fe48decc Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index e3f1b7c3ad..63ae555c9d 100644 +index 8e4692385d..01ff8de7f7 100644 @@ -25 +27 @@ -@@ -2897,6 +2897,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) +@@ -2709,6 +2709,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, @@ -38,4 +40,4 @@ - do { - ret = hns3_update_port_link_info(eth_dev); - if (ret) { -@@ -2914,6 +2923,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) + ret = hns3_update_port_link_info(eth_dev); + if (ret) { + mac->link_status = ETH_LINK_DOWN; +@@ -2718,6 +2727,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,