From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 396DEA0C3F for ; Sat, 12 Jun 2021 01:09:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EF8D4003F; Sat, 12 Jun 2021 01:09:22 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by mails.dpdk.org (Postfix) with ESMTP id EBA724003F for ; Sat, 12 Jun 2021 01:09:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMTmbji0QawEsjgc83iymHGlPI4aCnh4BH8dQkv8YFtXjLbw+3lz8kfECsLnmZ2ohtSDItoRmbghg/RCWB7jggdL7HLqK0r/0frvp2Mgv8rbDLFN+r4AQESzAoOB7B9vfv373S4gF7o/Eusx22Jh1+CfTVrNpAqDwX5XxNR9e29T06x2Fbv007imcWxLQ7aZ+ycU8g6KFAaV075+cwhjXUY7decWH9ZDfe1Z+1mq7uIM/xptxisAin37/JI4hz2+nx3Ulm8yqthSc6/bpSMjAZ0m8N3oAhavBnGt7HVxk6s3YsFm3NlauMf68WOQFFmAi422clJQTJa8CP+lCgxvEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eO9duI3Gv3nT3Ih+mzmA7QAkRmWah9wHFQCQVx1cYwA=; b=cwqJX0JlWwLToVU4p91AAA4rNOl0UkPHKyB9me/iUyxFjhwApl28NuurlJ+qam8JnLnxvJXDKLNQd/bRPmT2/Bn0hnEQ5a3ULlVKi0abCxBH86hgEOV9t34H2QDxnUU1/smzR/s7nH4gFhhD0IIL76yMt8iN+lg2dmQtutz0tGYQB3jlBsE7c0oIKTv9FXCjPlo6NnF/Yb8WOolCGFp6i01Tud/YcfECLXXdVPuV1YB0tJm3tiOV/3VeI63LlZdp2bygIMsDAoobiSYwAsoemBi/U7ydURGlQy7vtm0tB5kS5CLpBqduQmLVvQ4xWtUJD1O48qwj3QF03jdKCNL4WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eO9duI3Gv3nT3Ih+mzmA7QAkRmWah9wHFQCQVx1cYwA=; b=NrFMemp4BU9rrieI5F1vRagBCpjanosFx2kfyZ4w6UFzpkxJ6q2OiVKoi/vZQ0gWYC5vKnQ3E74ipSNnDgXl07Q0PusMwOIqd1fE8aF6eWluOHd4vLCe/FwGskzeMpJ6utEuIGJnvDBbkbusHVSIFgJfsh89YT/ryoR9bL0FrqGa65JiFmeJuW1cvtis/GmJszVxAkLF4IIOvyDcZZQMePGkmOcOIox9vyyg0lF3qWKnD9GO5O3uuLiLMeHOI9qz8B8mZZLpw5o8hKy5QYfQ3eMXhA/I+wsG+aZ8gZXAKFniqAzfcklAf+9rNSTqJUFkVjAuMjU4BkKuPE2IGU99BQ== Received: from MWHPR2201CA0050.namprd22.prod.outlook.com (2603:10b6:301:16::24) by BYAPR12MB2648.namprd12.prod.outlook.com (2603:10b6:a03:69::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:09:18 +0000 Received: from CO1NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:301:16:cafe::c8) by MWHPR2201CA0050.outlook.office365.com (2603:10b6:301:16::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:09:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT053.mail.protection.outlook.com (10.13.175.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:09:17 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:09:15 +0000 From: Xueming Li To: Huisong Li CC: Luca Boccassi , Min Hu , dpdk stable Date: Sat, 12 Jun 2021 07:02:20 +0800 Message-ID: <20210611230433.8208-46-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24fbd638-700d-4e45-d338-08d92d2df057 X-MS-TrafficTypeDiagnostic: BYAPR12MB2648: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MmkuwxkFvPDkKsXC61WJP4uSLMMKiiijgzQyZhYnJB5HqUgNh2c01g0VzznT1X1BYefAL+AS6CvpMu0GyHP6k5I8/JiTv8vbDjD4VMH8oPY3bIDi3QzFQEF/b8Ig+Wo3bnz/qOkK5fU/RSstVyJU4vCDzhXwJBJHKjE/3GSTMNCl+9V2OAHT7cRzdxRPAH2xVazwjAgawpq46TDuAVnv+wzQfs6LGEwftg9ND46q4x3zm+PizTLcS8Ehi4VfJLEAW8L24zfw5We3IBaur7TxojIlKESNHNw93/6bV3LXyXSHprlOyyJBSsOqd2s4LMq/2FMUiDA7CxjG/DDhvZ4rfkaHrqYNay+fDBGgfF74X/fMhs6g/aaL1C0JOPTzBhaAt3aXUu8wK7MhvKjs4WdY5OMRtns3/YugWw25OJQr+bEWNXq57nvusyTy37bHRcfa64uvsSB4QZpcnfGZi6PiQTfP+S2xfYh+oUY/jpe3sIh3rWwOrUUAbeZETKVsSrAOYNu4cg/j5uGPwaEYI6yjNjj60z79H0afRvOFfueSZtSYt9BuzLqvuSfZ8egc5k0As5rpHr8R1VhYFeABUbQyEXV7i263BCHI6jsh1vv2VUjaxQezJgPLbu34w9zSGKa5bkRSVZHLx2aqaqn08SKGq0hs3q9ujwMtFbg6FMb/DW56ID3vCCusp50MhKfEg3Vw/TpIjinyAtsvN1ECD+CX2IPrReW8M1Ohu7iEQQ8lnVlfXIL9ZffGxFPmKw7lxw1ByPuEVo6ySqS6gMgODF74u9WXGtQPcU35sIZCFq/8HdgmoiJ+S5ns0phRst+ay9FM X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(36840700001)(46966006)(6286002)(26005)(316002)(16526019)(4326008)(54906003)(82310400003)(6916009)(966005)(83380400001)(55016002)(336012)(186003)(36860700001)(70586007)(36906005)(2616005)(70206006)(1076003)(7696005)(7636003)(5660300002)(47076005)(426003)(478600001)(8936002)(356005)(53546011)(36756003)(6666004)(86362001)(2906002)(8676002)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:09:17.6912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24fbd638-700d-4e45-d338-08d92d2df057 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2648 Subject: [dpdk-stable] patch 'net/hns3: fix link speed when port is down' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/180a37c3ef268f6f1c31b8948bf04f6e9e4281bc Thanks. Xueming Li --- >From 180a37c3ef268f6f1c31b8948bf04f6e9e4281bc Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Sun, 25 Apr 2021 20:06:29 +0800 Subject: [PATCH] net/hns3: fix link speed when port is down Cc: Luca Boccassi [ upstream commit 230d4940ed8e4fc0138fab2fdb2087553b8465dd ] When the port is link down state, it is meaningless to display the port link speed. It should be an undefined state. Fixes: 59fad0f32135 ("net/hns3: support link update operation") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 01ff8de7f7..40e4cfde31 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -2684,16 +2684,18 @@ hns3_setup_linkstatus(struct rte_eth_dev *eth_dev, case ETH_SPEED_NUM_50G: case ETH_SPEED_NUM_100G: case ETH_SPEED_NUM_200G: - new_link->link_speed = mac->link_speed; + if (mac->link_status) + new_link->link_speed = mac->link_speed; break; default: if (mac->link_status) new_link->link_speed = ETH_SPEED_NUM_UNKNOWN; - else - new_link->link_speed = ETH_SPEED_NUM_NONE; break; } + if (!mac->link_status) + new_link->link_speed = ETH_SPEED_NUM_NONE; + new_link->link_duplex = mac->link_duplex; new_link->link_status = mac->link_status ? ETH_LINK_UP : ETH_LINK_DOWN; new_link->link_autoneg = -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.848319100 +0800 +++ 0046-net-hns3-fix-link-speed-when-port-is-down.patch 2021-06-12 06:53:56.220000000 +0800 @@ -1 +1 @@ -From 230d4940ed8e4fc0138fab2fdb2087553b8465dd Mon Sep 17 00:00:00 2001 +From 180a37c3ef268f6f1c31b8948bf04f6e9e4281bc Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 230d4940ed8e4fc0138fab2fdb2087553b8465dd ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 63ae555c9d..a6f4c92e41 100644 +index 01ff8de7f7..40e4cfde31 100644 @@ -22 +24 @@ -@@ -2870,16 +2870,18 @@ hns3_setup_linkstatus(struct rte_eth_dev *eth_dev, +@@ -2684,16 +2684,18 @@ hns3_setup_linkstatus(struct rte_eth_dev *eth_dev, @@ -43 +45 @@ - new_link->link_autoneg = mac->link_autoneg; + new_link->link_autoneg =