From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6A3FA0C3F for ; Sat, 12 Jun 2021 01:05:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D18B54003F; Sat, 12 Jun 2021 01:05:34 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id EB5B34003F for ; Sat, 12 Jun 2021 01:05:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTkMz3X3DwnAKRgeudAFvK+OI2jxgB2Ks1aYT3Na2XJKFD9OC7leS+ddZxqSFwmkEx/eK7jSKk+zGYKFsiFfa4Ao7cyD4ozi0KPsIY2YBvTuHw5TJVWfwySQAKModD7ID9KaeCpKuZBh1Jwg3aue26+q9KxaG0/XJ0Tvb97ebllGv2R+zm7Hl8WbQnpDZoQopmllD3skN2q4ORJJjHRKoE1yfIgqWMdjEGfQqLEmWcdmAocw8qKarD9wLKkffzaJ8V/X4HT1qfXp8A6EC72zHjrPiEXTVnQhzGmeMhtl/gQyRy4sG2LL5tWE2PmRoT93mEZVwTl8jIWEYoXDkL+mhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ie58dHNQ96Eurl+/p4JKujqcWMg41UUmjA3nxE7Tx/s=; b=ST6UIyYboECHyfDluunq2nentHQgw6qTTJfmvVeltnyF0j98DHDZe737tsWZTgBZFVYmK7Ou4L2NxsfawTvjJVAvESh7PW+RiVHztLTg7Pynv1SQuDnRRFRB57fCfFvgDXBqp+52yfPFjHOPD6ei2U/pnVQlkXR1M7LPjlVnpOtklPNrPWCECReAoTgEylG/1LxcWCvVSNhPKsMX7V/9IhDElDvjlAbRrnMiq33ZX7BGecPcBfsJCvosG+h5WPjTko6YuG1570ysqKexLwKEC274iWBnosa8pKbFyB8KWjVHbDU+03KILy2+nzp9PI3lVWancR5FNRhsjlQbcV3TXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ie58dHNQ96Eurl+/p4JKujqcWMg41UUmjA3nxE7Tx/s=; b=coXrxnMl1YqCNI4xjNc9aYBYJn3ZdBz7AXWjxMtXXpvbtJ/zQP6KWFlIBseOir0noKgqWJ5+Kz80UvmY/q6kty6eE2J4lA/rWvc8PZnDYI1XTEwISRVAaMbJcAYJnBb4U8Hu4uu6M1TsWryYVUmx9FYphTrRj8HlQ/ij05nKS8fUuzNF+swnNmfloqU5HFNFrqjXZT4MXVX5G7iw1C1BQAvtnJM5PSyQTiCyBsQU0OaNNeI0cHSjasLnUPZNQexTxpYem4gmkdzC4eqjobAxU4kkWZmWWwrhvuoerIrDSYy1roPf0VHd6lYDEqyCCjD3lJTYcJFfOK0zsSeQskeS2A== Received: from MWHPR22CA0051.namprd22.prod.outlook.com (2603:10b6:300:12a::13) by BYAPR12MB3528.namprd12.prod.outlook.com (2603:10b6:a03:138::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Fri, 11 Jun 2021 23:05:31 +0000 Received: from CO1NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:300:12a:cafe::6) by MWHPR22CA0051.outlook.office365.com (2603:10b6:300:12a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT007.mail.protection.outlook.com (10.13.174.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:30 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:05:29 +0000 From: Xueming Li To: Olivier Matz CC: Luca Boccassi , Wenwu Ma , dpdk stable Date: Sat, 12 Jun 2021 07:01:40 +0800 Message-ID: <20210611230433.8208-6-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85035edc-591a-4c59-26e4-08d92d2d690b X-MS-TrafficTypeDiagnostic: BYAPR12MB3528: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ue+Dl4Q6x4KjUrzO7lQD8OnjRnW0rkpbXoZnwiIFYKnb5TTkcVSQC7XxEAJ20qulltrrhKgPsf45iJDik3dOdZ6ciGQOOouH3GuVsdscNxVYiP2v8yFDXzTo39tWlZX/g5YD7DV174wkCNJIDAVtC4WCRXgu++Zk/RiMrFqOFdu07SBUcx7mFdMnS++EjPLaJgTAYygwSeGfZDL8cSv8CWxd1jLWZMm39p2zI4xi4aTeJjFyqAlkElDcRZ93YFlBe5F6V128Fo575fJnzCzjRIq+DMStbOn2MtNbURmcOJcD6Qqv6w1eZRCeux5GfYokYByJ/dkMYI6Cmo/Rh5yC6nsVyN8tFb9ixMY2WsYw5xXvmjiB5dsqjy83L5wo7Qwcxn+RWscvdibrj4TeBPqqdrTSJV4uxZbwLT6KvV2lgzv/9X2zjCgYg5MSa3yMOxGWih1pRhxPxSiDFVRUhTM0a6QFlKCr11E+5NUECS4eiZXrpJDovkgp8BlFk0YjHuJDi4nj4hTJEEh5VZwPA/HJv2+MlWjdS2W/JWRE5ArPbvGpFcXYMrXPOH+d/hNfJlHY0nAZugr0V0aDE9DCQ3RF4jZEexEJDEd+kO7OFcDp7k3GYdKjvXO467fu4207DLTHi3BOv0VzkliJiw4JwPcPuIFmfiC514eYpa8uJg+lrDkeO2vwHPO3H8EelUVndyr69BmU7TCOua1ssZJtqyi7KE3tovyK+Aq2+YOnw7zGPnoJTKDODKU9cSfGGixr+dYCDyfTHp9IkjdvhJoelDitQyQqLDFepZfZ2qSL5Ll54HDYe+685hExYw+50Pf4TgVI X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39860400002)(376002)(46966006)(36840700001)(53546011)(426003)(36860700001)(186003)(47076005)(4326008)(8676002)(6286002)(36906005)(316002)(966005)(54906003)(26005)(86362001)(16526019)(2616005)(6916009)(5660300002)(7696005)(8936002)(336012)(1076003)(70206006)(356005)(70586007)(6666004)(36756003)(82310400003)(83380400001)(82740400003)(2906002)(478600001)(55016002)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:05:30.7683 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85035edc-591a-4c59-26e4-08d92d2d690b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3528 Subject: [dpdk-stable] patch 'test/mempool: fix object initializer' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8ad8d124a5584d7817f5654eabdbd61ae8b2994d Thanks. Xueming Li --- >From 8ad8d124a5584d7817f5654eabdbd61ae8b2994d Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Tue, 27 Apr 2021 15:56:45 +0200 Subject: [PATCH] test/mempool: fix object initializer Cc: Luca Boccassi [ upstream commit e1064f80b61157250250353718ff196d2f050041 ] The function rte_pktmbuf_init() expects that the mempool private area is large enough and was previously initialized by rte_pktmbuf_pool_init(), which is not the case. This causes the function rte_pktmbuf_priv_size() to return an unpredictable value, and this value is used as a size in a memset. Replace the mempool object initializer by my_obj_init(), which does not have this constraint, and fits the needs for this test. Fixes: 923ceaeac140 ("test/mempool: add unit test cases") Reported-by: Wenwu Ma Signed-off-by: Olivier Matz --- app/test/test_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c index 084842fdaa..3adadd6731 100644 --- a/app/test/test_mempool.c +++ b/app/test/test_mempool.c @@ -552,7 +552,7 @@ test_mempool(void) GOTO_ERR(ret, err); /* test to initialize mempool objects and memory */ - nb_objs = rte_mempool_obj_iter(mp_stack_mempool_iter, rte_pktmbuf_init, + nb_objs = rte_mempool_obj_iter(mp_stack_mempool_iter, my_obj_init, NULL); if (nb_objs == 0) GOTO_ERR(ret, err); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:56.852962600 +0800 +++ 0006-test-mempool-fix-object-initializer.patch 2021-06-12 06:53:56.000000000 +0800 @@ -1 +1 @@ -From e1064f80b61157250250353718ff196d2f050041 Mon Sep 17 00:00:00 2001 +From 8ad8d124a5584d7817f5654eabdbd61ae8b2994d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit e1064f80b61157250250353718ff196d2f050041 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org