From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4414DA0C3F for ; Sat, 12 Jun 2021 01:05:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D34440E64; Sat, 12 Jun 2021 01:05:40 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55]) by mails.dpdk.org (Postfix) with ESMTP id AE5B04003F for ; Sat, 12 Jun 2021 01:05:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/UYzf+TE1jdbbPAycQ4VrY33T/fpt8OXhDuai+DrzKcEFU5vC/oTlehmmxXFjI15OI80qKnSIiirfikENd3r981UsjK7vcIiAAzs9zVv+bI8tW6fsbNUEi6HoVUp2SDWC/UDPWrs8jRnn/m2Ra27wb1dF/x+r+UevykP5hYqrPTUXsYjTFZ6bW/RVqdDfRz5ibit6NsE1jShSqPZLNibu+pkRZ2ODZSW214WHQP7nLosbQhxYxYjIb3hJXKgfvlwuZO+JFZMrFsnfnvqBDFCeZMI9Bx9ZQXBqObdCRb/u/SpsZOQgQ3a5cryONJ1E1oUXc6q0jk1WEBVGFlqBhrSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2svyOx4VTtSjaqie1ZRVkYvRevgiV9HNgGRYywftMCk=; b=oCyCB0rIv884WNc2ge+Jny1CGolczIDdXBSZ3eQPOproAMNnmifcSqc3dTK0nMXBO3PyskqvtqqzUJXFe/KIoGfuiuVmVWv1I51Ujdx2e3UI7HM0vEqjHx6elM2mv/X507650pz/cFwUP9stQLj0ch4HUNJ1ayl8r0LM5GQuj4rJSDz+3xNPPpJCQ6hi3C2Vquv0KCr2ZSi7tD3uIs7l0V6wfK63uM5ju7+av4V6HDOL5H7KDQCO6EhnsFNY7ogkUy/T6kvBM/f5P8wHj+ZATW40I5G0DTZLdb56jhsUnZxtHxO3OFHYJStcG9SjpV77ZxQFTvq4k63B9BHcYwUziQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2svyOx4VTtSjaqie1ZRVkYvRevgiV9HNgGRYywftMCk=; b=XKH6UmVlBsP2YviiiBLwkc4qvb5MbtnRT5hfoqgMmDO1twcD/zvpVPLeCQO7dh4NG305vNrzSjfoAZEct8mPDjHXzZodEz6uIFJbqYL9CO9dtSjme9h+K4UMKcPrIbSwLPDyxFNXTsFaCQu2jFcF8xb2Qye/4CzubvUjKxtrJVONMSFGXvc94pOqJyk7vJIgpR5CkWKSNBXAEIriBJX7LZ4wewAoE/7W5wYoZwVwE6eH+9EsP08qsVoN6ecH+RwBoSRWXGnmrMvxD564ULrlQQeGY6lY9+f7m3FFWIi/DVTROlK7lLj4tIfX7h2uy//QCiRk8yJH46o6pmTALjQpHQ== Received: from MWHPR14CA0015.namprd14.prod.outlook.com (2603:10b6:300:ae::25) by CY4PR12MB1624.namprd12.prod.outlook.com (2603:10b6:910:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:05:37 +0000 Received: from CO1NAM11FT020.eop-nam11.prod.protection.outlook.com (2603:10b6:300:ae:cafe::f5) by MWHPR14CA0015.outlook.office365.com (2603:10b6:300:ae::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:05:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT020.mail.protection.outlook.com (10.13.174.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:36 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:05:34 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Min Hu , Jerin Jacob , dpdk stable Date: Sat, 12 Jun 2021 07:01:43 +0800 Message-ID: <20210611230433.8208-9-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 740f39ed-8fa4-44fd-aa77-08d92d2d6cab X-MS-TrafficTypeDiagnostic: CY4PR12MB1624: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cfbcyyQF3O/ABAv7Uoo2KN1D3J9VHp+vm/JrfqCg5ycfedRKHTqhTsnjBWOnmizrrBOXvlaDkv034HgT7Sky96M6ZrUzhCdZD3lbRwmWIq7Unx1FiDsDoeY6m38niTFIO1ji3+e3N+rfmr1HDIfpwM3gC53XCqPUw/JwWlsRkX+3nvnN2i7z601F5et+z7haOsDNvE21fSo7zEwAOe1i13Bi/MZ6S8UDtzKCAMsbrvMO973PXBd+98hgN/PxYepE5+AnRj8Z9uif/8ret80kGe83xy1s3WMBK8sdYCR2/Uu2HfVciVLhaIX7ohwM5ptrMP8JyUJngxiuXvpKnrTWL5YeXVLnVAy1N1xIum19ZRMYhghMCbXiONFPLSMHPKHK95t6r4wLnklaD8Ey+N7Cj8p373ESM5NXDAYbvlnDLusxHme4ZcRYJkButNZS8GPbYncgBPDCb+FAxw+d9hxeTPcHHZkttzO12Km49ZY/uh60gJVdAsWeYRnR2Ox72oPlbEht5x5UWRaigGN90nhdiyT9kWh0IjCEHFAgn4qM4Lo2zbCD0ku882HjImt7qpvkd86Sl2RQBsqYoMRbx7vM9LGnte14Z3TohCt6i8bzbQXcnSsvka6v4Cmr/iAZyZalI+CT5FPlqUx5VbKOa2kCflrXyZuWXZPVFtXUytw7QdhLA5sbQohLbMZyPLnc++QtIPy+zy87vgjAFFr5XC9i0QTQhYHW5Jjiw2YJp6wAMFUZQgsLYLA9sszCc2V/k4HCy7g42Gdznfbo/PIqtOEt4ORMn3JSmeWcHGRO4SXLc/Vtvc1bl5Z5AzalVCi8HrgI X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(36840700001)(53546011)(966005)(6916009)(6286002)(86362001)(6666004)(70586007)(70206006)(36756003)(356005)(16526019)(7636003)(54906003)(186003)(82310400003)(26005)(55016002)(36906005)(426003)(7696005)(82740400003)(36860700001)(316002)(8936002)(336012)(8676002)(83380400001)(4326008)(1076003)(5660300002)(2616005)(478600001)(2906002)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:05:36.8044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 740f39ed-8fa4-44fd-aa77-08d92d2d6cab X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT020.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1624 Subject: [dpdk-stable] patch 'eventdev: fix memory leakage on thread creation failure' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/efdd260f6ee264e2597ba466a743d2f788bb9fcd Thanks. Xueming Li --- >From efdd260f6ee264e2597ba466a743d2f788bb9fcd Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 30 Apr 2021 17:34:38 +0800 Subject: [PATCH] eventdev: fix memory leakage on thread creation failure Cc: Luca Boccassi [ upstream commit f6681ab76bc5983f0571aaa4154ef839978c1088 ] This patch fixes the issue that epoll_events memory is not released after the intr thread created fail. Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index e84e547292..663b446c05 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -1288,6 +1288,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter) return 0; RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err); + rte_free(rx_adapter->epoll_events); error: rte_ring_free(rx_adapter->intr_ring); rx_adapter->intr_ring = NULL; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:56.933279300 +0800 +++ 0009-eventdev-fix-memory-leakage-on-thread-creation-failu.patch 2021-06-12 06:53:56.010000000 +0800 @@ -1 +1 @@ -From f6681ab76bc5983f0571aaa4154ef839978c1088 Mon Sep 17 00:00:00 2001 +From efdd260f6ee264e2597ba466a743d2f788bb9fcd Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit f6681ab76bc5983f0571aaa4154ef839978c1088 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - lib/eventdev/rte_event_eth_rx_adapter.c | 1 + + lib/librte_eventdev/rte_event_eth_rx_adapter.c | 1 + @@ -19,5 +21,5 @@ -diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c -index d317e89c1b..13dfb28401 100644 ---- a/lib/eventdev/rte_event_eth_rx_adapter.c -+++ b/lib/eventdev/rte_event_eth_rx_adapter.c -@@ -1436,6 +1436,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter) +diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c +index e84e547292..663b446c05 100644 +--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c ++++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c +@@ -1288,6 +1288,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)