From: David Marchand <david.marchand@redhat.com>
To: stable@dpdk.org
Cc: xuemingl@nvidia.com,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>
Subject: [dpdk-stable] [PATCH 20.11] net/ark: fix leak on thread termination
Date: Tue, 15 Jun 2021 14:22:11 +0200 [thread overview]
Message-ID: <20210615122211.25457-1-david.marchand@redhat.com> (raw)
[ upstream commit b8b5dc6b9596a07cbeed03192b41a4befb75acc6 ]
A terminated pthread should be joined or detached so that its associated
resources are released.
The "ark-delay-pg" thread is just used to delay some task but it is never
joined by the thread that created it.
The easiest solution is to detach the new thread.
Fixes: 727b3fe292bc ("net/ark: integrate PMD")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/ark/ark_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 0156eeb66e..c307880ec1 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -2,6 +2,7 @@
* Copyright (c) 2015-2018 Atomic Rules LLC
*/
+#include <pthread.h>
#include <unistd.h>
#include <sys/stat.h>
#include <dlfcn.h>
@@ -585,6 +586,7 @@ delay_pg_start(void *arg)
* perform a blind sleep here to ensure that the external test
* application has time to setup the test before we generate packets
*/
+ pthread_detach(pthread_self());
usleep(100000);
ark_pktgen_run(ark->pg);
return NULL;
--
2.23.0
next reply other threads:[~2021-06-15 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 12:22 David Marchand [this message]
2021-06-16 1:07 ` Ed Czeck
2021-06-16 2:57 ` Xueming(Steven) Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615122211.25457-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=ed.czeck@atomicrules.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
--cc=stable@dpdk.org \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).