From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FF1A0C4C for ; Mon, 12 Jul 2021 15:10:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C7EE4069D; Mon, 12 Jul 2021 15:10:38 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 08E014069D for ; Mon, 12 Jul 2021 15:10:37 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id r11so20285221wro.9 for ; Mon, 12 Jul 2021 06:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w6W1ys/5rdHVnSSkAg9f8MeuTnVWksM61UeV/o4+MEs=; b=WyAi4c034d0tDczGxUGA3RgqKysleg/tY2oIQM7nRhIha29sEaptLbML7veCVNP9V/ jNoecHgXcopKOCmAok4EemW8akAyjQELspkVgVuPUj+tL/6TEIO9Pyp8/akamPh+i1nW gg75Uzy6K40nH50dhrfzq7M7o57RCHSn05OoXFh73ZKG2q1FakUBtjq37d08hj5xyhUT d9nqjnTotrsyMvU0kyZbI7wlccEagr7HPtJEhM2KN8Jw0jtAP7qGIZNTAhVz09wMiDYS nB8icvK7P6DRdluaDKM1JJD3k7K/HOlp2w+6LBnmSJ6fOIt9mX5aOvBKhCMhiA9rrQU3 hXfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w6W1ys/5rdHVnSSkAg9f8MeuTnVWksM61UeV/o4+MEs=; b=DtdCyH5/TFdLuSxV/RVKh4zOtd4sM0jU8y5E2krHxVEWNuP+Z+xrfvHlQa4jh+ln3W kDQ2SehCn+dVjTvSevPDS4zQSY2JiTPrXrjEPK2dC+E5KA5G8sEWz9qG/dvMEGxwZTRi rSqXidbAL53+MGjvfXzXzTIxGsJO8LvBL1GKutE0Z9jHrPYbeGEDHbWG4mAWDSgJ0/qW BbShT6KWG4UgEeUp2EQII5GXhtN5WQr5Sf6YYVsJ5lUcQQbYEMwxw9O6QbDfI1qaTq6H ekqGKS0h4x+St7fkfEuAsAtEnta4GqLi4CGICTOSCSLs/Ek4LzvC+nLT9pwPKSvOOw5C QkqA== X-Gm-Message-State: AOAM530TNH6ZY2bjDv1BGvbtADIOr8mgxkCToDp9albNkrS1vhUksKMD VNaUNaoE9cvO+MSeawPfSoQ= X-Google-Smtp-Source: ABdhPJy0Yxh/v7zC9Mak19Ded5ozYCIKHQoPyUihuISYXcE72yxcx2FqmFnGd7kIrWyYd6WbFjcnzQ== X-Received: by 2002:a5d:4e4d:: with SMTP id r13mr14843755wrt.224.1626095436833; Mon, 12 Jul 2021 06:10:36 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id y6sm560457wma.48.2021.07.12.06.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:10:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Haiyue Wang Cc: Beilei Xing , dpdk stable Date: Mon, 12 Jul 2021 14:04:12 +0100 Message-Id: <20210712130551.2462159-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix RSS key access out of bound' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/58fbfecc2a176904fcdd738e0a544029bb278c20 Thanks. Luca Boccassi --- >From 58fbfecc2a176904fcdd738e0a544029bb278c20 Mon Sep 17 00:00:00 2001 From: Haiyue Wang Date: Wed, 19 May 2021 15:59:33 +0800 Subject: [PATCH] net/iavf: fix RSS key access out of bound [ upstream commit 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f ] The array rss_key has size 'vf->vf_res->rss_key_size', the array index should be less than that. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Haiyue Wang Acked-by: Beilei Xing --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 649061d2ba..9671c957d8 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -274,7 +274,7 @@ iavf_init_rss(struct iavf_adapter *adapter) /* configure RSS key */ if (!rss_conf->rss_key) { /* Calculate the default hash key */ - for (i = 0; i <= vf->vf_res->rss_key_size; i++) + for (i = 0; i < vf->vf_res->rss_key_size; i++) vf->rss_key[i] = (uint8_t)rte_rand(); } else rte_memcpy(vf->rss_key, rss_conf->rss_key, -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:37.731034242 +0100 +++ 0017-net-iavf-fix-RSS-key-access-out-of-bound.patch 2021-07-12 13:41:36.226117111 +0100 @@ -1 +1 @@ -From 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f Mon Sep 17 00:00:00 2001 +From 58fbfecc2a176904fcdd738e0a544029bb278c20 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8ce5678f28a80871c9f4ef41ef52ba206ef5a17f ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index a7ef7a6d4d..5290588b17 100644 +index 649061d2ba..9671c957d8 100644 @@ -22 +23 @@ -@@ -366,7 +366,7 @@ iavf_init_rss(struct iavf_adapter *adapter) +@@ -274,7 +274,7 @@ iavf_init_rss(struct iavf_adapter *adapter)