From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5683DA0C4C for ; Mon, 12 Jul 2021 15:12:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50F354069E; Mon, 12 Jul 2021 15:12:03 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 23A5B4069D for ; Mon, 12 Jul 2021 15:12:02 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id y21-20020a7bc1950000b02902161fccabf1so11216367wmi.2 for ; Mon, 12 Jul 2021 06:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2dG+TShONaQqmBlsB+Qw+e97PabCYclAb5vGfyAnsIs=; b=c0Z0t0uIEnPw6siK5xlzwsat/4G0++gygDCX/JpDDogFilUYEb8zq9TTbJHsJ6fEJD KVD5t7wrGLK/+BHVPIfoDODS04Mqq9seQIKjxGz+89PfWsGm2MY+7RwNWV8mtqTPVHU3 h/0Y9OEIPeO97zKs2p71pMSp2RDhi1PyfhvOjUA73mAiu9W72mQySY7+QSVWxtBKUpvc ckwLlPJFdEhuyUx0o+2ZlMSWzRBTgmvZN5Fwn1hhJOCI3tXEPcm9MqiV7CEXADtblOGB fbTYAe9TZYj8sV03mSUdNNzbyAwa2b2F+h/Wrd4xAtnkEa4nPYkSvdVagNPX5MxbeLeA S94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2dG+TShONaQqmBlsB+Qw+e97PabCYclAb5vGfyAnsIs=; b=fpEXid5y0t7xLVWNCSzkdyqx97C+O5tCz2Lb+h45jR6Q1wXtJRDdBdtgAXjPJHKLHb wHWUHnWqGRVZNVCH2yg6a+tYXwPKw7UhOi687QW7mroLSbb032TNc7HV4SjFhQcnaF8B x4lRunC/uc5v7xKXrypqlk6foXA23WUEEB8AN+ZR6AWGTHoYH8vPnZzfUlkoe74wMLAS 8GBfi0uRE6nSivF3x8m7+Rf9/BjLPK4Dfc6maauwzCxSHS1OuVNVFpDHLzANvhNB30Ik 89EN+0JzP6F7BA41zkzRnHucz79JiBgtsYgXwB8aPKixPjSvjv712amdh9YK2hyAYM2m 06aQ== X-Gm-Message-State: AOAM531wvHWHby5hVG62jl78iBGnNKCOBUlgPvaxILq930xBlF1VFf/H h0uczHlAC6vEZUFM8fVCIdU= X-Google-Smtp-Source: ABdhPJwtF8EbiRLJ1fBSm6vIukM5AdKTMADxzKuGwVeidWcxgMeSPLCSMC+OoiBLbudmS0COUfcRuw== X-Received: by 2002:a05:600c:3b01:: with SMTP id m1mr9745704wms.90.1626095521951; Mon, 12 Jul 2021 06:12:01 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id p5sm14756785wrd.25.2021.07.12.06.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:12:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Owen Hilyard Cc: David Marchand , dpdk stable Date: Mon, 12 Jul 2021 14:04:31 +0100 Message-Id: <20210712130551.2462159-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'tests/eal: fix memory leak' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/451ead3bfd8358667c6d8c19e6c003c7027a80eb Thanks. Luca Boccassi --- >From 451ead3bfd8358667c6d8c19e6c003c7027a80eb Mon Sep 17 00:00:00 2001 From: Owen Hilyard Date: Wed, 16 Jun 2021 12:24:52 -0400 Subject: [PATCH] tests/eal: fix memory leak [ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ] The directory steam was not closed when the hugepage action was HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of the unit tests. Fixes: 45f1b6e8680a ("app: add new tests on eal flags") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_eal_flags.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 932fbe3d08..b4880ee802 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -124,6 +124,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action) case HUGEPAGE_CHECK_EXISTS: { /* file exists, return */ + closedir(hugepage_dir); result = 1; goto end; } -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:38.559588607 +0100 +++ 0036-tests-eal-fix-memory-leak.patch 2021-07-12 13:41:36.298118611 +0100 @@ -1 +1 @@ -From 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b Mon Sep 17 00:00:00 2001 +From 451ead3bfd8358667c6d8c19e6c003c7027a80eb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org