From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DFCFA0C4C for ; Mon, 12 Jul 2021 15:13:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57D494119C; Mon, 12 Jul 2021 15:13:29 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 99CC44069E for ; Mon, 12 Jul 2021 15:13:27 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id w13so11388096wmc.3 for ; Mon, 12 Jul 2021 06:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c6WQNmt4MtfyLA638Hi3Yq0tdzn/4Le3m2FqAzXvxOc=; b=H31cgkvQGDWwr0XAzCCuMK4S7x4LzRyK1DsDxEwmd778yro/RAYkBnLknlFGYbxr3F BMOGQToqkBRmCC/ozNQ77GNbzi6lcX4jFs1ddGN6m9uqeJaEdDZbCuF7iN5hwRbQ2XOv 5hNIAiD1rffQQMY5PGarnbgJSVBDFa8099iUcqUYvvasD74V8vcYP2yQiUgt3EK3qoVn FMPzGaDxuqIIOxiPhNLrQXpIfVMQN+JinNf+umnAxR6KkXGQWp72v9OZymXSKKTSy432 AU9eSEE8XDjqEV8hMhiJv7hz2Tglv1c7AMZVeAjy8RQRBjxW1y0uTq/z4A0hKx8znt/v Inhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c6WQNmt4MtfyLA638Hi3Yq0tdzn/4Le3m2FqAzXvxOc=; b=Mwm6v5DhDG2KbaFVTbh4xjmSws1bfwdBB+GJIniyFPOpzyMIb9ma8Q6u7JUMuKTwuY Nwowty2XayCQNM/5jbjSUXJSFpp8RviyB0UsLti69fINmutWte/Od079PmkoUWpZbGXa GHQCB+sHJRyDHmuVpJpkC7JS3AG+ir/ZQya4p328KbtrAILJDc6zWqUhnb+E9+vvpilG vygPeVcCJFloYJq2zDa1rnwZDchKT66zTM6K5S/gQjX2uil5N0v4gHSWuXx8pTRgkgXj lfw3ohISH0ZK//U/G3JG2OWOTi42xUFl9nIqbLYb8h14wviC6hGTqaRhXCUi/1/vgBPj DyhQ== X-Gm-Message-State: AOAM532CT+z5w1JKfd9QcPIFnFXpQ7AM5fKEWRlenP+NRtj/Wbf2qruV eeNmbhgcLRQHx5g/HB9EWFI= X-Google-Smtp-Source: ABdhPJw9jIWOQvJG9zZHn3q4novaQsr+swoCAAn/uFkWqfEQVofMM8/m6DTGR0hJi6eO3TkFSYgUCA== X-Received: by 2002:a05:600c:3514:: with SMTP id h20mr14863614wmq.46.1626095607431; Mon, 12 Jul 2021 06:13:27 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id o28sm15331831wra.71.2021.07.12.06.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:13:26 -0700 (PDT) From: luca.boccassi@gmail.com To: Thierry Herbelot Cc: Gagandeep Singh , dpdk stable Date: Mon, 12 Jul 2021 14:05:00 +0100 Message-Id: <20210712130551.2462159-65-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712130551.2462159-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/pfe: remove unnecessary null check' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b0d9d06878b5b584ff719c01e8192b1eac446645 Thanks. Luca Boccassi --- >From b0d9d06878b5b584ff719c01e8192b1eac446645 Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 24 May 2021 11:37:54 +0200 Subject: [PATCH] net/pfe: remove unnecessary null check [ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ] ethdev library does the check of dev before calling the link update. Fixes: acd4818ea2a45 ("net/pfe: add link status update") Signed-off-by: Thierry Herbelot Acked-by: Gagandeep Singh --- drivers/net/pfe/pfe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c index 3b079693fb..f5c271b3f0 100644 --- a/drivers/net/pfe/pfe_ethdev.c +++ b/drivers/net/pfe/pfe_ethdev.c @@ -582,11 +582,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) struct rte_eth_link link, old; unsigned int lstatus = 1; - if (dev == NULL) { - PFE_PMD_ERR("Invalid device in link_update.\n"); - return 0; - } - memset(&old, 0, sizeof(old)); memset(&link, 0, sizeof(struct rte_eth_link)); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-12 13:41:40.061890315 +0100 +++ 0065-net-pfe-remove-unnecessary-null-check.patch 2021-07-12 13:41:36.558124027 +0100 @@ -1 +1 @@ -From 01bfb518a39b91da7896abe579bcf72d06935bf5 Mon Sep 17 00:00:00 2001 +From b0d9d06878b5b584ff719c01e8192b1eac446645 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 3135466713..feec4d10a2 100644 +index 3b079693fb..f5c271b3f0 100644