From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B9FFA0C48 for ; Sun, 18 Jul 2021 13:15:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DE1641186; Sun, 18 Jul 2021 13:15:28 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2079.outbound.protection.outlook.com [40.107.100.79]) by mails.dpdk.org (Postfix) with ESMTP id 7ABBE40683; Sun, 18 Jul 2021 13:15:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSWugZ4ls2M7jl+dicQJBDQKNxkBjTrQ93HghFTLRkW2VK4LybGR1RFXVlrc1gCIM1952ss97NXD8hIWmT+4PjRvYbrk8lv1kl2S22k8a2bPxUP7arPJU5QOEQlADVDR949JvL1oYC3MEFy9oJFVAeJMONnwiGdmIj2R5457ZR7K7OtcvhyEQo45E4RuRl4H+ORzmmgDgZ6+c+SX957c57mPol7lqLZjbL/BR9m6z2cM/SIZdwS4pBFQTJsvXUf/wh2G/ALtuz07KcHkARmn9PnV3bFiuyt7DITNMg8BUzzkkqNbbV+cLKN/AoT6OdFYzafh2sc2tmr4izYN48B4qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNOIoC6XRqvjA5SA0FlMJ/D/+Y6qN9Maxk4qtrCdDM0=; b=B7LJbRerMMWOKg8pVMnrwX6GD+hh6krgUmvkCirvqrG95KYyH2s1EDDjZA4ue/Ch5rnwtUqu+Nf0Ah0S6g9Wj8Msep2KpHrmg3OR4U5yD6ujPRJ9F3m2ZGg9hS++zndHwu4r/UoquEAwjDlMR7KQiVlqY1dwss+XpSVRp77+QIWKVO1G7WVq21vwhGoUMAC0l1TRakjsvr0/RzoBO8SGSxTrcw/5MmZV2F9ePivuUeUr8PJROD0X/rwTbqDC8vKUVSgzi8qIYeUBIc2wUmXdOQhpgshaGb27BKlFuSVarzEhSnJK42Z900XLDR57y5NzlxOL41n0hTfPFPLJ5k0HUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNOIoC6XRqvjA5SA0FlMJ/D/+Y6qN9Maxk4qtrCdDM0=; b=ZWkLHlK6/eJYLbeHzJa+MEe54be1l/J+7eiG5iEX3qaUSoLM9EKPh9dTkK+V8NU7ohSofQYZmSBkiPdwseQKWbOYWQ2jnDFC0KlKwv9ZrnlKADUQYMcj1NeKm7IuUdR/cJlVS1bjeIq5OnlfXOIbhdr1EBFVBtk60Xbt/28AwpSYHe1p+PZ7jOEFS55jrN5X5CTt9pm1LQIGec9bHfz+oc56iy0c0HqfXQoHAenlityrHT24ud9HiGC4FsALnhov2qosO/EToeDRNLBFB0zVXVxXkHIw6yWewuledIOkWr2fRURkJ5hq7BNNF8y/9bFVUqBqd0ClCzX2U6GGvzBzJA== Received: from MWHPR22CA0017.namprd22.prod.outlook.com (2603:10b6:300:ef::27) by MN2PR12MB4143.namprd12.prod.outlook.com (2603:10b6:208:1d0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24; Sun, 18 Jul 2021 11:15:25 +0000 Received: from CO1NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:300:ef:cafe::17) by MWHPR22CA0017.outlook.office365.com (2603:10b6:300:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Sun, 18 Jul 2021 11:15:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT007.mail.protection.outlook.com (10.13.174.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4331.21 via Frontend Transport; Sun, 18 Jul 2021 11:15:24 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 18 Jul 2021 11:15:22 +0000 From: Lior Margalit To: Lior Margalit , , Matan Azrad CC: Date: Sun, 18 Jul 2021 14:15:04 +0300 Message-ID: <20210718111504.2654396-1-lmargalit@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a21c775-f026-4f66-fd23-08d949dd56d3 X-MS-TrafficTypeDiagnostic: MN2PR12MB4143: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f5gI0KI9OdC0JjS1AKYevrQ1qMquD30UHMm4w0q4W5izPJcsumIIMchaED3MCHb2GvftO1D/9LzdyKybXgOI0swl1HUHMjHeqhvnefdP7wyUNku0X9id5VnHp8TFBCMq65jQyFGMrukj9ACxavzVfC7EPbxUnDr49AcHr+iVOmyWRXYhVNGLkP8oY1D9iGFgU4YbXRXDz5B33Mwc/fki5Zilgi4fBXzQriOICvVcim3k5fyxYd00TNB3xICXZrit0fOeSsiHeCYNW+heBLlWN+JLL64ykzvWb+xsxIe0z07OOf7TC6Cb2aMRAZcA0wv3+x5pvZt2gp/C/UZ30E1LH/CDevoZGDx/1gTHApyADJngAAHh/e3pm11OX6HhuGyjH8ZDuQhUJCq6uRXfu4mV7YTLB7N4uRUo3R3Roal86tRUVh8nsngbcNtOAo1YBQAqtxvOo5oYfaXViR4pUIUtbPgAIEeRdfmUn5ExHw3ZdZj+uK1QrPCD9P63zY5AFoMQGbXtGqi/pJsEBg6r6pUYl1pCRObRyuXGF3IKJrQRjc0FGyJMJ2YVb6lsbyqPs3hcjrLVWOs/X1187xbt50992XM6Iod0zAohBIwsS4k+RWdt4DpZayEWcFO127ydwkfVMkdYhQosi7/wQr9fsMG2ps5K8G0Fr5u4cZ24GeuLWWp2+soNDvhD7PEt+SB3/M9QWJTeS0rU/iDTS3H/G53SppXk3kAKm7NPI3MrZog9m6E= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(426003)(336012)(5660300002)(2616005)(70206006)(70586007)(110136005)(34020700004)(36906005)(7696005)(186003)(16526019)(83380400001)(26005)(1076003)(82310400003)(316002)(47076005)(8936002)(36756003)(6286002)(356005)(8676002)(7636003)(4326008)(86362001)(55016002)(450100002)(508600001)(2906002)(36860700001)(6666004)(6636002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2021 11:15:24.1750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a21c775-f026-4f66-fd23-08d949dd56d3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4143 Subject: [dpdk-stable] [PATCH v1] net/mlx5: fix RSS expansion for GTP X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" The flow did not expand correctly when it included a GTP item. Added GTP node to the expansion graph as possible next node after IPv4/IPv6 UDP node. Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") Cc: stable@dpdk.org Signed-off-by: Lior Margalit Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 347e8c1a09..2a5f712fc9 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -135,6 +135,7 @@ mlx5_flow_is_rss_expandable_item(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: case RTE_FLOW_ITEM_TYPE_GRE_KEY: case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: + case RTE_FLOW_ITEM_TYPE_GTP: return true; default: break; @@ -455,6 +456,7 @@ enum mlx5_expansion { MLX5_EXPANSION_IPV6_UDP, MLX5_EXPANSION_IPV6_TCP, MLX5_EXPANSION_IPV6_FRAG_EXT, + MLX5_EXPANSION_GTP }; /** Supported expansion of items. */ @@ -511,7 +513,8 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = { [MLX5_EXPANSION_OUTER_IPV4_UDP] = { .next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_VXLAN, MLX5_EXPANSION_VXLAN_GPE, - MLX5_EXPANSION_MPLS), + MLX5_EXPANSION_MPLS, + MLX5_EXPANSION_GTP), .type = RTE_FLOW_ITEM_TYPE_UDP, .rss_types = ETH_RSS_NONFRAG_IPV4_UDP, }, @@ -534,7 +537,8 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = { [MLX5_EXPANSION_OUTER_IPV6_UDP] = { .next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_VXLAN, MLX5_EXPANSION_VXLAN_GPE, - MLX5_EXPANSION_MPLS), + MLX5_EXPANSION_MPLS, + MLX5_EXPANSION_GTP), .type = RTE_FLOW_ITEM_TYPE_UDP, .rss_types = ETH_RSS_NONFRAG_IPV6_UDP, }, @@ -626,6 +630,11 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = { [MLX5_EXPANSION_IPV6_FRAG_EXT] = { .type = RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT, }, + [MLX5_EXPANSION_GTP] = { + .next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV4, + MLX5_EXPANSION_IPV6), + .type = RTE_FLOW_ITEM_TYPE_GTP + } }; static struct rte_flow_action_handle * -- 2.25.1