From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E733EA0C47 for ; Mon, 26 Jul 2021 15:54:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E13D940F35; Mon, 26 Jul 2021 15:54:22 +0200 (CEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id C009B40DDA for ; Mon, 26 Jul 2021 15:54:21 +0200 (CEST) Received: by mail-wm1-f48.google.com with SMTP id o5-20020a1c4d050000b02901fc3a62af78so8236372wmh.3 for ; Mon, 26 Jul 2021 06:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AfmeGy6Uy4oPrd5n/O++osGMebBhfyLIMDs7o6C5DrI=; b=kqA6FkZg014NulsQi4U4hVRdMy0dLgotDBurVjKnxRpQnnGLprdfPZoTOHYnMDve/V GXS6JXmBGYXTcYC3Fw9/NCXnSkyLh8ZqNk95/PsNyUyx9ywRDOYuZE4S4vRE6Z0/klFM kggWXCU3rQHMpWWZYEGEvuB+vgJP7B+9djgUKAb7mh6evwVu/PihaEFXqNYyVQFt9fnE dGxkUb+nc8XmbNZAAZFKF+XJNxK0FCx2FGDg2fVqtMfE31Ze0BmXZ5sr88KQAeuIY4MV i/TWGfRsjmfGYkW1L0JIUZfXKW4zfiV5wXVo3220PKCA9XTP6/pxt/TVb2jhWTj9j3IK zQCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AfmeGy6Uy4oPrd5n/O++osGMebBhfyLIMDs7o6C5DrI=; b=OUZmidkawlwEEmXTPuJ774LAQfLCuKIrZthHs/xNF0qJOLEzvCb0OaVjEg7gwR3xZW /MPLA9GFrJ3DrGkyIsGZlMxSaOI642QxILjQrjMCAC+/v8PPNq9CBViTKPIW0MCqilO8 2B+hRPOMSP00LWFbnpuOGywUyYuQ3cN2FR7RayUbbXFWqA1ZgAhjJx2+LSAUh06yrXu4 InNsjzT56Hrijj0p7E4tc1B6ZXzQzGVBCpVS0AjgyATRF4TEwQTwV2HRkNFMLgjj5H/y HSEVA6zeHNahicgsf8yKNAKvx1PSXmIfR5lChP2KYFoZR4+DQuiPBH9EDvut/cort1M+ d/OQ== X-Gm-Message-State: AOAM532uUurxNnNMTfbxAX4Qop+bgI55LHqC/djlskQvaHMV8hRXx4bx bu6DFnpsifWUOclHSNX4joU= X-Google-Smtp-Source: ABdhPJxNGqDxAnSRdayJt12nOcfzqYJ+wriUV1MQATrwuXpE+ao1p0tNGfEjqIfPr2dQo4Z2KLVsyQ== X-Received: by 2002:a7b:c3c5:: with SMTP id t5mr14112106wmj.28.1627307661590; Mon, 26 Jul 2021 06:54:21 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id o17sm9095002wmp.31.2021.07.26.06.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:54:21 -0700 (PDT) From: luca.boccassi@gmail.com To: David Hunt Cc: dpdk stable Date: Mon, 26 Jul 2021 14:52:39 +0100 Message-Id: <20210726135322.149850-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'distributor: fix 128-bit write alignment' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/133edc5f0fce6e1b126ef55c3984fdd53a1b8a23 Thanks. Luca Boccassi --- >From 133edc5f0fce6e1b126ef55c3984fdd53a1b8a23 Mon Sep 17 00:00:00 2001 From: David Hunt Date: Fri, 16 Jul 2021 14:32:37 +0100 Subject: [PATCH] distributor: fix 128-bit write alignment [ upstream commit de8606bf73323dfa8395f2dc0a93dc6194ff21b7 ] When the distributor sample app is built as a 32-bit app, the data buffer passed to find_match_vec can be unaligned, causing a segmentation fault due to writing a 128-bit value using _mm_store_si128(). 128-bit align the data being passed in so this does not happen. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Signed-off-by: David Hunt --- lib/librte_distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index 07e385a259..c210cf86bd 100644 --- a/lib/librte_distributor/rte_distributor.c +++ b/lib/librte_distributor/rte_distributor.c @@ -478,7 +478,7 @@ rte_distributor_process(struct rte_distributor *d, return 0; while (next_idx < num_mbufs) { - uint16_t matches[RTE_DIST_BURST_SIZE]; + uint16_t matches[RTE_DIST_BURST_SIZE] __rte_aligned(128); unsigned int pkts; if ((num_mbufs - next_idx) < RTE_DIST_BURST_SIZE) -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:16.731281006 +0100 +++ 0016-distributor-fix-128-bit-write-alignment.patch 2021-07-26 13:53:15.833292286 +0100 @@ -1 +1 @@ -From de8606bf73323dfa8395f2dc0a93dc6194ff21b7 Mon Sep 17 00:00:00 2001 +From 133edc5f0fce6e1b126ef55c3984fdd53a1b8a23 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de8606bf73323dfa8395f2dc0a93dc6194ff21b7 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/distributor/rte_distributor.c | 2 +- + lib/librte_distributor/rte_distributor.c | 2 +- @@ -20 +21 @@ -diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c +diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c @@ -22,2 +23,2 @@ ---- a/lib/distributor/rte_distributor.c -+++ b/lib/distributor/rte_distributor.c +--- a/lib/librte_distributor/rte_distributor.c ++++ b/lib/librte_distributor/rte_distributor.c