From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18FDEA0C47 for ; Mon, 26 Jul 2021 15:55:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1091A410EA; Mon, 26 Jul 2021 15:55:23 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id B5E8440DDA for ; Mon, 26 Jul 2021 15:55:21 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id r2so11244237wrl.1 for ; Mon, 26 Jul 2021 06:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WLDuOu+mivWWVlem47gm3ZQJxSPfhAJaiTfQtJnh6EE=; b=WQnWdB3Tov1gtQItTRtCL+wa2bMlf5HcZ1J1ikpA5xJB+GJeCAWHoqehLunKKSuOgY nhxb7bdaw7QngyWkTcCH80IP/QXPxLCxfld40yIG/GPUsYj8xnMePyclDILfABS29mSS mD7enJQbS07UdWsEVW37N3yHcMmxMQDHQ1yc1u214HRSltuHlov2kdAmqD5JBwcPW4Cv JAJfMfk8HVqk7b0k4AiMmG9xwXNGNM97OfBRtOaQGuAuZb5C6/SNowpC8LdEke5RR7gt c03O9CrcHwuekeuNjrSRSjZoT6+k0QHzpQVjcNN0/gIC+IBGLgHHzlgyYUlBNVECLOmY Eqbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WLDuOu+mivWWVlem47gm3ZQJxSPfhAJaiTfQtJnh6EE=; b=CXUfR3MOe0JQnyBHRCwxPKQX8F8u4AwUl8HJudVIGczXBLL3ai4LNYyuq4l6ocfdGN L0YHUIVUjnX3x+4JApy3QHeKH0bNmiAQd/Leg+T/gVa+4fYMgWij3JKYOdwar9Qhli0Q VsinhPjFALWcuu1N9m//xVUJL4Nsy75HaAeqiGrek6lsuEsX5FuaNS+J9/65+EpJamVp ry7HEcDlrUuwVYx5Vb35n5xODRS6eBioNGW9xuG5jtmmnluTAM3iLUVcodIFTNwkh774 d6cJQVWrfZ+sXOaEUX8mpmQYjx5v7arBNa9cqgrxM7CETJcP4zg8/gAOC3WBPBs75oXY Yy4g== X-Gm-Message-State: AOAM530MLoYzSGiQtpHZ//YlCr2rUoYnVOcZztq4Sg89mmhFpsFfvIBM J+xg7Q/dBDnTFgguxqzr10U= X-Google-Smtp-Source: ABdhPJyZJkrybYVL7BpRp80VZNHrKMh/74SzOgX4Bsto/3RIXIoMKFFnVQISrMfyT34CCqKHntobAQ== X-Received: by 2002:adf:f946:: with SMTP id q6mr19033347wrr.283.1627307721552; Mon, 26 Jul 2021 06:55:21 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id w8sm31342056wrk.10.2021.07.26.06.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:55:21 -0700 (PDT) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Ajit Khaparde , Lance Richardson , dpdk stable Date: Mon, 26 Jul 2021 14:53:00 +0100 Message-Id: <20210726135322.149850-37-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726135322.149850-1-luca.boccassi@gmail.com> References: <20210712130551.2462159-1-luca.boccassi@gmail.com> <20210726135322.149850-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix null dereference in interrupt handler' has been queued to stable release 20.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/806a18751b2029a1fc83c44be59f9ef266673c27 Thanks. Luca Boccassi --- >From 806a18751b2029a1fc83c44be59f9ef266673c27 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 20 Jul 2021 21:51:58 +0530 Subject: [PATCH] net/bnxt: fix null dereference in interrupt handler [ upstream commit 3f44ec48c733f7d7607877164c9aa0305de9cecd ] Coverity reports that pointer "cpr->cp_ring_struct" may be dereferenced with null value. This patch fixes this. Coverity issue: 372063 Fixes: 5ed30db87fa8 ("net/bnxt: fix missing barriers in completion handling") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index 14075e41d2..1a99508572 100644 --- a/drivers/net/bnxt/bnxt_irq.c +++ b/drivers/net/bnxt/bnxt_irq.c @@ -33,7 +33,6 @@ void bnxt_int_handler(void *param) return; raw_cons = cpr->cp_raw_cons; - cp_ring_size = cpr->cp_ring_struct->ring_size; pthread_mutex_lock(&bp->def_cp_lock); while (1) { if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.doorbell) { @@ -46,6 +45,7 @@ void bnxt_int_handler(void *param) return; } + cp_ring_size = cpr->cp_ring_struct->ring_size; cons = RING_CMP(cpr->cp_ring_struct, raw_cons); cmp = &cpr->cp_desc_ring[cons]; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-07-26 13:53:17.822810395 +0100 +++ 0037-net-bnxt-fix-null-dereference-in-interrupt-handler.patch 2021-07-26 13:53:15.893293547 +0100 @@ -1 +1 @@ -From 3f44ec48c733f7d7607877164c9aa0305de9cecd Mon Sep 17 00:00:00 2001 +From 806a18751b2029a1fc83c44be59f9ef266673c27 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3f44ec48c733f7d7607877164c9aa0305de9cecd ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index ebdac8385d..122a1f9908 100644 +index 14075e41d2..1a99508572 100644