From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 845DEA0A0C
for <public@inbox.dpdk.org>; Tue, 3 Aug 2021 14:22:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 49F97411D6;
Tue, 3 Aug 2021 14:22:23 +0200 (CEST)
Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com
[209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id E5F6D40E3C
for <stable@dpdk.org>; Tue, 3 Aug 2021 14:22:22 +0200 (CEST)
Received: by mail-wm1-f43.google.com with SMTP id u15so12368584wmj.1
for <stable@dpdk.org>; Tue, 03 Aug 2021 05:22:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=kBl2BGJBAN9/stgup02LpLnnbi/5bjv0beige59SWUY=;
b=AtDPKymIUwGWVBBkEbOUvA5yPk2omc6VmFeg5m0/mDj4Tu44iALhnNr5bCvgVY+hY+
LiL42g+gSLF81gzCmFcSnNV5Lrl3EZJ1PuMPWmSv2WzeTxWAncmG/e2X2fnCnQhjyAY9
gp7bJRm1WJGs0dcNgK/EcFINwxkm+/aqIcGnFHZdHRSdJKWV6cMyY9g35radkxushy6V
gPvK9Ksyq391kcAhZ7xw2SVnqeAlLw0q0TAEjLfKDffD7UWxg3d/Y6d5Kn6Qgo52eW/U
j1fBjaGurCpKXN3PytXaw2wGMKKN+rzW6JS0s6PWCMsEyGm1yqfu/qUt2NuXMZXi90Dj
orBA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=kBl2BGJBAN9/stgup02LpLnnbi/5bjv0beige59SWUY=;
b=KN8LJhGrhZ6sQ70rDFcOf57luP4o4LjpLCofJn65wcNYkDlR8R63DfZGS4AnLeKP2B
wgspqaVdpHy9NGM1/K3qecbVNj/roRxV0J+ohgBgn/w3EPjpP1dqcMqXlQMRXiBsX/BW
mevJR1P8U98GH9nlDD1y51CBpF+wZupHxpPtGaisUKjF1n5dWZCVLUJTXUascM8lKcdX
lWEXJ4Br3AEaQarFsE6MzWui/MKTyGAAQEt8Ljz+5Zl8n1exrhxZtzDaQlsU3sKqNrR0
LQS7C4y+rbs6anBFW3C8W00qfuWvwkYg2M+2uoynUxQNR2/vaAqo+AuydqZl4PtM2hw4
KFcw==
X-Gm-Message-State: AOAM531wUmCkWGp5OWgbWw/Xjdnyb+sRK3a20VQPJWq8FyZxvn1LW2Wr
Z31MXuAXRUscbpmKBySsS3A=
X-Google-Smtp-Source: ABdhPJw+LjR3PtsiC5cRB+kCqcpIZP6noXBN+oqu3YxH+we6oeQLMIeRk48QQEmT3iclGRaoDYQxjA==
X-Received: by 2002:a05:600c:1906:: with SMTP id
j6mr3939377wmq.108.1627993342718;
Tue, 03 Aug 2021 05:22:22 -0700 (PDT)
Received: from localhost ([137.220.125.106])
by smtp.gmail.com with ESMTPSA id w3sm8587902wmi.44.2021.08.03.05.22.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 03 Aug 2021 05:22:22 -0700 (PDT)
From: luca.boccassi@gmail.com
To: Chenbo Xia <chenbo.xia@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, dpdk stable <stable@dpdk.org>
Date: Tue, 3 Aug 2021 13:21:53 +0100
Message-Id: <20210803122214.1094992-4-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20210803122214.1094992-1-luca.boccassi@gmail.com>
References: <20210726135322.149850-59-luca.boccassi@gmail.com>
<20210803122214.1094992-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] patch 'net/virtio: fix default duplex mode' has been
queued to stable release 20.11.3
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 20.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/05/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/13ac5a51019ce36dd5de8a83d2298f54de487888
Thanks.
Luca Boccassi
---
>From 13ac5a51019ce36dd5de8a83d2298f54de487888 Mon Sep 17 00:00:00 2001
From: Chenbo Xia <chenbo.xia@intel.com>
Date: Tue, 27 Jul 2021 13:14:41 +0800
Subject: [PATCH] net/virtio: fix default duplex mode
[ upstream commit 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 ]
When virtio front-end initializes, the duplex mode should be set
unknown before reading any duplex mode information from configuration
space. This patch fixes the issue that duplex mode is by default set
to zero, which equals ETH_LINK_HALF_DUPLEX. This will lead to duplex
mode being half duplex when front-end does not have the feature
named VIRTIO_NET_F_SPEED_DUPLEX.
Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")
Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index f87c931d13..520f3fde54 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1994,6 +1994,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
if (ret < 0)
return ret;
hw->speed = speed;
+ hw->duplex = DUPLEX_UNKNOWN;
/* Allocate memory for storing MAC addresses */
eth_dev->data->mac_addrs = rte_zmalloc("virtio",
--
2.30.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-08-03 12:35:08.394240586 +0100
+++ 0004-net-virtio-fix-default-duplex-mode.patch 2021-08-03 12:35:08.170817850 +0100
@@ -1 +1 @@
-From 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 Mon Sep 17 00:00:00 2001
+From 13ac5a51019ce36dd5de8a83d2298f54de487888 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -23 +24 @@
-index a4adeec5ab..e58085a2c9 100644
+index f87c931d13..520f3fde54 100644
@@ -26 +27 @@
-@@ -1901,6 +1901,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
+@@ -1994,6 +1994,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)