* Re: [dpdk-stable] [PATCH v2] eal/windows: ensure all enabled CPUs are counted
2021-06-30 1:56 ` [dpdk-stable] [PATCH v2] eal/windows: ensure all enabled CPUs are counted Narcisa Ana Maria Vasile
@ 2021-08-04 14:56 ` Dmitry Kozlyuk
2021-08-04 20:40 ` Kadam, Pallavi
2021-08-18 13:46 ` [dpdk-stable] [PATCH v3] " Narcisa Ana Maria Vasile
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Kozlyuk @ 2021-08-04 14:56 UTC (permalink / raw)
To: Narcisa Ana Maria Vasile, talshn
Cc: dev, thomas, ocardona, pallavi.kadam, dmitrym, Narcisa Vasile, stable
2021-06-29 18:56 (UTC-0700), Narcisa Ana Maria Vasile:
> From: Narcisa Vasile <navasile@microsoft.com>
>
> rte_cpuset_t describes a set of CPUs by using an array of masks
> named '_bits'. Each element in the '_bits' array represents
> a bit mask, with each bit corresponding to a CPU.
> The maximum number of CPUs is given by 'CPU_SETSIZE'.
> The number of bit masks is computed using '_NUM_SETS(CPU_SETSIZE)'.
>
> count_cpu() should count the number of CPUs enabled in the set 's'.
> Currently, it iterates through the number of masks in the
> set 's', instead of iterating through all the bits in all the masks.
> For example, if '_NUM_SETS(CPU_SETSIZE)' returns 2,
> which means there are 2 bit masks: _bits[0] and _bits[1],
> count_cpu() would only check if CPUs '0' and '1' are enabled.
> The correct behavior is to iterate through all the CPUs in the set and
> count the ones that are enabled.
>
> This patch fixes count_cpu() to ensure all the bits in all the masks
> are checked to compute the correct number of CPUs enabled in 's'.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: pallavi.kadam@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> ---
> v2:
> * Fix commit message.
>
> lib/eal/windows/include/sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/windows/include/sched.h b/lib/eal/windows/include/sched.h
> index ff572b5dcb..bc31cc8465 100644
> --- a/lib/eal/windows/include/sched.h
> +++ b/lib/eal/windows/include/sched.h
> @@ -49,7 +49,7 @@ count_cpu(rte_cpuset_t *s)
> unsigned int _i;
> int count = 0;
>
> - for (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++)
> + for (_i = 0; _i < CPU_SETSIZE; _i++)
> if (CPU_ISSET(_i, s) != 0LL)
> count++;
> return count;
Sorry, I lost track of this patch.
Great and thorough explanation, but I don't think it needs to be so long.
Suggestion:
On Windows, -l/--lcores EAL option was unable to process CPU sets
containing CPUs other than 0 and 1, because CPU_COUNT() macro
only checked these CPUs in the set. Fix CPU_COUNT() by enumerating
all possible CPU indices.
Whatever message is taken in the end,
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH v2] eal/windows: ensure all enabled CPUs are counted
2021-06-30 1:56 ` [dpdk-stable] [PATCH v2] eal/windows: ensure all enabled CPUs are counted Narcisa Ana Maria Vasile
2021-08-04 14:56 ` Dmitry Kozlyuk
@ 2021-08-04 20:40 ` Kadam, Pallavi
2021-08-18 13:46 ` [dpdk-stable] [PATCH v3] " Narcisa Ana Maria Vasile
2 siblings, 0 replies; 6+ messages in thread
From: Kadam, Pallavi @ 2021-08-04 20:40 UTC (permalink / raw)
To: Narcisa Ana Maria Vasile, dev, thomas, dmitry.kozliuk, ocardona,
talshn, dmitrym
Cc: Narcisa Vasile, stable
On 6/29/2021 6:56 PM, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile <navasile@microsoft.com>
>
> rte_cpuset_t describes a set of CPUs by using an array of masks
> named '_bits'. Each element in the '_bits' array represents
> a bit mask, with each bit corresponding to a CPU.
> The maximum number of CPUs is given by 'CPU_SETSIZE'.
> The number of bit masks is computed using '_NUM_SETS(CPU_SETSIZE)'.
>
> count_cpu() should count the number of CPUs enabled in the set 's'.
> Currently, it iterates through the number of masks in the
> set 's', instead of iterating through all the bits in all the masks.
> For example, if '_NUM_SETS(CPU_SETSIZE)' returns 2,
> which means there are 2 bit masks: _bits[0] and _bits[1],
> count_cpu() would only check if CPUs '0' and '1' are enabled.
> The correct behavior is to iterate through all the CPUs in the set and
> count the ones that are enabled.
>
> This patch fixes count_cpu() to ensure all the bits in all the masks
> are checked to compute the correct number of CPUs enabled in 's'.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: pallavi.kadam@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> ---
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-stable] [PATCH v3] eal/windows: ensure all enabled CPUs are counted
2021-06-30 1:56 ` [dpdk-stable] [PATCH v2] eal/windows: ensure all enabled CPUs are counted Narcisa Ana Maria Vasile
2021-08-04 14:56 ` Dmitry Kozlyuk
2021-08-04 20:40 ` Kadam, Pallavi
@ 2021-08-18 13:46 ` Narcisa Ana Maria Vasile
2021-10-08 23:56 ` [dpdk-stable] [dpdk-dev] " Narcisa Ana Maria Vasile
2021-10-11 18:48 ` [dpdk-stable] " Thomas Monjalon
2 siblings, 2 replies; 6+ messages in thread
From: Narcisa Ana Maria Vasile @ 2021-08-18 13:46 UTC (permalink / raw)
To: dev, thomas, dmitry.kozliuk, khot, navasile, dmitrym, roretzla,
talshn, ocardona
Cc: bruce.richardson, david.marchand, pallavi.kadam, stable
From: Narcisa Vasile <navasile@microsoft.com>
On Windows, -l/--lcores EAL option was unable to process CPU sets
containing CPUs other than 0 and 1, because CPU_COUNT() macro
only checked these CPUs in the set. Fix CPU_COUNT() by enumerating
all possible CPU indices.
Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
Cc: pallavi.kadam@intel.com
Cc: stable@dpdk.org
Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
lib/eal/windows/include/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/windows/include/sched.h b/lib/eal/windows/include/sched.h
index ff572b5dcb..bc31cc8465 100644
--- a/lib/eal/windows/include/sched.h
+++ b/lib/eal/windows/include/sched.h
@@ -49,7 +49,7 @@ count_cpu(rte_cpuset_t *s)
unsigned int _i;
int count = 0;
- for (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++)
+ for (_i = 0; _i < CPU_SETSIZE; _i++)
if (CPU_ISSET(_i, s) != 0LL)
count++;
return count;
--
2.31.0.vfs.0.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal/windows: ensure all enabled CPUs are counted
2021-08-18 13:46 ` [dpdk-stable] [PATCH v3] " Narcisa Ana Maria Vasile
@ 2021-10-08 23:56 ` Narcisa Ana Maria Vasile
2021-10-11 18:48 ` [dpdk-stable] " Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Narcisa Ana Maria Vasile @ 2021-10-08 23:56 UTC (permalink / raw)
To: dev, thomas, dmitry.kozliuk, khot, navasile, dmitrym, roretzla,
talshn, ocardona
Cc: bruce.richardson, david.marchand, pallavi.kadam, stable
On Wed, Aug 18, 2021 at 06:46:00AM -0700, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile <navasile@microsoft.com>
>
> On Windows, -l/--lcores EAL option was unable to process CPU sets
> containing CPUs other than 0 and 1, because CPU_COUNT() macro
> only checked these CPUs in the set. Fix CPU_COUNT() by enumerating
> all possible CPU indices.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: pallavi.kadam@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
Can this be merged? This small fix will solve the issues related to threads
affinity on Windows. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH v3] eal/windows: ensure all enabled CPUs are counted
2021-08-18 13:46 ` [dpdk-stable] [PATCH v3] " Narcisa Ana Maria Vasile
2021-10-08 23:56 ` [dpdk-stable] [dpdk-dev] " Narcisa Ana Maria Vasile
@ 2021-10-11 18:48 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-10-11 18:48 UTC (permalink / raw)
To: navasile
Cc: dev, dmitry.kozliuk, khot, dmitrym, roretzla, talshn, ocardona,
stable, bruce.richardson, david.marchand, pallavi.kadam, stable
18/08/2021 15:46, Narcisa Ana Maria Vasile:
> From: Narcisa Vasile <navasile@microsoft.com>
>
> On Windows, -l/--lcores EAL option was unable to process CPU sets
> containing CPUs other than 0 and 1, because CPU_COUNT() macro
> only checked these CPUs in the set. Fix CPU_COUNT() by enumerating
> all possible CPU indices.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: pallavi.kadam@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
Applied, thanks.
Sorry for the delay.
^ permalink raw reply [flat|nested] 6+ messages in thread