From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DD5A0C56 for ; Thu, 12 Aug 2021 11:27:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80D8A40042; Thu, 12 Aug 2021 11:27:26 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2047.outbound.protection.outlook.com [40.107.102.47]) by mails.dpdk.org (Postfix) with ESMTP id 4CDA340042 for ; Thu, 12 Aug 2021 11:27:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7rqvJKY7y17eop0pDYzKKFOz6Drd2jvsSZz6abYb828LwOJ/EFFdFfbT5zmLvHLy/ZFyXv0+3a/Qt4kYioCysxjARAs/h6jQDGdbP0i8LKC+dsej2ww6VvQu3ZJ3d/OIx8OBs8mtZqa5/ZuleHR7FvznNjD7U/ZlWtvk8Xj5ESVFFBPFyiH8r/39E25H2AyEZxqCqHpvuS0alAX+0KzCNa+NRz2wfXcz1Fw1/8wH16WpK8PJgtMRqEnEdo65+5tTKAiROPvjxWsRmBaJcEA5quIRpaCnwHhIEq/wD+yeseryRLYoBROesS4AKD3rr/zuzFgl8oSB+kS/jciY0worg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DyiMy7NXWgsYQdPfl1J7ycxvVW0Vh4I/tKlr4Y7Ln1M=; b=V0022oAAYYBGTPcVxz9m9pdiGOU/mukr4u29O2KG4Ew04Om50LaVeyBVAdODbabg9Nex4MqkjLOrmxEGVJH96JDSB8C6D1INqJnKEVRPO4m+hDACK3R3kyyRrzNs8F4JMlkAQ7PqG6aS9GAOsB14bCbdjrL61dc3fhag7+dO3+jw8o8WBmY8mqOrppCM+M3aWBgrBT0JPc+xW88r8gpe9CT1dPe+wj8Bj3UvDkdHKXti2BrlWEPKh9LmgSIarwhQT0PLTCpVm/0H20YmkVVejXLjYVU+9IJdmpepWpxJdvCWIp9FLNFeDjuQZYmNKeFYIORdTzeHbIy/hz3OhcwZ1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DyiMy7NXWgsYQdPfl1J7ycxvVW0Vh4I/tKlr4Y7Ln1M=; b=KpMFH3dH4sN7apbx5pxFKvns/JuIkiGbXgNh0S52ZsnCbeoMfdJA4XK4zDDnIxfetEXURietK4XWbFlQ/rYYFa2WoqoceBy2m0AgRqgbeEucTLjA9yePPd7t+Xg1Vwt4q58a8rpjp/9kSmce+6Q8U14QYGEXBI1jOFurGBC3CzqG+rYOdgmyWObqNxm3ByK/d5Fw9VUFox5qLF6+JaTKN7S9RnhWHAoa1BqSaNudT0jiyKunAmXhTyu58SX7N510pURZzivOe43vTuSMDkJi+CAFV2E8JwH6e5cFweB84aLrLlFO4fG4FnwLT6TymU/AOLaRcId0JgE/koPX56Nreg== Received: from BN0PR04CA0040.namprd04.prod.outlook.com (2603:10b6:408:e8::15) by MWHPR12MB1952.namprd12.prod.outlook.com (2603:10b6:300:114::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Thu, 12 Aug 2021 09:27:22 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::9e) by BN0PR04CA0040.outlook.office365.com (2603:10b6:408:e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Thu, 12 Aug 2021 09:27:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.16 via Frontend Transport; Thu, 12 Aug 2021 09:27:22 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Aug 2021 09:27:18 +0000 From: Dmitry Kozlyuk To: CC: Asaf Penso , Matan Azrad Date: Thu, 12 Aug 2021 12:27:02 +0300 Message-ID: <20210812092702.2071831-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af1a782a-1eed-4c50-7861-08d95d7363c2 X-MS-TrafficTypeDiagnostic: MWHPR12MB1952: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:608; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PYjyxPfyh5/jm/H462/5Q2cXmn+1aQSi1LkXB+NVdznT8BO03FuNPWGAgpl+wr6f4Zf7j/ePE6ezwJ/sNuj4euCPtysEwiBX4e/4CIYxmbb4u38zbUOK0LPOSCuFMMjCGlSuINDc1iqHI4Jy2tz1g6QjzLrdNJ3ZGbiQy2uM4MiBjL3ovFfTpmQ8c1r9fPLiaDOnktoZOG4XsRxVUlX0bmw3qsOWN2keRnN4f+19CeI/EA1+ugEzA+d0TSa/rzfAF9jDwD9J5XJgjerqCRKUwy9fhceGPx/db2arI5WpyJqW9wKZ/ETteVGVLY3zoo/C9ibX2T8yXSqjORg56tu8IFA8qu8aCKBId2QRqaioAyP6jgiC/JYMKUog7WJfyGXzMoaoP2LswiSth0+8gfjdEX6EAPadMT2gh+891VN9Gi4ymc7GFDBCm1zByc9EDnOPf/me0NZqSRgmFkTdb+r5435bHnDeX3Qo/dNSBGL3szOb7rUdPRIMbX8nWXil3TygYpU2zDTMRMOFtNCoHyYAOh07r2ol1llngUbcRPVIRpw9rvscwhIKn3aIMAAW47SXTxnD1ZXVlZPDLHvE6CEUHtX4PbKxV/MJVDA4L4QscpmLYLgkQZfDHiPDdOigL23gRR9RJ7keLfCiuyhLRtxISipiZLM4xBMIpSqpK9xvqRWoxnGvNFMh6AVG6ofY3vOb4EtkIHSl3fxVqZYd/6B0bw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2906002)(6916009)(8676002)(8936002)(7636003)(86362001)(47076005)(82310400003)(36860700001)(4326008)(6286002)(83380400001)(5660300002)(6666004)(426003)(55016002)(54906003)(1076003)(70586007)(107886003)(36906005)(186003)(336012)(356005)(16526019)(70206006)(7696005)(2616005)(508600001)(316002)(36756003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2021 09:27:22.4318 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af1a782a-1eed-4c50-7861-08d95d7363c2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1952 Subject: [dpdk-stable] [PATCH 19.11] bus: clarify log for non-NUMA-aware devices X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" [ upstream commit e9b3d79b0696cd983ace8e6f65532b240f43a1bb ] PCI and vmbus drivers printed a warning when NUMA node had been reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users because the configuration is valid and nothing happens that requires attention or intervention. It was also printed without the device identification and with an indent (PCI only), which is confusing unless DEBUG logging is on to print the header message with the device name. Reduce level to INFO, reword the message, and suppress it when there is only one NUMA node because NUMA awareness does not matter in this case. Also, remove the indent for PCI. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- doc/guides/nics/ena.rst | 2 +- drivers/bus/pci/pci_common.c | 5 ++++- drivers/bus/vmbus/vmbus_common.c | 5 ++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index bbf27f235a..d39201c20b 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -198,7 +198,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device 0000:00:06.0 is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index ab73c009ac..cabfe69ec8 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -150,7 +151,9 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + if (rte_socket_count() > 1) + RTE_LOG(INFO, EAL, "Device %s is not NUMA-aware, defaulting socket to 0\n", + dev->name); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 3adef01c95..34676c48af 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -113,7 +114,9 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + if (rte_socket_count() > 1) + VMBUS_LOG(INFO, "Device %s is not NUMA-aware, defaulting socket to 0", + guid); dev->device.numa_node = 0; } -- 2.25.1