* [dpdk-stable] [PATCH v2] net/ixgbe: fix mbuf leak [not found] <20210831032805.5520-1-chenqiming_huawei@163.com> @ 2021-08-31 8:03 ` Qiming Chen 2021-08-31 8:06 ` Qiming Chen 1 sibling, 0 replies; 8+ messages in thread From: Qiming Chen @ 2021-08-31 8:03 UTC (permalink / raw) To: dev; +Cc: haiyue.wang, Qiming Chen, stable A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch scheme is to judge whether the pointer is empty when the port is stopped, and release the corresponding mbuf if it is not empty. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Cc: stable@dpdk.org Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> --- v2: Cc: stable@dpdk.org --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c814a28cb4..bfdfd5e755 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); rxq->rx_tail = 0; rxq->nb_rx_hold = 0; + + if (rxq->pkt_first_seg != NULL) + rte_pktmbuf_free(rxq->pkt_first_seg); + rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; -- 2.30.1.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2] net/ixgbe: fix mbuf leak [not found] <20210831032805.5520-1-chenqiming_huawei@163.com> 2021-08-31 8:03 ` [dpdk-stable] [PATCH v2] net/ixgbe: fix mbuf leak Qiming Chen @ 2021-08-31 8:06 ` Qiming Chen 2021-08-31 10:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor 2021-09-01 7:22 ` [dpdk-stable] [PATCH v3] " Qiming Chen 1 sibling, 2 replies; 8+ messages in thread From: Qiming Chen @ 2021-08-31 8:06 UTC (permalink / raw) To: dev; +Cc: haiyue.wang, Qiming Chen, stable A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch scheme is to judge whether the pointer is empty when the port is stopped, and release the corresponding mbuf if it is not empty. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Cc: stable@dpdk.org Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> --- v2: Sync to stable@dpdk.org --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c814a28cb4..bfdfd5e755 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); rxq->rx_tail = 0; rxq->nb_rx_hold = 0; + + if (rxq->pkt_first_seg != NULL) + rte_pktmbuf_free(rxq->pkt_first_seg); + rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; -- 2.30.1.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak 2021-08-31 8:06 ` Qiming Chen @ 2021-08-31 10:00 ` Kevin Traynor 2021-09-01 1:50 ` Qiming Chen 2021-09-01 7:22 ` [dpdk-stable] [PATCH v3] " Qiming Chen 1 sibling, 1 reply; 8+ messages in thread From: Kevin Traynor @ 2021-08-31 10:00 UTC (permalink / raw) To: Qiming Chen, dev; +Cc: haiyue.wang, stable On 31/08/2021 09:06, Qiming Chen wrote: > A local test found that repeated port start and stop operations during > the continuous SSE vector bufflist receiving process will cause the mbuf > resource to run out. The final positioning is when the port is stopped, > the mbuf of the pkt_first_seg pointer is not released. Resources leak. > The patch scheme is to judge whether the pointer is empty when the port > is stopped, and release the corresponding mbuf if it is not empty. > > Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") That is a file rename, it should be when the functionality was introduced, so in this case: Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> > --- > v2: > Sync to stable@dpdk.org > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index c814a28cb4..bfdfd5e755 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) > rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); > rxq->rx_tail = 0; > rxq->nb_rx_hold = 0; > + > + if (rxq->pkt_first_seg != NULL) > + rte_pktmbuf_free(rxq->pkt_first_seg); > + > rxq->pkt_first_seg = NULL; > rxq->pkt_last_seg = NULL; > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak 2021-08-31 10:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor @ 2021-09-01 1:50 ` Qiming Chen 2021-09-01 3:17 ` Wang, Haiyue 0 siblings, 1 reply; 8+ messages in thread From: Qiming Chen @ 2021-09-01 1:50 UTC (permalink / raw) To: ktraynor; +Cc: dev, haiyue.wang, stable This is already the oldest commit node in git, and it has not been recorded before。 Which commit should I fill in? | | Qiming Chen | | chenqiming_huawei@163.com | 签名由网易邮箱大师定制 On 8/31/2021 18:00，Kevin Traynor<ktraynor@redhat.com> wrote： On 31/08/2021 09:06, Qiming Chen wrote: A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch scheme is to judge whether the pointer is empty when the port is stopped, and release the corresponding mbuf if it is not empty. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") That is a file rename, it should be when the functionality was introduced, so in this case: Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> --- v2: Sync to stable@dpdk.org --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c814a28cb4..bfdfd5e755 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); rxq->rx_tail = 0; rxq->nb_rx_hold = 0; + + if (rxq->pkt_first_seg != NULL) + rte_pktmbuf_free(rxq->pkt_first_seg); + rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak 2021-09-01 1:50 ` Qiming Chen @ 2021-09-01 3:17 ` Wang, Haiyue 0 siblings, 0 replies; 8+ messages in thread From: Wang, Haiyue @ 2021-09-01 3:17 UTC (permalink / raw) To: Qiming Chen, ktraynor; +Cc: dev, stable Please reply with plain text format. ;-) This is better: Fixes: af75078fece3 ("first public release") From: Qiming Chen <chenqiming_huawei@163.com> Sent: Wednesday, September 1, 2021 09:51 To: ktraynor@redhat.com Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak This is already the oldest commit node in git, and it has not been recorded before。 Which commit should I fill in? Qiming Chen mailto:chenqiming_huawei@163.com 签名由 https://mail.163.com/dashi/dlpro.html?from=mail81 定制 On 8/31/2021 18:00，mailto:ktraynor@redhat.com wrote： On 31/08/2021 09:06, Qiming Chen wrote: A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch scheme is to judge whether the pointer is empty when the port is stopped, and release the corresponding mbuf if it is not empty. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") That is a file rename, it should be when the functionality was introduced, so in this case: Fixes: af75078fece3 ("first public release") Cc: mailto:stable@dpdk.org Signed-off-by: Qiming Chen <mailto:chenqiming_huawei@163.com> --- v2: Sync to mailto:stable@dpdk.org --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c814a28cb4..bfdfd5e755 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); rxq->rx_tail = 0; rxq->nb_rx_hold = 0; + + if (rxq->pkt_first_seg != NULL) + rte_pktmbuf_free(rxq->pkt_first_seg); + rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v3] net/ixgbe: fix mbuf leak 2021-08-31 8:06 ` Qiming Chen 2021-08-31 10:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor @ 2021-09-01 7:22 ` Qiming Chen 2021-09-06 1:22 ` Wang, Haiyue 1 sibling, 1 reply; 8+ messages in thread From: Qiming Chen @ 2021-09-01 7:22 UTC (permalink / raw) To: dev; +Cc: haiyue.wang, Qiming Chen, stable A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch scheme is to judge whether the pointer is empty when the port is stopped, and release the corresponding mbuf if it is not empty. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> --- v2: Sync to stable@dpdk.org v3: Modify fixes commit --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c814a28cb4..bfdfd5e755 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); rxq->rx_tail = 0; rxq->nb_rx_hold = 0; + + if (rxq->pkt_first_seg != NULL) + rte_pktmbuf_free(rxq->pkt_first_seg); + rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; -- 2.30.1.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v3] net/ixgbe: fix mbuf leak 2021-09-01 7:22 ` [dpdk-stable] [PATCH v3] " Qiming Chen @ 2021-09-06 1:22 ` Wang, Haiyue 2021-09-06 1:45 ` Zhang, Qi Z 0 siblings, 1 reply; 8+ messages in thread From: Wang, Haiyue @ 2021-09-06 1:22 UTC (permalink / raw) To: Qiming Chen, dev; +Cc: stable > -----Original Message----- > From: Qiming Chen <chenqiming_huawei@163.com> > Sent: Wednesday, September 1, 2021 15:23 > To: dev@dpdk.org > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen <chenqiming_huawei@163.com>; stable@dpdk.org > Subject: [PATCH v3] net/ixgbe: fix mbuf leak > > A local test found that repeated port start and stop operations during > the continuous SSE vector bufflist receiving process will cause the mbuf > resource to run out. The final positioning is when the port is stopped, > the mbuf of the pkt_first_seg pointer is not released. Resources leak. > The patch scheme is to judge whether the pointer is empty when the port > is stopped, and release the corresponding mbuf if it is not empty. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> > --- > v2: > Sync to stable@dpdk.org > v3: > Modify fixes commit > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Haiyue Wang <haiyue.wang@intel.com> > > -- > 2.30.1.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v3] net/ixgbe: fix mbuf leak 2021-09-06 1:22 ` Wang, Haiyue @ 2021-09-06 1:45 ` Zhang, Qi Z 0 siblings, 0 replies; 8+ messages in thread From: Zhang, Qi Z @ 2021-09-06 1:45 UTC (permalink / raw) To: Wang, Haiyue, Qiming Chen, dev; +Cc: stable > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue > Sent: Monday, September 6, 2021 9:22 AM > To: Qiming Chen <chenqiming_huawei@163.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak > > > -----Original Message----- > > From: Qiming Chen <chenqiming_huawei@163.com> > > Sent: Wednesday, September 1, 2021 15:23 > > To: dev@dpdk.org > > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen > > <chenqiming_huawei@163.com>; stable@dpdk.org > > Subject: [PATCH v3] net/ixgbe: fix mbuf leak > > > > A local test found that repeated port start and stop operations during > > the continuous SSE vector bufflist receiving process will cause the > > mbuf resource to run out. The final positioning is when the port is > > stopped, the mbuf of the pkt_first_seg pointer is not released. Resources > leak. > > The patch scheme is to judge whether the pointer is empty when the > > port is stopped, and release the corresponding mbuf if it is not empty. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com> > > --- > > v2: > > Sync to stable@dpdk.org > > v3: > > Modify fixes commit > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Acked-by: Haiyue Wang <haiyue.wang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi > > > > > > -- > > 2.30.1.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-06 1:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210831032805.5520-1-chenqiming_huawei@163.com>
2021-08-31 8:03 ` [dpdk-stable] [PATCH v2] net/ixgbe: fix mbuf leak Qiming Chen
2021-08-31 8:06 ` Qiming Chen
2021-08-31 10:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2021-09-01 1:50 ` Qiming Chen
2021-09-01 3:17 ` Wang, Haiyue
2021-09-01 7:22 ` [dpdk-stable] [PATCH v3] " Qiming Chen
2021-09-06 1:22 ` Wang, Haiyue
2021-09-06 1:45 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).