patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
	david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,
	ferruh.yigit@intel.com, michaelba@nvidia.com,
	viacheslavo@nvidia.com
Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-stable] [PATCH 3/3] net/mlx5: Fix RSS RETA update
Date: Fri, 10 Sep 2021 11:17:34 +0200	[thread overview]
Message-ID: <20210910091734.7023-4-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20210910091734.7023-1-maxime.coquelin@redhat.com>

This patch fixes RETA updating for entries above 64.
Without ithat, these entries are never updated as
calculated mask value will always be 0.

Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
Cc: stable@dpdk.org
Cc: nelio.laranjeiro@6wind.com

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/net/mlx5/mlx5_rss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c
index c32129cdc2..6dc52acee0 100644
--- a/drivers/net/mlx5/mlx5_rss.c
+++ b/drivers/net/mlx5/mlx5_rss.c
@@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
 	for (idx = 0, i = 0; (i != reta_size); ++i) {
 		idx = i / RTE_RETA_GROUP_SIZE;
 		pos = i % RTE_RETA_GROUP_SIZE;
-		if (((reta_conf[idx].mask >> i) & 0x1) == 0)
+		if (((reta_conf[idx].mask >> pos) & 0x1) == 0)
 			continue;
 		MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
 		(*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
-- 
2.31.1


  parent reply	other threads:[~2021-09-10  9:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  9:17 [dpdk-stable] [PATCH 0/3] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-10  9:17 ` [dpdk-stable] [PATCH 1/3] net/virtio: add initial RSS support Maxime Coquelin
2021-09-10 10:06   ` Andrew Rybchenko
2021-09-10 11:44     ` Maxime Coquelin
2021-09-10 12:58       ` Andrew Rybchenko
2021-09-10 13:10         ` Maxime Coquelin
2021-09-10  9:17 ` [dpdk-stable] [PATCH 2/3] app/testpmd: fix RSS hash type update Maxime Coquelin
2021-09-10  9:51   ` Andrew Rybchenko
2021-09-10  9:57     ` Maxime Coquelin
2021-09-10 10:06       ` Andrew Rybchenko
2021-09-10 14:16         ` Nélio Laranjeiro
2021-09-13  9:41           ` Maxime Coquelin
2021-09-14  7:20             ` Nélio Laranjeiro
2021-09-16  3:03               ` Li, Xiaoyun
2021-09-16  7:33                 ` Maxime Coquelin
2021-09-16  7:41                   ` Li, Xiaoyun
2021-09-16  8:08                     ` Maxime Coquelin
2021-09-16  8:30                       ` Li, Xiaoyun
2021-09-10  9:17 ` Maxime Coquelin [this message]
2021-09-21  9:55   ` [dpdk-stable] [PATCH 3/3] net/mlx5: Fix RSS RETA update Slava Ovsiienko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910091734.7023-4-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=michaelba@nvidia.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).