patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eal/windows: fix token pasting build warning
@ 2021-09-13 16:55 Tal Shnaiderman
  2021-09-15 19:25 ` Dmitry Kozlyuk
  0 siblings, 1 reply; 3+ messages in thread
From: Tal Shnaiderman @ 2021-09-13 16:55 UTC (permalink / raw)
  To: dev; +Cc: thomas, pallavi.kadam, dmitry.kozliuk, navasile, dmitrym, stable

When building DPDK on Windows in debug mode the following
warning appear:

warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
[-Wgnu-zero-variadic-macro-arguments] #define open(path, flags, ...)
_open(path, flags, ##__VA_ARGS__)

Modified the 'open' macro to avoid it.

Fixes: 45d62067c237 ("eal: make OS shims internal")

Signed-off-by: Tal Shnaiderman <>
 lib/eal/windows/include/rte_os_shim.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h
index 33619745ab..eda8113662 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -25,7 +25,7 @@
 #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
-#define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__)
+#define open(...) _open(__VA_ARGS__)
 #define read(fd, buf, n) _read(fd, buf, n)
 #define write(fd, buf, n) _write(fd, buf, n)
 #define close(fd) _close(fd)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-23 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 16:55 [dpdk-stable] [PATCH] eal/windows: fix token pasting build warning Tal Shnaiderman
2021-09-15 19:25 ` Dmitry Kozlyuk
2021-09-23 17:17   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).