* [dpdk-stable] [PATCH V2 2/2] net/mlx5: add support for more tunnel types
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 1/2] app/testpmd: add tunnel types Eli Britstein
@ 2021-09-23 8:43 ` Eli Britstein
2021-10-19 21:52 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-10-14 17:15 ` [dpdk-stable] [PATCH V2 1/2] app/testpmd: add " Ferruh Yigit
2021-10-14 18:29 ` Gregory Etelson
2 siblings, 1 reply; 6+ messages in thread
From: Eli Britstein @ 2021-09-23 8:43 UTC (permalink / raw)
To: dev
Cc: Ferruh Yigit, xiaoyun.li, Matan Azrad, Shahaf Shuler,
Slava Ovsiienko, Gregory Etelson, Eli Britstein, stable
Accept RTE_FLOW_ITEM_TYPE_GRE, RTE_FLOW_ITEM_TYPE_NVGRE and
RTE_FLOW_ITEM_TYPE_GENEVE as valid tunnel types.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Eli Britstein <elibr@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index c914a7120c..6a03fc52d7 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -9123,6 +9123,9 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev,
err_msg = "unsupported tunnel type";
goto out;
case RTE_FLOW_ITEM_TYPE_VXLAN:
+ case RTE_FLOW_ITEM_TYPE_GRE:
+ case RTE_FLOW_ITEM_TYPE_NVGRE:
+ case RTE_FLOW_ITEM_TYPE_GENEVE:
break;
}
--
2.28.0.2311.g225365fb51
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH V2 2/2] net/mlx5: add support for more tunnel types
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 2/2] net/mlx5: add support for more " Eli Britstein
@ 2021-10-19 21:52 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-10-19 21:52 UTC (permalink / raw)
To: Eli Britstein, dev
Cc: xiaoyun.li, Matan Azrad, Shahaf Shuler, Slava Ovsiienko,
Gregory Etelson, stable
On 9/23/2021 9:43 AM, Eli Britstein wrote:
> Accept RTE_FLOW_ITEM_TYPE_GRE, RTE_FLOW_ITEM_TYPE_NVGRE and
> RTE_FLOW_ITEM_TYPE_GENEVE as valid tunnel types.
>
> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Moving ack form first version of the set for record:
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH V2 1/2] app/testpmd: add tunnel types
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 1/2] app/testpmd: add tunnel types Eli Britstein
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 2/2] net/mlx5: add support for more " Eli Britstein
@ 2021-10-14 17:15 ` Ferruh Yigit
2021-10-14 18:29 ` Gregory Etelson
2 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-10-14 17:15 UTC (permalink / raw)
To: Eli Britstein, Matan Azrad, Gregory Etelson
Cc: xiaoyun.li, Shahaf Shuler, Slava Ovsiienko, stable, dev, Ori Kam
On 9/23/2021 9:43 AM, Eli Britstein wrote:
> Current testpmd implementation supports VXLAN only for tunnel offload.
> Add GRE, NVGRE and GENEVE for tunnel offload flow matches.
>
> For example:
> testpmd> flow tunnel create 0 type vxlan
> port 0: flow tunnel #1 type vxlan
> testpmd> flow tunnel create 0 type nvgre
> port 0: flow tunnel #2 type nvgre
> testpmd> flow tunnel create 0 type gre
> port 0: flow tunnel #3 type gre
> testpmd> flow tunnel create 0 type geneve
> port 0: flow tunnel #4 type geneve
>
> Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Hi Matan, Gregory,
Set looks good to me but can you please help reviewing it?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH V2 1/2] app/testpmd: add tunnel types
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 1/2] app/testpmd: add tunnel types Eli Britstein
2021-09-23 8:43 ` [dpdk-stable] [PATCH V2 2/2] net/mlx5: add support for more " Eli Britstein
2021-10-14 17:15 ` [dpdk-stable] [PATCH V2 1/2] app/testpmd: add " Ferruh Yigit
@ 2021-10-14 18:29 ` Gregory Etelson
2021-10-19 21:52 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Gregory Etelson @ 2021-10-14 18:29 UTC (permalink / raw)
To: Eli Britstein, dev
Cc: Ferruh Yigit, xiaoyun.li, Matan Azrad, Shahaf Shuler,
Slava Ovsiienko, stable
> Subject: [PATCH V2 1/2] app/testpmd: add
> tunnel types
>
> Current testpmd implementation supports
> VXLAN only for tunnel offload.
> Add GRE, NVGRE and GENEVE for tunnel offload
> flow matches.
>
> For example:
> testpmd> flow tunnel create 0 type vxlan
> port 0: flow tunnel #1 type vxlan
> testpmd> flow tunnel create 0 type nvgre
> port 0: flow tunnel #2 type nvgre
> testpmd> flow tunnel create 0 type gre
> port 0: flow tunnel #3 type gre
> testpmd> flow tunnel create 0 type geneve
> port 0: flow tunnel #4 type geneve
>
> Fixes: 1b9f274623b8 ("app/testpmd: add
> commands for tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Reviewed-by: Gregory Etelson <getelson@nvidia.com>
> ---
> app/test-pmd/config.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-
> pmd/config.c
> index f5765b34f7..2bb9fc6784 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1210,6 +1210,15 @@
> port_flow_tunnel_type(struct rte_flow_tunnel
> *tunnel)
> case RTE_FLOW_ITEM_TYPE_VXLAN:
> type = "vxlan";
> break;
> + case RTE_FLOW_ITEM_TYPE_GRE:
> + type = "gre";
> + break;
> + case RTE_FLOW_ITEM_TYPE_NVGRE:
> + type = "nvgre";
> + break;
> + case RTE_FLOW_ITEM_TYPE_GENEVE:
> + type = "geneve";
> + break;
> }
>
> return type;
> @@ -1270,6 +1279,12 @@ void
> port_flow_tunnel_create(portid_t port_id, const
> struct tunnel_ops *ops)
>
> if (!strcmp(ops->type, "vxlan"))
> type =
> RTE_FLOW_ITEM_TYPE_VXLAN;
> + else if (!strcmp(ops->type, "gre"))
> + type =
> RTE_FLOW_ITEM_TYPE_GRE;
> + else if (!strcmp(ops->type, "nvgre"))
> + type =
> RTE_FLOW_ITEM_TYPE_NVGRE;
> + else if (!strcmp(ops->type, "geneve"))
> + type =
> RTE_FLOW_ITEM_TYPE_GENEVE;
> else {
> fprintf(stderr, "cannot offload
> \"%s\" tunnel type\n",
> ops->type);
> --
> 2.28.0.2311.g225365fb51
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH V2 1/2] app/testpmd: add tunnel types
2021-10-14 18:29 ` Gregory Etelson
@ 2021-10-19 21:52 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-10-19 21:52 UTC (permalink / raw)
To: Gregory Etelson, Eli Britstein, dev
Cc: xiaoyun.li, Matan Azrad, Shahaf Shuler, Slava Ovsiienko, stable
On 10/14/2021 7:29 PM, Gregory Etelson wrote:
>> Subject: [PATCH V2 1/2] app/testpmd: add
>> tunnel types
>>
>> Current testpmd implementation supports
>> VXLAN only for tunnel offload.
>> Add GRE, NVGRE and GENEVE for tunnel offload
>> flow matches.
>>
>> For example:
>> testpmd> flow tunnel create 0 type vxlan
>> port 0: flow tunnel #1 type vxlan
>> testpmd> flow tunnel create 0 type nvgre
>> port 0: flow tunnel #2 type nvgre
>> testpmd> flow tunnel create 0 type gre
>> port 0: flow tunnel #3 type gre
>> testpmd> flow tunnel create 0 type geneve
>> port 0: flow tunnel #4 type geneve
>>
>> Fixes: 1b9f274623b8 ("app/testpmd: add
>> commands for tunnel offload")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Eli Britstein <elibr@nvidia.com>
>
> Reviewed-by: Gregory Etelson <getelson@nvidia.com>
>
Series applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread