From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Gagandeep Singh <g.singh@nxp.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Beilei Xing <beilei.xing@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Shijith Thotton <sthotton@marvell.com>,
Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
Harman Kalra <hkalra@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag
Date: Tue, 28 Sep 2021 10:10:54 -0700 [thread overview]
Message-ID: <20210928101054.0f6ad088@hermes.local> (raw)
In-Reply-To: <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru>
On Tue, 28 Sep 2021 19:48:54 +0300
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> Some drivers do not provide per-queue statistics. So, there is no point
> to have these misleading zeros in xstats.
>
> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Really?
It is useful to have zeros rather than random data there.
next prev parent reply other threads:[~2021-09-28 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 14:16 [dpdk-stable] [PATCH] net/sfc: " Andrew Rybchenko
2021-09-28 16:48 ` [dpdk-stable] [PATCH v2] drivers/net: " Andrew Rybchenko
2021-09-28 17:10 ` Stephen Hemminger [this message]
2021-09-29 6:38 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-09-30 13:00 ` Ferruh Yigit
2021-09-30 13:45 ` Andrew Rybchenko
2021-09-30 13:50 ` Andrew Rybchenko
2021-10-14 22:16 ` Ferruh Yigit
2021-10-14 22:19 ` [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928101054.0f6ad088@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=g.singh@nxp.com \
--cc=haiyue.wang@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=hyonkim@cisco.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=lironh@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rmody@marvell.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=shshaikh@marvell.com \
--cc=srinivasan@marvell.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).