From: Junfeng Guo <junfeng.guo@intel.com>
To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com,
junfeng.guo@intel.com, lingyu.liu@intel.com
Subject: [dpdk-stable] [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH
Date: Wed, 29 Sep 2021 12:31:34 +0000 [thread overview]
Message-ID: <20210929123134.1465507-1-junfeng.guo@intel.com> (raw)
In-Reply-To: <20210929111307.422672-1-junfeng.guo@intel.com>
If GTPU Extionsion header has no pdu_type setting, the parsed value of
gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK.
Thus, for this case, we should check gtp_psc_mask->pdu_type instead,
to set QFI field bit of GTPU_EH first.
Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields of GTPU UL/DL for FDIR")
Cc: stable@dpdk.org
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
drivers/net/iavf/iavf_fdir.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index 560589a496..227a089ce0 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1171,17 +1171,15 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
if (gtp_psc_spec && gtp_psc_mask) {
if (gtp_psc_mask->qfi == UINT8_MAX) {
input_set |= IAVF_INSET_GTPU_QFI;
- if (gtp_psc_spec->pdu_type ==
- IAVF_GTPU_EH_UPLINK)
+ if (!gtp_psc_mask->pdu_type)
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
- GTPU_UP, QFI);
- else if (gtp_psc_spec->pdu_type ==
- IAVF_GTPU_EH_DWLINK)
+ GTPU_EH, QFI);
+ else if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_DWLINK)
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
GTPU_DWN, QFI);
- else
+ else if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_UPLINK)
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
- GTPU_EH, QFI);
+ GTPU_UP, QFI);
}
rte_memcpy(hdr->buffer, gtp_psc_spec,
--
2.25.1
next prev parent reply other threads:[~2021-09-29 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 11:13 [dpdk-stable] [PATCH] " Junfeng Guo
2021-09-29 12:31 ` Junfeng Guo [this message]
2021-10-07 4:24 ` [dpdk-stable] [PATCH v2] " Zhang, Qi Z
2021-10-08 10:41 ` [dpdk-stable] [PATCH v3] " Junfeng Guo
2021-10-08 6:09 ` Zhang, Qi Z
2021-10-08 11:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929123134.1465507-1-junfeng.guo@intel.com \
--to=junfeng.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=lingyu.liu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).