From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E91DA0C4B for ; Tue, 5 Oct 2021 14:30:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1241A4136A; Tue, 5 Oct 2021 14:30:58 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by mails.dpdk.org (Postfix) with ESMTP id 3FA8F41346; Tue, 5 Oct 2021 14:30:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cvBmB3tCHnXGTj55o2mi67FQdDIiFgXY8IOTBArLvipRM/9o8oi4Pl/faYEu80Vz5ZXlQEVEVwUSr2uXcnpCwJuLQxKEzh9V1jUKeUZBCbLXVdoAao6Lo6YzUsLUg4+rVDjqMFw0bNAvRCbEMIDuskNhq7KEBbKBMZc4R0ZEb6DLmdFs3sI9feE520gxnnEtK0rpAkzyIeGukQ3czFxIWdALPckN6LSK15GRglw+evD4qnETUQJKIn1nsWmvX00Lu01wzMSSeyTWKZMaxcdl4zf/wQCmdjE45NDmyguYrHUJ6agaqed4rAhISNLRdu4bH27slj4Xso2Ocin4vY2oTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=AQ0QOIRZ1BvzzCFeRCuV6+WkyVc+t+WYVlFbIfYJcYlAkYBPL1HV0R9zvmNcDPUEG3hTY4QELBaMVRzPqTAWsbDLyKppaNvQtv26x141uSkN9ah24PW17GsqwWRTxClmBEOM+NFhPsxz9efOvWD8Vitfv+mPXRKCkZ0HiDaAPZ1I0w2ODtD5Ea3KyYpzl7q/B6esbcUJVlhHcM/KTMdLNAZy4Gjn4PcxIv0iF2Ue29AqUApnIJkAZT89UFfIPsaIcEn8EVJhkf7RhIldbT1yRr866rrYTXZA4FoUDZZBxHRiidvvf7r9Ge99z5uG37nR18D5egYJ/yxJtPsz6lg6/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=V6brkICV00iCy5RPrMOvcDvROHZOBDPyuAiYDgXE3Hd8s6Ra59jKRA1qO5WlR2q5liARA46qYGESdYR3z48zfps9T+Mqf1sTOxNmMkIjfQ60kLcK2a8aXZi/ZFabo1oTRVvqsDJtU65jUs4RTBrPyjfCcQnbBERx6IsnlYXQ5poPXeuv6fNxU9Yir0dZJyKV/C75/uWJOcACo0gmUswX0HXnnF36KzN9PD+USIyJlvMYAHNwW0OfHFIKDBFbNfGCByza69JWeRev8srFCKH1xqi+osMtJCDt3xDxp2++UKdi7/AuE0NdEEL4L8iTIKabpN06Kr90sTYdMP/x57M9AA== Received: from DM5PR07CA0095.namprd07.prod.outlook.com (2603:10b6:4:ae::24) by BY5PR12MB4227.namprd12.prod.outlook.com (2603:10b6:a03:206::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 12:30:54 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::ce) by DM5PR07CA0095.outlook.office365.com (2603:10b6:4:ae::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 12:30:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 12:30:54 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 12:30:52 +0000 From: Xueming Li To: CC: , Thomas Monjalon , "David Marchand" , , Gaetan Rivet Date: Tue, 5 Oct 2021 20:30:11 +0800 Message-ID: <20211005123012.264727-2-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211005123012.264727-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55d14eb4-d8c5-45d1-a6f9-08d987fbf9a7 X-MS-TrafficTypeDiagnostic: BY5PR12MB4227: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQ8Yh9ZUkZaSOK8vp9qaaqku0TTULEd3+pd6w7qyuuXG37LbMX2wHqwvjHfGQ15Pij5PYOxICoDYLyzTPPAzeDI74Ub7zZ9ux7AKtx81BDfgYIORcV/5JcHsZwCTKWVm/nxVKArjwa/c+uVivpes70wSTF6la0udXUxT1QsHduZy5i2JQ4psyM0MYMhTen/sUAqaEEVjGA8XRywKqmYfpzu8js3CTynHgqJp6XthzfMBXEQDhCMDpAo7Ni1WPql8C71pL9oqNrlEyceCtkKiOKMDNM1McjW/UmqzJg4y3wj8cR4HMZcfYa8hOviloL96JhIqRJp0oUvkylqu4VKODmO2yhIfMjhM9CGXQhNd71OMVL08tL6tVvaqU0ZypZxqKD783D3UHmLNtPXHD+km3NfESVVTH3H+MwqX/JD6AMPuO2auOofIfPUpBR2sJWjQI0pKzII8gUoll0QDNROnxYJFs5U6UINu2sdUAF+fnlgz/VT5oRkBksl04fmCO2IYo+kavS40vHEv76By7QmcwhNE7LcUpQV/SWK+QKGZ5aLJQdz1y2YVaL5Wb6ymU4FGvpru9DA0gyy25P6cXDf0VtIWM7BUeorJmSIOMMEFkW5nWh4FQ3cZ6yw1IR5ABV5ZLKc9jzj40dFVHVT+90vKALAfnETMfwGBeDn9D0bubY2ZOmKsX/J/IgXHAAUw4AighUmmDAmRQl4AGpad5NII9A== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(6666004)(86362001)(426003)(82310400003)(1076003)(508600001)(54906003)(36756003)(8936002)(70586007)(70206006)(316002)(356005)(8676002)(7636003)(6916009)(336012)(7696005)(36860700001)(26005)(83380400001)(55016002)(4326008)(186003)(16526019)(47076005)(6286002)(2906002)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 12:30:54.3607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55d14eb4-d8c5-45d1-a6f9-08d987fbf9a7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4227 Subject: [dpdk-stable] [PATCH 2/3] devargs: make bus key parsing optional X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Cc: stable@dpdk.org Signed-off-by: Xueming Li --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 691b5ea0180..f6fa3a5d6ce 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -85,11 +85,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -101,9 +100,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index e3786c6c02a..616cf77f229 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; } -- 2.33.0