From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18118A0C4C for ; Tue, 5 Oct 2021 17:55:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC5F2413E5; Tue, 5 Oct 2021 17:55:17 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by mails.dpdk.org (Postfix) with ESMTP id 91043413DC; Tue, 5 Oct 2021 17:55:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpyFUeQFbsp+RSjDGajO9LEWn/PpjdU4WQ/J+I0dsrRnIcDwWHjudS7fjWsY5f741kVSMFr74q4NOC5bNrxAtwq2T0S4O5iKKIN3utPWUHq+3MlaRgOadWyDfY10TWP4SB8bKHFnabawn9IalMyme6P3A5+WQGw4SrG6bhqq/W4BOm7P3DlUSvhoPpf2c7UAPeee3+cmlWIAyeyWn8xH4ALm56eA4NnylN2olz2bKwUd23JkVdPvxy0zYb/RL1A7lYcE2YDHtksnXehtFCQrKnpabgts1Q947qEGnf4Cze74L975b+/s75tozGwgrlxtXrFBQhVFkIwjlSlVqG10fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=SGttT9CNAwmuZjNu3+slGh9Y+O9vHXQuGEuSDPh17e3RxBK/ETimxqkdXFUWHxeEGH9gYVganoc+up6UBdyW4DVPInBrsCrav4dHmMeI+3FZRGjkkrdMLGO34UIfPN9bhYONe0V7WTATJfmZ8Cu7eLteETsKyGilWjB7SzKJh0QB//f8HK3NZPjGz30l+TDJKQAGMZyRQXnUw3WP+hYgPQU0mfep9raOXw5y4uEb/j6ku9emoILBmFvPpf3Dyrvwp2E0R14r5tXrOH9KAso5U/UIhfpv3ePiG/BR7+cAlzjMSM6R9BdvPYppq4aqdORMb3ORH2s4xrHH3gSDwO8A7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=Piht1rm2kXKFhCaMW/WlxzLh7s1BnO9N4sYFLl5cjMzxpO3WUBOBR1k2fv8BmkpPDF+OtcYIjbaPVGEbFGO6T9kMVm73w7PW1bAEYFlC+WFesiNtkErHkGbygK6SH+pihnCQ046lQXwhleFIOuJitey05QOO2RzOmkbfET63D+993Wx8iXoG0qwUmYQyzEsZbcQYAihr8fdc4e38D1EL/Tb7m45YGvie9rGk7vTDbGw2Sw7AQuq6U1h65uAag4Yi5AHIFJTeZUVdtS05Q50pcsm+pWvfCSa2fzZuibWKU1I9iceeKSed6K0apyuniEuhKRFTw2Q8+W1JU4B9Bcw8fQ== Received: from MWHPR04CA0070.namprd04.prod.outlook.com (2603:10b6:300:6c::32) by DM6PR12MB4356.namprd12.prod.outlook.com (2603:10b6:5:2aa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Tue, 5 Oct 2021 15:55:14 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:300:6c:cafe::6b) by MWHPR04CA0070.outlook.office365.com (2603:10b6:300:6c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17 via Frontend Transport; Tue, 5 Oct 2021 15:55:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:55:13 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 15:55:11 +0000 From: Xueming Li To: CC: , Thomas Monjalon , "David Marchand" , , Gaetan Rivet Date: Tue, 5 Oct 2021 23:54:34 +0800 Message-ID: <20211005155435.279043-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211005155435.279043-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ded85c27-5669-4584-947f-08d9881884e0 X-MS-TrafficTypeDiagnostic: DM6PR12MB4356: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J64a3ZEZ6ozS/t3706BHGe94bb9d7XjXBfqHZRY5qpv/vQS4HSFpQscnqB3yshLXGF0qVIQ5eCEL8JA6Qv4R9xJKl9ZN9CvI/TDxwga/cNGRVV5M6K6d1Rnw8mgXGSq0Q0dZ18Peqru0uP8n2LmuYMoWbP5+qYisEjwUkmMNe4NN3YeD1ldLIovWiG78meLGadVJc46WBhvQZIr2nFElTvOcGJ0zyvTyk3HAvc5pui0LMpN8pLF0/HSOfQ4v0JvQ59wjpdcwYydVpWifQZhMR+CoAc5zMJDy0Sv5FGHsKdpBp9N4PM0wjZ9qgZ4sA/tl3sX07Jj5Pjhtj8x7k5DsbBAX0y0OYgEWDTGfKZM6YkCLx6R0iXiKWtZRlDQyrdTqyFe3EfLBFUID6M+95nicFyODcxjZVeczHV2zVWY9xF9k8E7RdmlILBffa2rHZ8Kt7aqNJcWEdLNxYwr80Fge407FXGIeESapKJ/E6OAZADvVTdMHpwoAN2l3QhJ+k2jQa7VlA3FAl0hIdK5+WLri4z16hsGaSnljolpylCdsaFstltwyeUr8kTJVGbsYuFF26zAiu84FSEVfW9W3fQRvu3h/rED3plNtcED7I4g+nBsu2wAlsJKPwnFCGHLb6iPUvMojk5E38EvP+W9fBMSlsQ9V42tWZuO8vdXoFAV3/YxY91lFfxn5zORe8b1LuAYpqvNT5hKefdYjCA9wFPITPA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(426003)(26005)(70586007)(54906003)(6916009)(83380400001)(186003)(16526019)(4326008)(2616005)(316002)(86362001)(508600001)(1076003)(70206006)(336012)(82310400003)(8936002)(6286002)(2906002)(47076005)(8676002)(36860700001)(6666004)(356005)(7696005)(5660300002)(7636003)(36756003)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:55:13.7920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ded85c27-5669-4584-947f-08d9881884e0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4356 Subject: [dpdk-stable] [PATCH v1 2/3] devargs: make bus key parsing optional X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Cc: stable@dpdk.org Signed-off-by: Xueming Li --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 691b5ea0180..f6fa3a5d6ce 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -85,11 +85,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -101,9 +100,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index e3786c6c02a..616cf77f229 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; } -- 2.33.0