Re: [dpdk-stable] [PATCH v3 2/2] app/test: delete cmdline free function

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

2021-10-08 06:41 (UTC+0000), zhihongx.peng@intel.com:
> From: Zhihong Peng <zhihongx.peng@intel.com>
> 
> Cmdline will be released in cmdline_stdin_exit function,
> so it does not need to be released here.
> 
> Fixes: acdabc450ea0 (test: fix terminal settings on exit)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>

Except for backporting (see patch 1/2 comments),
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

> ---
>  app/test/test.c             | 1 -
>  app/test/test_cmdline_lib.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/app/test/test.c b/app/test/test.c
> index 173d202e47..5194131026 100644
> --- a/app/test/test.c
> +++ b/app/test/test.c
> @@ -233,7 +233,6 @@ main(int argc, char **argv)
>  
>  		cmdline_interact(cl);
>  		cmdline_stdin_exit(cl);
> -		cmdline_free(cl);
>  	}
>  #endif
>  	ret = 0;
> diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c
> index d5a09b4541..6bcfa6511e 100644
> --- a/app/test/test_cmdline_lib.c
> +++ b/app/test/test_cmdline_lib.c
> @@ -174,7 +174,6 @@ test_cmdline_socket_fns(void)
>  	/* void functions */
>  	cmdline_stdin_exit(NULL);
>  
> -	cmdline_free(cl);
>  	return 0;
>  error:
>  	printf("Error: function accepted null parameter!\n");